From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0A30A0C51 for ; Mon, 12 Jul 2021 10:02:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C69964118C; Mon, 12 Jul 2021 10:02:08 +0200 (CEST) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by mails.dpdk.org (Postfix) with ESMTP id 1095540685; Mon, 12 Jul 2021 10:02:07 +0200 (CEST) Received: by mail-io1-f51.google.com with SMTP id l5so21447858iok.7; Mon, 12 Jul 2021 01:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5Gw70aU/zgWjXJICTfr8R/Gj6bNUf5+09aGnjAzuS2Q=; b=TS5Q0DgM+Lyi9aDZy96MoB3ftBXW1R7f7z8vVS9ehzpuGbMmM8OPJug/hSiNyRWyTY QPnK6aYYY7kIEBGscLKHO7fs/0my3/gVAQkrnld0eEVNXFJ+kzQQdhQ8RDUojoeRmkd+ WW43xQUj4llrY8OH07Z0DHG4BT6EKDkMsI5DyYJFbz2iXJS7sEZJ4K4UOmzjp3ON4Sd6 P4M1SnWZwp8c1vZUUUMzoLb2D9fQcE/mEze0XzAESQKn53e16p+R90sB6681Dntf/7JX 7KZwrnniStLgK+DOFmZf5GX/D6kbXZ9u07JoKC7+ajqgCDi55jakYonaV4X3YiOXEvKh v3nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Gw70aU/zgWjXJICTfr8R/Gj6bNUf5+09aGnjAzuS2Q=; b=c62t+hUYHzmNgPCV9yp9f1lbxSuhaDKaiTa4LnJ3SHDFpdkTBVpzDenKb+nn6yvshl DFSDmQM7OJGP1KRIr+XaiHyIAEMGFXEs7U8nm7io6IlR84Yw0i90EQXKR7h4S7CK2jry OVhzKPAtAlMbYuoAyQA+q7euL6BNslfbQpUtdKYFt3NWLX+rj1TYW/fba8m3TJ4XUh4l GJ/xwtODZ+XegPEeRY1MpCMxldTmnhRK668OCKUDjVkruZx6npYk6TLE2y78/mrQMHY1 z9wbeZJ62Mit+T4+IsNPndDIV6p9E9InJyJgmNIkE3gQDDE1qIcgHPEqkuO8VdwEWAt/ iNRA== X-Gm-Message-State: AOAM530NBrOVSqPi3wHq57yZ+FL9t6bDbxskfI7EDgKfTJputiD4vzWT zcZ7qKjM+eFS7ZpHJBLcraTagK/CA3Q8REDRxv8= X-Google-Smtp-Source: ABdhPJyyrPa7wNmuGh97sZlUT3IsEORoJ8tpLziDw2ZboNzzdelhlcohKRnOA2ay5lY8Xl7BxiZxcltJs2BYkQXvH28= X-Received: by 2002:a6b:d20c:: with SMTP id q12mr37632883iob.59.1626076926524; Mon, 12 Jul 2021 01:02:06 -0700 (PDT) MIME-Version: 1.0 References: <20210711131143.11893-1-danat@marvell.com> In-Reply-To: <20210711131143.11893-1-danat@marvell.com> From: Jerin Jacob Date: Mon, 12 Jul 2021 13:31:40 +0530 Message-ID: To: Dana Vardi Cc: Jerin Jacob , dpdk-dev , Liron Himi , Tomasz Duszynski , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mvpp2: fix port max speed overflow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sun, Jul 11, 2021 at 6:41 PM wrote: > > From: Dana Vardi > > ethtool_cmd_speed return uint32 and after the arithmetic > operation in mrvl_get_max_rate func the result is out of range. > > Fixes: 429c394417 ("net/mvpp2: support traffic manager") > Cc: tdu@semihalf.com > Cc: stable@dpdk.org > > Signed-off-by: Dana Vardi > Reviewed-by: Liron Himi Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/mvpp2/mrvl_tm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mvpp2/mrvl_tm.c b/drivers/net/mvpp2/mrvl_tm.c > index a3150328d9..4d75f8e915 100644 > --- a/drivers/net/mvpp2/mrvl_tm.c > +++ b/drivers/net/mvpp2/mrvl_tm.c > @@ -57,7 +57,7 @@ mrvl_get_max_rate(struct rte_eth_dev *dev, uint64_t *rate) > > close(fd); > > - *rate = ethtool_cmd_speed(&edata) * 1000 * 1000 / 8; > + *rate = (uint64_t)ethtool_cmd_speed(&edata) * 1000 * 1000 / 8; > > return 0; > } > -- > 2.17.1 >