From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 439D5A09EF for ; Tue, 12 Jan 2021 15:21:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32197140DF2; Tue, 12 Jan 2021 15:21:25 +0100 (CET) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id 32B11140DD6; Tue, 12 Jan 2021 15:21:23 +0100 (CET) Received: by mail-io1-f53.google.com with SMTP id e22so4332810iom.5; Tue, 12 Jan 2021 06:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gbYDAAKqOrXbRbE4m9XfDo16VGFLXrUi+d0tTPDGyEQ=; b=R+04DdgodkF97C35m0NuGeHTs0PPvcnnBrMKsqImmBinyuTTk6aISr5rBEI9zLAq98 3vm1m5EIYYouumv/ig7QZRNpPwWGBO4YOapEFC/Q9UM52wZv5wWWhXOE8SaZBf2wj2ZW Uc1CMVRv5VWPg5hE07hfpVBDFZX6XyebQ/UvC2STAh0jl1c0JixKoY1TnZ8Kthob3YsR W++QCy4dH9Kt4EjIHgS02aNtTp93h3hvU8LMZ60N2VOEnr3SIAiLtJkYspI6txW0Ue8/ aplmMl0lKZaAkVJltbQhJiX08dHijhSSduNYHoMOInIPiKEMn004HvSvF/VzTxqVAWZn EkQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gbYDAAKqOrXbRbE4m9XfDo16VGFLXrUi+d0tTPDGyEQ=; b=M0MQoq4BaAv9ML7LNUBiCSWPiSvebxJMAAOkxx67pjGAk0l+okwWtPuuaZdcHpU5E6 1Sx6Vg/aMdg5yzqPdHxIvaQ3eHocHvyyHBx+wvC3IDQZfFhr4JyPMEC8DtVitCy3TjZH 35pJpighbxvhQva+tBx8kZRmpO+X/HTvmSyUXX1Y/336NtUo11wkT/yacOss90HLiHoF fWH6yfXBUi/l3EY29f9fX4OsbbH3ZbCF0AuVegJKbP1uVseS8gD6u30mN/3k2FMlgYt4 lucoF3SX1xd3ujk3tRm6tZ6kjpc9BKUlxED4Caq8750EBNeL8xjTG+sx25P6K1RWIWHU HuXg== X-Gm-Message-State: AOAM530fMjHFva/SR01bUIRymcVICdVukU4ZbAKxW0e2Lk7tNAiyvfA9 yDU5YKWlQKq/qB3WOLlfL0fyTPrQzAAiGCg++4k= X-Google-Smtp-Source: ABdhPJxlDgkMmRkP1JJg//4HsiojbClfYti5On6uv99YugJ5IXAVymxYjucF5GIlbmNkAs/xkqubKNvn2B34HneV0LA= X-Received: by 2002:a05:6e02:92f:: with SMTP id o15mr4095851ilt.130.1610461282431; Tue, 12 Jan 2021 06:21:22 -0800 (PST) MIME-Version: 1.0 References: <1607341035-9372-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1607341035-9372-1-git-send-email-wangyunjian@huawei.com> From: Jerin Jacob Date: Tue, 12 Jan 2021 19:51:06 +0530 Message-ID: To: wangyunjian , Ferruh Yigit Cc: dpdk-dev , Liron Himi , Zyta Szpak , "Lilijun (Jerry)" , xudingke , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Dec 7, 2020 at 5:07 PM wangyunjian wrote: > > From: Yunjian Wang > > The function rte_malloc() could return NULL, the return value > need to be checked. > > Fixes: ce7ea764597e ("net/mvneta: support Rx/Tx") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang Acked-by: Liron Himi Applied to dpdk-next-net-mrvl/for-main. Thanks > --- > drivers/net/mvneta/mvneta_rxtx.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/net/mvneta/mvneta_rxtx.c b/drivers/net/mvneta/mvneta_rxtx.c > index 10b6f57584..dfa7ecc090 100644 > --- a/drivers/net/mvneta/mvneta_rxtx.c > +++ b/drivers/net/mvneta/mvneta_rxtx.c > @@ -872,7 +872,17 @@ mvneta_rx_queue_flush(struct mvneta_rxq *rxq) > int ret, i; > > descs = rte_malloc("rxdesc", MRVL_NETA_RXD_MAX * sizeof(*descs), 0); > + if (descs == NULL) { > + MVNETA_LOG(ERR, "Failed to allocate descs."); > + return; > + } > + > bufs = rte_malloc("buffs", MRVL_NETA_RXD_MAX * sizeof(*bufs), 0); > + if (bufs == NULL) { > + MVNETA_LOG(ERR, "Failed to allocate bufs."); > + rte_free(descs); > + return; > + } > > do { > num = MRVL_NETA_RXD_MAX; > -- > 2.23.0 >