From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B28F542BF6 for ; Wed, 31 May 2023 15:22:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC5284161A; Wed, 31 May 2023 15:22:24 +0200 (CEST) Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by mails.dpdk.org (Postfix) with ESMTP id 0AFCA40A82; Wed, 31 May 2023 15:22:23 +0200 (CEST) Received: by mail-vs1-f52.google.com with SMTP id ada2fe7eead31-43951f7002dso1824913137.3; Wed, 31 May 2023 06:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685539342; x=1688131342; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8oEU/UMrh3X0GxgQMeSkFD1aIeE5rEx7h3Tg2RC0ocA=; b=AI6/0hgt0YpGUs3e7Jnl0h+JbcIpIkzJVyvlK4l93S2mPwrQB+Ctx6SRd6XwABXNfc 0t9ECNKSAv1gn2+A18feZhZFIxV0oFOXGcC6n1SGnukPKLIe20+n4EwlNU1ifS1niSPN MES3BlCOr7qKAwCtUbQyV18zxgM0JpPoQaGVnfZcvWZzjSkqB2PHfE75K0x+qM/oBC5q H4nRBOSxFencBPVmFoJQSUtKyukyp+duOLTd+/9kXeMkmmVNI21OoiO2BZgKBejQySw2 ImoohkccAf9x0v4hFmctM0uwGnCyEyNLFELp5mSBPA9mME1mO+L4/6svJXXMYQKGYJkO jF8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685539342; x=1688131342; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8oEU/UMrh3X0GxgQMeSkFD1aIeE5rEx7h3Tg2RC0ocA=; b=j6qoUuObKxwb7Fzfp3NrnRRwRyLfm0iUwgFdfVc46FRGln/ZwFPmiUchk55joVfXb2 5E2X97HgqDe534d+K9FC+3Oux6P0KoJlJMwQyT5199ETco7CwmOpqmZYY1tFgAAvin1J PAZfWMzujk5DMik2Fp+dEFOb0BSqVkugWzLUmKGiHhrmpWoBAPCo6zJg7pa+I2erc1rb u14N0ysxRfGlhYOf5GMXVCL/ZnK97HPUOJcB1s8XYCmKs1HF/3YL5LOcX1Ez9Pyy4BV6 9uRCem/5eEd6XYfZ8K7iaDBzJV+K8DG3BnaeuBVW4S7BCYunP/hm53VvsZdeciltA9+f ydgg== X-Gm-Message-State: AC+VfDw+MI7VbcnJoQ7plkBuCZTw6RU3XhgImBpqqiz1KMx5ZSuef4Z1 J6jAQ5XeqBhFDrh2wx9DuTWpmJKVHlhGA2tozJnbtslAjgb+geAooeQ= X-Google-Smtp-Source: ACHHUZ6ZLzxgYo4eVZKyOfbGScBGcKmoLaJUKK2/ay7kIG8M90EmmZZpRALmor1w36KDG8fxiSPd+B4GsuuJUDL/qT4= X-Received: by 2002:a67:e3b7:0:b0:437:da98:e7d2 with SMTP id j23-20020a67e3b7000000b00437da98e7d2mr1967639vsm.18.1685539342205; Wed, 31 May 2023 06:22:22 -0700 (PDT) MIME-Version: 1.0 References: <20230531124648.1358005-1-jerinj@marvell.com> In-Reply-To: <20230531124648.1358005-1-jerinj@marvell.com> From: Jerin Jacob Date: Wed, 31 May 2023 18:51:56 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7 To: jerinj@marvell.com Cc: dev@dpdk.org, bruce.richardson@intel.com, thomas@monjalon.net, david.marchand@redhat.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, May 31, 2023 at 6:17=E2=80=AFPM wrote: > > From: Jerin Jacob > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > changed to TIMESTAMP [2]. Fixed the following warning[1] by providing > the correct configuration option based on doxygen version. loongarch-compilation reported a build issue at http://mails.dpdk.org/archives/test-report/2023-May/402940.html https://mesonbuild.com/Reference-manual_returned_external_program.html#exte= rnal_programversion introduced in 0.62 version, so not sure how we can do version check without that. Another option is to just remove HTIML_TIMESTAMP from config file. Since 1.8.9 doxgen version, it is disabled by default. Thoughts? commit 3f2e8a3067712b025623e4420e6eb161febfd42b Author: Dimitri van Heesch Date: Thu Mar 5 21:54:12 2015 +0100 Bug 745439 - PATCH: please consider making doxygen output byte for byte identical between individual runs by default diff --git a/src/config.xml b/src/config.xml index 747686031..3d81a21a2 100644 --- a/src/config.xml +++ b/src/config.xml @@ -1889,13 +1889,13 @@ hr.footer { ]]> - [(HEAD detached at Release_1_9_5)]dell[doxygen] $ git describe 3f2e8a3067712b025623e4420e6eb161febfd42b Release_1_8_9_1-64-g3f2e8a306 > > [1] > Warning: Tag 'HTML_TIMESTAMP' at line 115 of file 'doc/api/doxy-api.conf' > has become obsolete. > > [2] > https://www.doxygen.nl/manual/config.html#cfg_timestamp > > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob > --- > doc/api/doxy-api.conf.in | 2 +- > doc/api/meson.build | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in > index 7e68e43c64..f5da1f2291 100644 > --- a/doc/api/doxy-api.conf.in > +++ b/doc/api/doxy-api.conf.in > @@ -112,7 +112,7 @@ GENERATE_DEPRECATEDLIST =3D YES > VERBATIM_HEADERS =3D NO > ALPHABETICAL_INDEX =3D NO > > -HTML_TIMESTAMP =3D NO > +@TS_PREFIX@TIMESTAMP =3D NO > HTML_DYNAMIC_SECTIONS =3D YES > HTML_EXTRA_STYLESHEET =3D @TOPDIR@/doc/api/custom.css > SEARCHENGINE =3D YES > diff --git a/doc/api/meson.build b/doc/api/meson.build > index 2876a78a7e..7fc5b064cd 100644 > --- a/doc/api/meson.build > +++ b/doc/api/meson.build > @@ -41,6 +41,12 @@ if get_option('werror') > cdata.set('WARN_AS_ERROR', 'YES') > endif > > +if doxygen.version().version_compare('>=3D1.9.7') > + cdata.set('TS_PREFIX', '') > +else > + cdata.set('TS_PREFIX', 'HTML_') > +endif > + > doxy_conf =3D configure_file(input: 'doxy-api.conf.in', > output: 'doxy-api.conf', > configuration: cdata) > -- > 2.40.1 >