From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BD82A0A00 for ; Mon, 11 Jan 2021 15:33:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FA6B140DDC; Mon, 11 Jan 2021 15:33:49 +0100 (CET) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id 0399D140DAA; Mon, 11 Jan 2021 15:33:47 +0100 (CET) Received: by mail-il1-f179.google.com with SMTP id v3so18597173ilo.5; Mon, 11 Jan 2021 06:33:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OMMV49bnyqdzgcW/HzeCufX66j91jLBXuSLZCYCPWz8=; b=utg/2aII2lp6uXEsfCRofGV8LG3bqNweZr/FCnkYniDcAqsbsXuyu/WBMawJQAVVV2 wVxH6Aj2Oh66hdRjK3C2JwV4muPM6cSDBoDt/y+fDFvknK9DcHelCa8ICyWsqdW/xNuz HtQ+8xeSiA8AfErerZAgTXEqPgq8f4hUGnHwp11NRGBPu0VosMiCxORpV7aeY4lOKPws RZzOPtWKjb4LWsQ3nJcBYSwS9eTjjMnskw7WKqPEYNDo5w9fc4d1ZM0m0Y8ERNQ1Mtjj BMBvGHxgVBYnrsmZHsjXl2MaWtuYF85j6dwh3PTp2jF+/M8lTmb8AgD3vQwZ2gJa8nmi yERw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OMMV49bnyqdzgcW/HzeCufX66j91jLBXuSLZCYCPWz8=; b=TqGQs4n7UFl/GkXdNxvlx1yD/D9h9teLtnTUmBaA3tBuqhyYvm0ltuVUvq+5lyRYy8 JAho15cVYhulJqKN8mP7LVLvXh2YrsphSjgLCS9aMyUDlHVU/e2fIIUs5x2PjpGG/uAr I2+KIllzM/UBaEwTd3FZOakXpAInxVSYoAT2ouTXSwJqMg5TM6DvzmQj4UAARSHxgXyM 58yc1TiPm0JLq+lMUEKgut6TwYMbJ0m8YAQ3Kpln9uj4W3Yf82g5PlUmMzT2ClKan3oR cAfi2GYDFYHdsQQhMhDjG0uxj/Ckn6d2Jps4wHHkiEhH4C6KGFpIWVO60JIs12taYcqK rrLw== X-Gm-Message-State: AOAM530ErP+xijCp6dafKCta/QkXy7VP3EEBrEWwgjpmVYNYk140yjmT NTBdDfdl5kNwmOrrEYuduubU96oJKhmn9m4VpZ0= X-Google-Smtp-Source: ABdhPJxTFq3RoXsu1l5Ze03lFwte805YhMeiQ57Esa9jgmt7WfNGK/TusWfrNFAoEdwWIS91R493Uc9VSa+b/1Afum8= X-Received: by 2002:a05:6e02:e45:: with SMTP id l5mr15504948ilk.294.1610375626373; Mon, 11 Jan 2021 06:33:46 -0800 (PST) MIME-Version: 1.0 References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-3-lironh@marvell.com> In-Reply-To: <20201202101212.4717-3-lironh@marvell.com> From: Jerin Jacob Date: Mon, 11 Jan 2021 20:03:30 +0530 Message-ID: To: Liron Himi Cc: Jerin Jacob , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 02/38] net/mvpp2: remove debug log on fast-path X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Dec 2, 2020 at 3:42 PM wrote: > > From: Liron Himi > > in case of non-ip frame the current code reached the 'default' In case of > case which result with function call to log a msg. > those kind of calls should not be performed on fast-path. > > The performance for this kind of frames increased by 50% > > Fixes: acab7d58c ("net/mvpp2: convert to dynamic logging") > Cc: stable@dpdk.org > > Signed-off-by: Liron Himi > Reviewed-by: Liron Himi Please remove the Reviewed-by if you have Signed-off, > --- > drivers/net/mvpp2/mrvl_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c > index 93fb30cdb..8c3278ec4 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.c > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > @@ -2171,7 +2171,6 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_desc *desc, > *l4_offset = *l3_offset + MRVL_ARP_LENGTH; > break; > default: > - MRVL_LOG(DEBUG, "Failed to recognise l3 packet type"); > break; > } > > @@ -2183,7 +2182,6 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_desc *desc, > packet_type |= RTE_PTYPE_L4_UDP; > break; > default: > - MRVL_LOG(DEBUG, "Failed to recognise l4 packet type"); There are other prints in fastpath such as "MRVL_LOG(ERR, "Failed to receive packets");", please remove those as well. > break; > } > > -- > 2.28.0 >