From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66F4CA2EFC for ; Mon, 14 Oct 2019 08:11:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EF511C137; Mon, 14 Oct 2019 08:11:09 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 001D81C137; Mon, 14 Oct 2019 08:11:07 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id q10so35592358iop.2; Sun, 13 Oct 2019 23:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K/R67lHQGFsYwQA+yraL4aRuOofgMBDhbQ6pU/D3v0E=; b=kIKABxzTxKIj5dvHctLfXwVWu0oOegphWxEU4qR8I6XkRgCVptZwnc2UYb0gIJQIlg XUlmLQYy7XmzX5vF71Sm4zn7SNoBHwPY4ySJnnyN7ufvDCoOBsHiceTKK6QVsDol7FPA mUS6XJFWx4oUVL+3Ny4dBbG+sx+hi59NVv0Gm/D6P4hf8h0gJDM8kf9tZJJGG+g8ygf2 ttd6RMbv0e/pSLYH0twSa89ra1lTnYH8WUPeD9SZe07vbsjE7LVci90rxuVnW3XwFfPy XQMTltky9x/37Cw9xRLmXIbs6VkOHhp1BpLpL6LpEUHTWDBTnVl6A+rxdvhjm9A55+g8 bo+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K/R67lHQGFsYwQA+yraL4aRuOofgMBDhbQ6pU/D3v0E=; b=UTfMYwtEfVJBkKjjveusLSH1oqmglfSLSxRdqxhYQhXu2LS+SHkKBR63YWw/esGix1 fH1Ijcyv4vVj2IQMKXvfdip0PqMgJl+/nUAGWM6FK3xkAjcXfZ31cwA5JebfCzgYqyhL CNx5SMufiNaGpdkDnVCIbIkpDpzm5SHVEihpCTMSNypf8dN+7aGfwMYteTY4KB4txX68 7bfQ10/ryBbLAIYCOJOSxg0wsrLS2JRbdecAfpXsrzEhqkA13MmjARYohG5d8Za+YxKn ULQY2EjkC6jD7cQ/zgaPNp526TV8S8rPEeZtphPIipOqV+aj9c9foAMuBA53GL3wJGok biuw== X-Gm-Message-State: APjAAAV53b0hvafoi1P2cWM2lgRHSj22XJfy7CgwAtK4yAZ2R6GIQzaC uy3bSOIDAAuWWIWJ6VRH2PGwVRQZPtCWc/ZYiV/SFRSHWvk= X-Google-Smtp-Source: APXvYqw8GSZsOnrxeKwQqAM/VGFS8Cctf4g/9Brvj5gsqQEseRzc7nKX0UF8Td29cbSw5rMXCOKuMPb+0cmHR68mAn0= X-Received: by 2002:a05:6638:8d:: with SMTP id v13mr36798324jao.104.1571033467044; Sun, 13 Oct 2019 23:11:07 -0700 (PDT) MIME-Version: 1.0 References: <20191014052134.12406-1-asomalap@amd.com> In-Reply-To: <20191014052134.12406-1-asomalap@amd.com> From: Jerin Jacob Date: Mon, 14 Oct 2019 11:40:55 +0530 Message-ID: To: asomalap@amd.com Cc: "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] =?utf-8?q?=5Bdpdk-dev=5D_=5BPATCH_v1_5/6=5D_crypto/?= =?utf-8?q?ccp=3A_enable_IOMMU_for_CCP_CCP_use_vdev_framework=2C_an?= =?utf-8?q?d_vdev_framework_don=E2=80=99t_support_IOMMU=2E_Adding_c?= =?utf-8?q?ustom_IOMMU_support_for_AMD_CCP_drives=2E?= X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Oct 14, 2019 at 10:52 AM wrote: > > From: Amaranath Somalapuram git commit subject not found. Make sure to run the following before submitting the patch ./devtools/check-git-log.sh ./devtools/checkpatches.sh > > Signed-off-by: Amaranath Somalapuram > --- > drivers/crypto/ccp/ccp_crypto.c | 244 ++++++++++++++++++++++++------- > drivers/crypto/ccp/ccp_dev.c | 56 ++----- > drivers/crypto/ccp/ccp_dev.h | 2 +- > drivers/crypto/ccp/ccp_pci.c | 1 + > goto fail; > + if(iommu_mode == 2) > + pci->kdrv = RTE_KDRV_VFIO; > + else if(iommu_mode == 0) > + pci->kdrv = RTE_KDRV_IGB_UIO; > + else if (iommu_mode == 1) > + pci->kdrv = RTE_KDRV_UIO_GENERIC; The crypto driver should not have iommu mode-specific handling. I am not sure about the problem statement. If the problem is, iommu support for PCI based vdev device then move the solution to common layer so that everyone can use it. If not, please share the problem statement.