From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A05C440F4 for ; Tue, 28 May 2024 19:43:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DECC4064E; Tue, 28 May 2024 19:43:58 +0200 (CEST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id 977064026C; Tue, 28 May 2024 19:43:53 +0200 (CEST) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-43fb0f2daadso4254801cf.3; Tue, 28 May 2024 10:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716918233; x=1717523033; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iJK/ulaiWfkIPWWaMhAWYoc6o/8AY6Uo+Gl94sLr8WQ=; b=kwjzO85qouzz5NoMIsrOCl0vWKMxXj3mfoDw8d2ZbKwQRRsoKjfijRN9Ny3xmsUdYD NWfgUy7q/hB+ELqU89bJs/9ggteTxA0UGGTnAjFHrweyNSpzg5HfwEv0MV4jCNXIzmwG P7d7OSD241BWnBuw2U4fTzfUJ325n7rKy1oDhVFBSj/AJdBzJ42dd5b5a/+Ak+FKCgUD RfYrY0MHh0xhw0V0R4ad8KHN4jYzpquuhArvJdK0pxu+PWHhocVhdkCEmgQcRQnx4GId DUcdSq0RAapzR6XHkS003HG7uz46EMj3eYC+3NdzhST2AtJPldh46f4FGHVp3Y3YCt6f ePPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716918233; x=1717523033; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iJK/ulaiWfkIPWWaMhAWYoc6o/8AY6Uo+Gl94sLr8WQ=; b=rJB+ZqK+MKZ1sEW871lgaDQqmUpQfYF5jWLkWkunIb6jxXgQygToVJ6Q+tDAV/Zj74 smqFaG/Xt1MQLXyuKxRAuple34wSmlXgwRyWTvsFOt9+OswjO5i4v+4GeRgCzKabVgd8 ls7cNXMYuV7zOlsSRdg9Zst87w8pmvK1eEKLLA/IkGkAo0H01hdM2CKnGmFNgHDJAkef NnQ3kj4I2iRA87NUR5WnB6xzV406i0BxiPLh8T/2XUfes7BvUpiNPMnc0K8+ySzop5ih WCn7YJkcWsWxMnvEuB711SUdYlqEDsIwP7WwIYxLFCdiH3VFvWZJPujKFufx5EGr+RdR wJRg== X-Forwarded-Encrypted: i=1; AJvYcCWmFBz8L8B1LRx1ah4kpquvTlgY9+2MwCASle0m4Or66VmymZrMKFQ6fHL7KiUtRTcTjaUwkJqBc7JeEgufj1Q= X-Gm-Message-State: AOJu0YwsxoSDdQPcezfuqgY9ojNx4mpqtiHTKQFwtHEGDVfyTXZf5S/L E/w3mYgkIwemeY/xUkLD05u6geE7LSxBXflLLhboTOqEeN1lee/zL6BfPsBuByEs9ItO6pG3341 Q+yc9OCvte2Bsit615DsWS+8tWZ4= X-Google-Smtp-Source: AGHT+IFi2ol+xVYCVWj99H7mTikQ7Jbb4c8Zk+g6PtXnINr9EKuAbGitgPFhyGNli9j/yV2pNs4+mIMNBAEzcqsK+D0= X-Received: by 2002:ac8:5751:0:b0:43e:3bc9:b5f0 with SMTP id d75a77b69052e-43fb0e88c97mr155136621cf.57.1716918232848; Tue, 28 May 2024 10:43:52 -0700 (PDT) MIME-Version: 1.0 References: <20240528083246.4016677-1-rbhansali@marvell.com> In-Reply-To: <20240528083246.4016677-1-rbhansali@marvell.com> From: Jerin Jacob Date: Tue, 28 May 2024 23:13:26 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: fix promiscuous state after MAC change To: Rahul Bhansali Cc: dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra , jerinj@marvell.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, May 28, 2024 at 2:18=E2=80=AFPM Rahul Bhansali wrote: > > If promiscuous mode is enabled and default MAC address is set > again then promiscuous mode gets disabled in hardware. > > This change will restore promiscuous behavior after configuring > default MAC address. > > Fixes: 5fe86db2a0dd ("net/cnxk: support MAC address set") > Cc: stable@dpdk.org > > Signed-off-by: Rahul Bhansali Applied to dpdk-next-net-mrvl/for-main. Thanks > --- > drivers/net/cnxk/cnxk_ethdev_ops.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_e= thdev_ops.c > index c8260fcb9c..b1093dd584 100644 > --- a/drivers/net/cnxk/cnxk_ethdev_ops.c > +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c > @@ -451,6 +451,13 @@ cnxk_nix_mac_addr_set(struct rte_eth_dev *eth_dev, s= truct rte_ether_addr *addr) > roc_nix_npc_mac_addr_set(nix, dev->mac_addr); > goto exit; > } > + > + if (eth_dev->data->promiscuous) { > + rc =3D roc_nix_mac_promisc_mode_enable(nix, true)= ; > + if (rc) > + plt_err("Failed to setup promisc mode in = mac, rc=3D%d(%s)", rc, > + roc_error_msg_get(rc)); > + } > } > > /* Update mac address to cnxk ethernet device */ > -- > 2.25.1 >