Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest

[Jerin Jacob <jerinjacobk@gmail.com>]

On Wed, Oct 7, 2020 at 3:43 PM Rao, Nikhil <nikhil.rao@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Sent: Saturday, October 3, 2020 2:36 PM
> > To: jerinj@marvell.com; thomas@monjalon.net; Rao, Nikhil
> > <nikhil.rao@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Jayatheerthan, Jay
> > <jay.jayatheerthan@intel.com>
> > Subject: [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest
> >
> > From: "Jay Jayatheerthan" <jay.jayatheerthan@intel.com>
> >
> > adapter_multi_eth_add_del() does vdev init but doesn't uninit them.
> > This causes issues when running event_eth_rx_adapter_autotest multiple
> > times.
> >
> > The fix does vdev uninit before exiting the test.
> >
> > Signed-off-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
> > ---
> >  app/test/test_event_eth_rx_adapter.c | 14 +++++++++++++-
> >  1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test/test_event_eth_rx_adapter.c
> > b/app/test/test_event_eth_rx_adapter.c
> > index dd3bce71b..71c946164 100644
> > --- a/app/test/test_event_eth_rx_adapter.c
> > +++ b/app/test/test_event_eth_rx_adapter.c
> > @@ -464,7 +464,7 @@ adapter_multi_eth_add_del(void)
> >       int err;
> >       struct rte_event ev;
> >
> > -     uint16_t port_index, drv_id = 0;
> > +     uint16_t port_index, port_index_base, drv_id = 0;
> >       char driver_name[50];
> >
> >       struct rte_event_eth_rx_adapter_queue_conf queue_config; @@ -
> > 484,6 +484,7 @@ adapter_multi_eth_add_del(void)
> >
> >       /* add the max port for rx_adapter */
> >       port_index = rte_eth_dev_count_total();
> > +     port_index_base = port_index;
> >       for (; port_index < RTE_MAX_ETHPORTS; port_index += 1) {
> >               snprintf(driver_name, sizeof(driver_name), "%s%u",
> > "net_null",
> >                               drv_id);
> > @@ -513,6 +514,17 @@ adapter_multi_eth_add_del(void)
> >               TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> >       }
> >
> > +     /* delete vdev ports */
> > +     for (drv_id = 0, port_index = port_index_base;
> > +          port_index < RTE_MAX_ETHPORTS;
> > +          drv_id += 1, port_index += 1) {
> > +             snprintf(driver_name, sizeof(driver_name), "%s%u",
> > "net_null",
> > +                             drv_id);
> > +             err = rte_vdev_uninit(driver_name);
> > +             TEST_ASSERT(err == 0, "Failed driver %s got %d",
> > +                         driver_name, err);
> > +     }
> > +
> >       return TEST_SUCCESS;
> >  }
> >
> > --
> > 2.17.1
> Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>


Series applied to dpdk-next-eventdev/main. Thanks.