From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6C17430E4 for ; Wed, 23 Aug 2023 17:31:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9F5242B8B; Wed, 23 Aug 2023 17:31:15 +0200 (CEST) Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by mails.dpdk.org (Postfix) with ESMTP id 5BCDB40223; Wed, 23 Aug 2023 17:31:13 +0200 (CEST) Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-7a257fabae5so1362977241.2; Wed, 23 Aug 2023 08:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692804672; x=1693409472; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/Vw9Yn4kM/3L2BVOM+YaPvNOOIegd7zp+uItpSr7qQ4=; b=DNRbfW/kUbzQvVdqSCBM5Mjn2liRiFQQmjoX0uagakc9+XZifNcBxwAHx3ov+87LfG oMxqjNh80jqq3L1K2eqEYY8wB6xftUm1X505UTnWMpLNCk9UU49IZWaUnxjNvl/jNdgH S6Idbk3b1P51tcDl4sOwo57AcdNFyHJekcBGwNDYGK7Po9WWyXDPZ2/8UyrK+3FqnuJb duG1eJqthg+17WCmTCa4MEgchhk7aVwsvIpBT13TRnbB6nu4S1jPVsXt4sPh5M21Z9Bc KfQtjSYJaWUkWgondxgU4yb4hK18DBJu5VyUE9RlXX3u+2x2EfghWX7VL1UBJy2WE1/E q7AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692804672; x=1693409472; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Vw9Yn4kM/3L2BVOM+YaPvNOOIegd7zp+uItpSr7qQ4=; b=BbJ2TaQyKigRerDhtorZqar7H5HkxIjFTnt4pP1WHYvLgRRpdIRHgfXkUdrBAMlp2j Je59X8EJZ4cWAvqFBEG9oZaM/4GgCB7ip/GLGbo5wO/BGl2Hzm0NtlRtl/PSR/ESo1ao TXX/ewUZpqIxaAjIRTp/ZrVpDAIe6upGSzKzzfCTmxe+h1pQnKYanYM5rXBLuY/iwSl+ B9lofuUPzOD6gGr18pbpmdpONSIBcCT/xbOesfPsy+y7z8nfZpoZSBzHQr6PFuTbot8H 292sxIfJVEF2OyHnP5W8BIfVnpCcK6lH1qc/EM+KbfnxfRm8P2MCJQqCQS/ptBbyecYA QGyQ== X-Gm-Message-State: AOJu0YzXohTwF3SQnjI+V7CWz0tk6pW5AkQfuiYrkxF53ZyxuT4mdrkZ pfMq92sasXKDqWR+yu7U9uKPhIqhuY76PphBxAMTiOZfg0s= X-Google-Smtp-Source: AGHT+IHy28MSwReTwFFsuoVvFrGXqPhu3uzWecN9Wf/jPd1BGi5Lh7c8tRxlObYSkeDMUCuLGzFXUMgRl4ivDpGjvqI= X-Received: by 2002:a67:fa58:0:b0:443:9037:d8d5 with SMTP id j24-20020a67fa58000000b004439037d8d5mr10918085vsq.23.1692804672413; Wed, 23 Aug 2023 08:31:12 -0700 (PDT) MIME-Version: 1.0 References: <20230821174942.3165191-1-amitprakashs@marvell.com> <20230823111525.3975662-1-amitprakashs@marvell.com> In-Reply-To: <20230823111525.3975662-1-amitprakashs@marvell.com> From: Jerin Jacob Date: Wed, 23 Aug 2023 21:00:45 +0530 Message-ID: Subject: Re: [PATCH v5 01/12] common/cnxk: use unique name for DPI memzone To: Amit Prakash Shukla Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, jerinj@marvell.com, stable@dpdk.org, Radha Mohan Chintakuntla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Aug 23, 2023 at 4:45=E2=80=AFPM Amit Prakash Shukla wrote: > > roc_dpi was using vfid as part of name for memzone allocation. > This led to memzone allocation failure in case of multiple > physical functions. vfid is not unique by itself since multiple > physical functions can have the same virtual function indices. > So use complete DBDF as part of memzone name to make it unique. > > Fixes: b6e395692b6d ("common/cnxk: add DPI DMA support") > Cc: stable@dpdk.org > > Signed-off-by: Radha Mohan Chintakuntla > Signed-off-by: Amit Prakash Shukla Updated the git commit as follows and series applied to dpdk-next-net-mrvl/for-next-net. Thanks commit 33e784c82a1f0e97cbc10e5a5bcd0bdc4738b3de (HEAD -> for-next-net) Author: Vamsi Attunuru Date: Wed Aug 23 16:45:25 2023 +0530 dma/cnxk: track last index return value Last index value might lost the order when dma stats are reset in between copy operations. Patch adds a variable to track the completed count, that can be used to compute the last index, also patch adds misc other changes. Signed-off-by: Vamsi Attunuru commit 93d72a0046aa924b9f36848b73027c181347c9e8 Author: Vamsi Attunuru Date: Wed Aug 23 16:45:24 2023 +0530 dma/cnxk: fix completion ring tail wrap Adds a check to avoid tail wrap when completion desc ring is full. Also patch increase max desc size to 2048. Fixes: b56f1e2dad38 ("dma/cnxk: add channel operations") Fixes: 3340c3e22783 ("dma/cnxk: add scatter-gather copy") Fixes: 681851b347ad ("dma/cnxk: support CN10K DMA engine") Cc: stable@dpdk.org Signed-off-by: Vamsi Attunuru commit 71d2cd2221fcd4715eb33a866a33ba8bc8be54f5 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:23 2023 +0530 dma/cnxk: enhance vchan support Added changes to realign dpi private structure based on vchan. Also resets DMA dev stats while starting dma device. Signed-off-by: Amit Prakash Shukla commit 370fabc5515b3b459c0bf21596a26bd3ca754bf8 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:22 2023 +0530 dma/cnxk: increase vchan per queue to max 4 To support multiple directions in same queue make use of multiple vchan per queue. Each vchan can be configured in some direction and used. Signed-off-by: Amit Prakash Shukla Signed-off-by: Radha Mohan Chintakuntla commit 495d2689eb21fffe0c2cc9a090971f656c736770 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:21 2023 +0530 dma/cnxk: update func field based on transfer type Use pfid and vfid of src_port for incoming DMA transfers and dst_port for outgoing DMA transfers. Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Amit Prakash Shukla commit b938db4eb11b4b9dfdd9929516cdb9d714942189 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:20 2023 +0530 dma/cnxk: support all models of cn10xxx Valid function pointers are set for DMA device operations i.e. cn10k_dmadev_ops are used for all cn10k devices. Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Amit Prakash Shukla commit a3b4b6da918c7380d9ffbf24f670c4bcf1e27494 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:19 2023 +0530 dma/cnxk: fix chunk buffer failure return code On chunk buffer alloc failure, ENOMEM is returned. As per DMA spec ENOSPC shall be returned on failure to allocate memory. This changeset fixes the same. Fixes: b56f1e2dad38 ("dma/cnxk: add channel operations") Cc: stable@dpdk.org Signed-off-by: Amit Prakash Shukla commit 28392a849e9e04040ad49a3c61d0d0f3f39ff6e3 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:18 2023 +0530 dma/cnxk: make completion ring buffer as dynamic Completion buffer was a static array per dma device. This would consume memory for max number of descriptor supported by device which might be more than configured by application. The change allocates the memory for completion buffer based on the number of descriptor configured by application. Signed-off-by: Amit Prakash Shukla Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:17 2023 +0530 dma/cnxk: fix device reconfigure Multiple call to configure, setup queues without stopping the device would leak the ring descriptor and hardware queue memory. This patch adds flags support to prevent configuring without stopping the device. Fixes: b56f1e2dad38 ("dma/cnxk: add channel operations") Cc: stable@dpdk.org Signed-off-by: Amit Prakash Shukla commit d32fabfad6a62959d2196a342605f64b787cd936 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:16 2023 +0530 dma/cnxk: fix device state When a device is not set to a ready state, on exiting the application proper cleanup is not done. This causes the application to fail on trying to run next time. Setting the device to ready state on successful probe fixes the issue. Fixes: 53f6d7328bf4 ("dma/cnxk: create and initialize device on PCI probing") Cc: stable@dpdk.org Signed-off-by: Amit Prakash Shukla commit 8c0b8bfa4b7d6ead026d2e22ac91f219303baa30 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:15 2023 +0530 dma/cnxk: support for burst capacity Adds support for the burst capacity. Call to the function return number of vacant space in descriptor ring for the current burst. Signed-off-by: Amit Prakash Shukla commit 9b6dc3fc98ad0be2f45b6eadbd88e13f0f0e1492 Author: Amit Prakash Shukla Date: Wed Aug 23 16:45:14 2023 +0530 common/cnxk: fix DPI memzone name roc_dpi was using vfid as part of name for memzone allocation. This led to memzone allocation failure in case of multiple physical functions. vfid is not unique by itself since multiple physical functions can have the same virtual function indices. So use complete DBDF as part of memzone name to make it unique. Fixes: b6e395692b6d ("common/cnxk: add DPI DMA support") Cc: stable@dpdk.org Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Amit Prakash Shukla