From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix segfault with incorrect timer adadpters
Date: Fri, 13 Nov 2020 15:26:31 +0530 [thread overview]
Message-ID: <CALBAE1PGxwURmnX57TyG5mBj3gDV0o6yqJGF8j-mN76HSxWj1g@mail.gmail.com> (raw)
In-Reply-To: <20201112174330.313-1-pbhagavatula@marvell.com>
On Thu, Nov 12, 2020 at 11:13 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix SEGFAULT when nb_timer_adapters command line parameter is
> set to 0.
>
> Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> app/test-eventdev/evt_options.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
> index 6994ac453..6aeab8257 100644
> --- a/app/test-eventdev/evt_options.c
> +++ b/app/test-eventdev/evt_options.c
> @@ -197,6 +197,10 @@ evt_parse_nb_timer_adptrs(struct evt_options *opt, const char *arg)
> int ret;
>
> ret = parser_read_uint8(&(opt->nb_timer_adptrs), arg);
> + if (opt->nb_timer_adptrs <= 0) {
> + evt_err("Number of timer adapters cant be <= 0");
> + return -EINVAL;
> + }
>
> return ret;
> }
> --
> 2.17.1
>
prev parent reply other threads:[~2020-11-13 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 17:43 pbhagavatula
2020-11-13 9:56 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PGxwURmnX57TyG5mBj3gDV0o6yqJGF8j-mN76HSxWj1g@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).