From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D85A3A00C5 for ; Fri, 4 Nov 2022 12:00:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C86E642D10; Fri, 4 Nov 2022 12:00:48 +0100 (CET) Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by mails.dpdk.org (Postfix) with ESMTP id 813E742D0E; Fri, 4 Nov 2022 12:00:47 +0100 (CET) Received: by mail-qv1-f54.google.com with SMTP id w10so2947511qvr.3; Fri, 04 Nov 2022 04:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7qv9BP4TvY3wX5xKcO6H95NUjx3fFq4pPIZIL1ZfDeM=; b=KNpRaaMyWIh9P8sI+mihto+7l1uz5kv6JA3F9HIXS4m4RpUNjE7L+j1EbQvx5HveIY 8GbeDIZX6j9pETi8Ukf+dqxt55SDMV1YJAKr/sS3YC5BSAZjbyl6O/MC4ofb8KrAP4Cp obyelmgIn0PANh+FdBV3iuo0deLQpk5uAg+bW8YmMAA+N1INyrQ1zCb5pAb+VFOcdtdY wEUdrRONxSmHen+O8I4aD4zvLe0TpUYcLBrq7SIEg4qzG9CNu7bvUSozgk6NVMwvoy4I WwymV0s557VwtIHPLoJkRgg2nMUojsw5XrxzMxobLNrqvrZUiq3AcA45jZASoQQl42Od e9Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7qv9BP4TvY3wX5xKcO6H95NUjx3fFq4pPIZIL1ZfDeM=; b=3IXOcsTD28fdFdmbQqjEwv31bOLjTydAN6H8gsVG1Tc1m2B7siKePJ4vyEfjj0CZKT iQJ7bCOKzCvDNMcgsFD3nQ8TNNwTaMZqBtHq55rkzggui4oH+8djVRrga21KO1FEPlr/ B5I6jAE65PsWVwkVKATlas49TcVwwjYJYBlREm59oGlrXLQc92xTluyBfuENWXYXX41c urWNqTtZuZfqzy6aLmFkRRB8XOz1WfsjQhsLUcj9Zovp5v1/aaOYN2TBrqkO7O4yZQvD guHZHekl6eglFdSu/FuRz//5kx0tDRvnTCmadV5dR6h8W9FCqJ2NpE7IFrOstedQjfyy GdcQ== X-Gm-Message-State: ACrzQf3e8MzchFDdGGFn8M6jY9jwHHX1X+DrCW8v15ojewYOYkcdQHeI 3y801CF/eVtCtpoqhEUbzAHVeDWrhbpP63ZmIyZ+YwY3GUQ= X-Google-Smtp-Source: AMsMyM4GjdtwYels0YrlSncKW6CxW/4VF74Y5NXNzdflsn1TqaWy3PFWDbyW7jnM0GEbj4uc9IiDQVI526E8vwqsrPE= X-Received: by 2002:a05:6214:5292:b0:4bb:634d:6505 with SMTP id kj18-20020a056214529200b004bb634d6505mr31564330qvb.61.1667559646831; Fri, 04 Nov 2022 04:00:46 -0700 (PDT) MIME-Version: 1.0 References: <20221103152204.2706555-1-ferruh.yigit@amd.com> <3277434.9LS3J3VOpE@thomas> <42f937a0-d308-ed59-ba35-fe2124a72d09@amd.com> In-Reply-To: <42f937a0-d308-ed59-ba35-fe2124a72d09@amd.com> From: Jerin Jacob Date: Fri, 4 Nov 2022 16:30:20 +0530 Message-ID: Subject: Re: [PATCH] event/dlb2: fix meson build To: Ferruh Yigit Cc: Thomas Monjalon , Timothy McDaniel , Kent Wires , dev@dpdk.org, David Marchand , stable@dpdk.org, Luca Boccassi , Bruce Richardson , "Mcnamara, John" , Abdullah Sevincer Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Nov 3, 2022 at 9:52 PM Ferruh Yigit wrote: > > On 11/3/2022 3:35 PM, Thomas Monjalon wrote: > > 03/11/2022 16:22, Ferruh Yigit: > >> "meson setup" fails when '-Werror' compiler flag is enabled [1]. > >> This is not a build error in the driver but a build error in meson > >> during "meson setup" stage. > >> > >> This issue exists for a while but meson takes it as a warning and > >> ignores it unless '-Werror' compiler flag is provided. > > [...] > >> Reproduced via `meson -Dc_args='-Werror' build` > > > > Is it different of 'meson --werror" as in devtools/test-meson-builds.sh > > or 'meson -Dwerror=true' as in .ci/linux-build.sh? > > > > As I checked now, it seems there is a difference. > > Via "meson --werror" & "meson -Dwerror=true", > '-Werror' flag is used to compile dpdk source code, but meson doesn't > use the flag for its internal logic, so this seems more proper usage. > > Via "meson -Dc_args='-Werror'" & "CFLAGS='-Werror' meson" usage, > '-Werror' flag is used both to compile dpdk code and meson internal > logic, so that is why this usage cause build error. > > > And independent from the above usage difference, event/dlb2 meson file > is wrong and this fix is required. > I assume 'dlb2_avx512.c' compiled because of the '-mavx512vl' fallback > and that is why mentioned error is not detected. + @abdullah.sevincer@intel.com Waiting from Ack from Abdullah to merge