From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4698D426B7 for ; Wed, 4 Oct 2023 08:42:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B0C9402DA; Wed, 4 Oct 2023 08:42:02 +0200 (CEST) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by mails.dpdk.org (Postfix) with ESMTP id 37B3640289; Wed, 4 Oct 2023 08:41:59 +0200 (CEST) Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4197bb0a0d9so11379021cf.3; Tue, 03 Oct 2023 23:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696401718; x=1697006518; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HpD3Oq175AUNEKpA751XwPjpceT/nbCbFcSChXclMus=; b=Cv6yzavjzyK6EovfDH64Gk320YaoydxGetVCIz4/0zwZfCeuN7WW6esIqhJMLstwzZ rIS1Cwu5gwTWWlrKefpc1g1eYzs1Aq4QCwvREl2Mn+ya7XWRdIfdqwI+JCWGTn5anvC3 rnZlfdHUaS2dKQIIaXLB83kENSSVMSeDwGdwCHSlOv5LMeWdE5iyNvIL+p2EMbZUgZTB DRPWFUnWG2bhjjiBB8J7y4nzWVBTwB+l2QkaUfNHK+NlTJukVQNHfi+AfAaCDjbbTzai vv0OgjpMYcf86G31/KryhmSWwHniAx+qifx/x+J3mPKMiGwscanyj0mkByxkJ+Z3m2T+ orBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696401718; x=1697006518; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HpD3Oq175AUNEKpA751XwPjpceT/nbCbFcSChXclMus=; b=tvkoMwPGc8I8G3EkA5K9Uvh+Jb2Q6D4D3/W+L9VCRC28MdH8XDuaEujSamp3qaDhGe Tif4E4r4WrNWYP2NALXK2JFfwXQMezqsX42QcXU1gmV8lxvZuQX0rgeUZrsgIKamgztM +IBzdXQPhJ9tR8OBZOx0McC506Qbfm3NoI50awYQg/QpjjbZP93A5JEttsNVZ19OVJ/+ DptTlzvfq1Lz1YpEIOTbUQ+8RHkCuSuOmn8aT37SAMN2W9c+BwOouJE8RhUQgmhYJcfm pT/fSdLEXE9FpT3IOctup/YqnC3G7v7WZ335qFCXUeUIyItxslCMhy08wDL5cTdiL0eG 318g== X-Gm-Message-State: AOJu0YyNUzXvcvAn47ecNLlAQXLFvffL4f2MjTiJ6iYD4YcPSVqldpJc DoW4ctMjZP9pKf7j6+mvwP6ZbMh1OvkDFhVe6V4= X-Google-Smtp-Source: AGHT+IEo9lE0yfcp/oFNIKcti1Oq8tzsgTuy1irhoNhSFzI9EF/DF/9E3Wc8uYuaN8QFdYyBngK08J5lM7yhDxfv0RA= X-Received: by 2002:ac8:4e54:0:b0:412:3092:feab with SMTP id e20-20020ac84e54000000b004123092feabmr1750797qtw.50.1696401718412; Tue, 03 Oct 2023 23:41:58 -0700 (PDT) MIME-Version: 1.0 References: <20231003183956.1270510-1-jerinj@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 4 Oct 2023 12:11:31 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix direct rte symbol usage To: David Marchand Cc: jerinj@marvell.com, dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Long Li , Tyler Retzlaff , Konstantin Ananyev , Thomas Monjalon , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , Liron Himi , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Oct 4, 2023 at 11:41=E2=80=AFAM David Marchand wrote: > > Hello Jerin, > > On Tue, Oct 3, 2023 at 8:40=E2=80=AFPM wrote: > > > > From: Jerin Jacob > > > > The common code is shared between different driver environments, > > introduce missing plt_ abstractions of missing rte_ symbols and > > use plt symbols to avoid changing roc_* files. > > > > Also update the thread name for outbound soft expiry thread > > in a7ba40b2b1bf7. > > > > Fixes: 3d4e27fd7ff0 ("use abstracted bit count functions") > > Fixes: a7ba40b2b1bf ("drivers: convert to internal control threads") > > Fixes: c88d3638c7fc ("common/cnxk: support REE") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jerin Jacob > > - Could we add something in checkpatch for this driver? I will add it. > I was aware of this s/rte_/plt_/ peculiarity but still missed it... > > - If you want this backported in LTS, I suggest splitting the fix > against c88d3638c7fc ("common/cnxk: support REE") and the rest than > only affects current release. I will split it the REE change. > > - One comment: > > > diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnx= k/roc_nix_inl_dev.c > > index 6aa191410b..614d0858e5 100644 > > --- a/drivers/common/cnxk/roc_nix_inl_dev.c > > +++ b/drivers/common/cnxk/roc_nix_inl_dev.c > > @@ -826,7 +826,7 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev *= inl_dev) > > soft_exp_consumer_cnt =3D 0; > > soft_exp_poll_thread_exit =3D false; > > rc =3D plt_thread_create_control(&inl_dev->soft_exp_poll_thread= , > > - "outb-poll", nix_inl_outb_poll_thread, inl_dev)= ; > > + "outb-soft-exp-poll", nix_inl_outb_poll_thread,= inl_dev); > > Such a thread name is too long. > This is reverting Thomas change. > > Is this intentional? Yes, as mentioned in git commit log. Are 19 characters OK, right? If not, I will reduce it, "outb-poll" too generic. Also update the thread name for outbound soft expiry thread in a7ba40b2b1bf7 > > -- > David Marchand >