From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BBF3A054E for ; Mon, 9 Mar 2020 09:16:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 842DD1BFFF; Mon, 9 Mar 2020 09:16:54 +0100 (CET) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 6505A1BECF; Mon, 9 Mar 2020 09:16:52 +0100 (CET) Received: by mail-il1-f195.google.com with SMTP id a14so4713652ilk.6; Mon, 09 Mar 2020 01:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qDQBx/AaoMJ1spZbZnznfRw6XauycUDQZCxNToiCTIk=; b=A7aZTUBPxE7z7pQYoWFwAK3XJ0xHqXEcUbqKFdEDUDlrDj2Y7gxHRs0jkyH1KJ1Nh/ 3r6mUb3FJ+zAm1KH26ItHO0U0VOKqTAsQnCv7zPkbJiwWV34YW0n1DQrl93r8e/Iaewu aYKxaRP8uIIITlZdmMwK1Fh0xwXEM4GdJ+gS3EArOXV2KWw2H3sHGagjEtH5Rg50WskW 5J1xEhXmJVn5fxiEBt2nT5QQ2RH5UedP0Fs8etk3Lw2BrdyezTGnInR31VosY0XS+o12 2ZETE1D4tkK1qRizNWIEHBJTiDpR0mI3rWntsoqdsz80ANE5Z2n/1aTYEqG5CyMGMo+9 fnkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qDQBx/AaoMJ1spZbZnznfRw6XauycUDQZCxNToiCTIk=; b=MwdJ40UHS5xzs+fYfB7uOoQGWVS03bOAwU3fptC539w6bPV219v7CozWleFmYCDrG5 zW5goCTcJKca+LSiueoATx84F3gNR1VpA6uigTYk8Bc+r4lX0R4qSgSP6BYSoPjiNXVa MP+Hs8SMyjDUSMzwaEHHCHBrWNkj+EqSexasOV+nqjsMwkhI2ShGlxkpMGJKfEGBvI/u x8liCsAFq2tmMjIB576DXs3Cdk6N13B2ZUKYVxJv4Mw6aJgI1cT/0OsX8bhhP3mHcQ2G NMGZDDmTtZbNb2ltyNIl7Q1bJIFetJFVSvfTqUVdLLUYfr0OZra0zxH++ocQE1YcHkr9 igrA== X-Gm-Message-State: ANhLgQ2dGy9smo//rhttld/D9lD2jeObdz4N6pSvV5AWDV9c51XOoi2K 0w70wEqMhNbNGCrkeNgPJ4QmbmD14l82sivlp98= X-Google-Smtp-Source: ADFU+vvjaNRphk97qz57xjBXYYXXM/OjjgKuXRXogZ0MWsYrmpU3tv1bL25igKcOKODQQhrAqKBrgKS2L1NCoEsFUBU= X-Received: by 2002:a05:6e02:606:: with SMTP id t6mr14406918ils.271.1583741811537; Mon, 09 Mar 2020 01:16:51 -0700 (PDT) MIME-Version: 1.0 References: <20200309075328.23351-1-skori@marvell.com> In-Reply-To: <20200309075328.23351-1-skori@marvell.com> From: Jerin Jacob Date: Mon, 9 Mar 2020 13:46:35 +0530 Message-ID: To: Sunil Kumar Kori Cc: Alfredo Cardigliano , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/1] net/ionic: use standard stdbool.h X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Mar 9, 2020 at 1:23 PM Sunil Kumar Kori wrote: > > Any DPDK public header file which includes stdbool.h may conflict with > local definition of bool, if any, which further results in compilation > error. To avoid, used standard stdbool.h instead of defining bool > internally. > > I observed this issue during a development where I included rte_uuid.h > into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started > throwing error as given below: > > CC ionic_rxtx.o > In file included from .../dpdk/build/include/rte_uuid.h:17:0, > from .../dpdk/build/include/rte_ethdev.h:161, > from .../dpdk/build/include/rte_ethdev_driver.h:18, > from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34: > .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data t= ypes in declaration specifiers > typedef uint8_t bool; > ^ > In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0, > from .../dpdk/drivers/net/ionic/ionic.h:13, > from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8, > from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45: > .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name= in empty declaration > typedef uint8_t bool; > ^~~~~~~ > cc1: warning: unrecognized command line option =E2=80=98-Wno-address-of-p= acked-member=E2=80=99 > .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxt= x.o' failed > > Signed-off-by: Sunil Kumar Kori > --- > > diff --git a/drivers/net/ionic/ionic_osdep.h b/drivers/net/ionic/ionic_os= dep.h > index ecdbc24e6..6ca5426ec 100644 > --- a/drivers/net/ionic/ionic_osdep.h > +++ b/drivers/net/ionic/ionic_osdep.h > @@ -45,7 +45,6 @@ typedef uint32_t __le32; > typedef uint64_t __le64; > > #ifndef __cplusplus > -typedef uint8_t bool; > #define false 0 > #define true 1 You could remove the above as well(#define false and #define true) > #endif