From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD53943D02 for ; Mon, 25 Mar 2024 15:27:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8CC940271; Mon, 25 Mar 2024 15:27:44 +0100 (CET) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by mails.dpdk.org (Postfix) with ESMTP id C28BA4021D for ; Mon, 25 Mar 2024 15:27:43 +0100 (CET) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-609f1b77728so48622597b3.3 for ; Mon, 25 Mar 2024 07:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711376863; x=1711981663; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wOAA7xfAlzGgkONxdzFXFD9aNeKqVccjsYcMhGbHxJQ=; b=Ty4aiDPK8S5Zd1ckMTZ7TPdlksPNClR/U942LcKBqkKLDcnJ95mZVW18q2AxB1RO68 Rjtp+M+C8FMHegt/8BtTEP8oYsvvAIJW3P5lS9DEWoVimp4bkQb6ZEXZ0JYFD65MHULb bgaXFg5dkBWcyObH2JrrnW18wkvjqWlzE0P/hwQ+5xS7tC7Cwpc81QdMs+jhsQ4mnXxr dR+02J1cxQqvZKkM0A+RYRlg5CQHjMqxsFbkxQNkUJJr5Hz8kLGUH+J4XmGVYXeDHI0r Hp/YGuUd6vRujlVaGBMs4flWkYDvTN4NscLlJrRzmLGCCgCX4VGI7KC2QkoJgpz1nLUh ng8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711376863; x=1711981663; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wOAA7xfAlzGgkONxdzFXFD9aNeKqVccjsYcMhGbHxJQ=; b=P+N4yg4wKo4vAJk9qEEGhDFo7kTAVi/9pruXuR6W+F2xOvDyzqfnc4kusoFUwviF4J jo3kxF4YEImMlDq+avPXoLmA/wGa/iZDuZs2Gqd8ssAjm+365XyT4vCZpnZVQ0unkEuv fYEZAy0zCmPm7wtI9To81FwfGo6gsraRutRjBbGC9WBpjPd5C0L8QtiO4Gu2bXiFn+PS kcGrQkFxoU8iL63Y5ONN403a5hrJsr/OXBFJof/3P2h5GVx4VxCRRQt01HDHiaMcCQDO 3B6zNrrRCzVTWMsSQXGG4tL2FWQ9uDw5P3D1j9j5+4JD497VxsoiYPuQSb51j5GgrlUx mrzQ== X-Forwarded-Encrypted: i=1; AJvYcCX2JQJDfegkJxGzdbWZZinX3O9iFWjU/biDdTM+ftblQxFRRs1KHqE1b6oN+nAG2XgTGhaBQJFlC0lj017m0JI= X-Gm-Message-State: AOJu0Yz9YE7fuio5G9A2QZjRSOEISoOJrCzgVb7EfG53oUWWZBZbc6xy iakoUvKR1+Dp9Ls8vMO1dTQz1Jfl2GRC0jdR+Gvnr73zPw32QOHdNTtWRShEDXoywr/C4RKwFA5 0DZ2Wq0SdB4ocoFQTZEe4GJfVJBk= X-Google-Smtp-Source: AGHT+IH/tFQ09P4ASC5KOE+P3Hv5Dsi52CYlxQEtmPS7K805qW5UEnjh9KvxPt23Fbq5i9tX8OIefla/uDJVsHSbZeo= X-Received: by 2002:a81:9246:0:b0:60a:13f3:9990 with SMTP id j67-20020a819246000000b0060a13f39990mr6151113ywg.15.1711376863034; Mon, 25 Mar 2024 07:27:43 -0700 (PDT) MIME-Version: 1.0 References: <20231019000255.3823-1-luca.boccassi@gmail.com> In-Reply-To: From: Luca Boccassi Date: Mon, 25 Mar 2024 14:27:31 +0000 Message-ID: Subject: Re: please help backporting some patches to stable release 20.11.10 To: "Richardson, Bruce" Cc: "Chris Brezovec (cbrezove)" , dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org At least for 22.11 it doesn't apply cleanly, context has changed quite a bit, so it would need to be backported by a pmd maintainer/developer On Mon, 25 Mar 2024 at 14:06, Richardson, Bruce wrote: > > Trying to remember now, but I believe I originally encountered the issue = fixed by 12016895fc in the context of setting up runtime queue reconfigurat= ion from commit [1]. In the absence of that new feature being backported, I= assumed there was no need to backport the fix, since others had not previo= usly reported it. Since it seems that was a mistake, we should indeed look = to backport the patch in question. > > > > Stable-tree maintainers, can we re-add 12016895fc to the list of backport= s for next point releases? > > > > Regards, > > /Bruce > > > > [1] http://git.dpdk.org/dpdk/commit/?id=3Dd492ea071056a8a0de2991c42daee9d= 9acca8e35 > > > > PS: Link in your email is inaccessible to me, it=E2=80=99s perhaps a cisc= o-internal-only reference. > > > > From: Chris Brezovec (cbrezove) > Sent: Monday, March 25, 2024 1:34 PM > To: Richardson, Bruce ; dpdk stable > Subject: Re: please help backporting some patches to stable release 20.11= .10 > > > > Hey Bruce, > > > > I was wondering why you thought it was ok to skip backporting 12016895fc = to earlier releases? > > > > It looks like I ran into this issue on v21.11and v22.11. I patched this = back locally and saw that we no longer were leaking mbufs in TX queue stop = with IAVF. It did not patch cleanly because https://polaris-git.cisco.com/= iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201 was no= t backported either. > > > > It does seems like this issue exists in earlier releases though, so wonde= ring the reasoning for not backporting. > > > > Thanks! > > -Chrisb > > > > > > From: Richardson, Bruce > Date: Monday, October 23, 2023 at 5:39=E2=80=AFAM > To: dpdk stable > Subject: RE: please help backporting some patches to stable release 20.11= .10 > > Ok to skip 12016895fc, it should not be necessary for backport. > > > -----Original Message----- > > From: luca.boccassi@gmail.com > > Sent: Thursday, October 19, 2023 1:03 AM > > To: dpdk stable > > Cc: Sinha, Abhijit ; Burakov, Anatoly > > ; Xing, Beilei ; Bern= ard > > Iremonger ; Richardson, Bruce > > ; Chandubabu Namburu ; Powe= r, > > Ciara ; Doherty, Declan ; > > Deepak Kumar Jain ; Dmitry Kozlyuk > > ; Ferruh Yigit ; Ferruh Yigi= t > > ; Trahe, Fiona ; Vargas, > > Hernan ; Jie Hai ; Wu, > > Jingjing ; Griffin, John ; > > Konstantin Ananyev ; Leyi Rong > > ; Long Li ; Matan Azrad > > ; Maxime Coquelin ; Chaut= ru, > > Nicolas ; Zhang, Qi Z = ; > > Nicolau, Radu ; Singhal, Saurabh > > ; Selwin Sebastian ; > > Somalapuram Amaranath ; Thomas Monjalon > > ; Wei Hu ; Lu, Wenzhuo > > > > Subject: please help backporting some patches to stable release 20.11.1= 0 > > > > Hi commit authors (and maintainers), > > > > Despite being selected by the DPDK maintenance tool ./devtools/git-log- > > fixes.sh > > I didn't apply following commits from DPDK main to 20.11 > > stable branch, as conflicts or build errors occur. > > > > Can authors check your patches in the following list and either: > > - Backport your patches to the 20.11 branch, or > > - Indicate that the patch should not be backported > > > > Please do either of the above by 2023/10/26. > > > > You can find the a temporary work-in-progress branch of the coming > > 20.11.10 > > release at: > > https://github.com/bluca/dpdk-stable > > It is recommended to backport on top of that to minimize further confli= cts > > or > > misunderstandings. > > > > Some notes on stable backports: > > > > A backport should contain a reference to the DPDK main branch commit > > in it's commit message in the following fashion: > > [ upstream commit ] > > > > For example: > > https://git.dpdk.org/dpdk- > > stable/commit/?h=3D18.11&id=3Dd90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > > > > When sending the backported patch, please indicate the target branch in > > the > > subject line, as we have multiple branches, for example: > > [PATCH 20.11] foo/bar: fix baz > > > > With git format-patch, this can be achieved by appending the parameter: > > --subject-prefix=3D'PATCH 20.11' > > > > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org". > > > > FYI, branch 20.11 is located at tree: > > https://git.dpdk.org/dpdk-stable > > > > Thanks. > > > > Luca Boccassi > > > > --- > > 12016895fc Bruce Richardson net/iavf: fix buffer leak on Tx queue stop > > d7d52b37e8 Ciara Power crypto/qat: fix raw API null algorithm dig= est > > 7d04891664 Hernan Vargas baseband/acc: fix ACC100 HARQ input alignm= ent > > 37b68fa144 Jie Hai app/testpmd: fix primary process not polli= ng > > all queues > > e35a5737a7 Saurabh Singhal net/iavf: unregister interrupt handler bef= ore > > FD close > > a27ff9cac1 Selwin Sebastian net/axgbe: identify CPU with cpuid > > 26c6bdf3d1 Wei Hu net/mana: add 32-bit short doorbell > > 74decf3bf0 Wei Hu net/mana: enable 32-bit build