From: Luca Boccassi <bluca@debian.org>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Ali Alnubani <alialnu@nvidia.com>
Cc: Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
stable@dpdk.org
Subject: Re: [PATCH 22.11] net/mlx5: fix incorrect counter cache dereference
Date: Fri, 19 Apr 2024 23:21:40 +0100 [thread overview]
Message-ID: <CAMw=ZnRJn6q4znUwBZUYTTZUjJp66T+ScgDGgEaXp432z-PV9w@mail.gmail.com> (raw)
In-Reply-To: <20240419130949.55341-1-dsosnowski@nvidia.com>
On Fri, 19 Apr 2024 at 14:10, Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
>
> When counter pool is prepopulated with preallocated counters,
> some counters were preloaded to per-queue caches.
> Per-queue counter cache can be disabled due to a change introduced in
> commit 244dbbf77871 ("net/mlx5: fix flow counter cache starvation").
> Aforementioned preload happened even if counter cache was disabled,
> which caused a segmentation fault on the attempt to access the cache.
>
> This patch adds a missing check for counter cache before preloading.
>
> Fixes: 244dbbf77871 ("net/mlx5: fix flow counter cache starvation")
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_hws_cnt.c | 38 ++++++++++++++++++---------------
> 1 file changed, 21 insertions(+), 17 deletions(-)
Applied and pushed.
Ali, is this the issue you mentioned on the validation report? If so
is it all green now after this is included?
next prev parent reply other threads:[~2024-04-19 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 13:09 Dariusz Sosnowski
2024-04-19 22:21 ` Luca Boccassi [this message]
2024-04-20 6:58 ` Ali Alnubani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMw=ZnRJn6q4znUwBZUYTTZUjJp66T+ScgDGgEaXp432z-PV9w@mail.gmail.com' \
--to=bluca@debian.org \
--cc=alialnu@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).