From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64CB64638F for ; Thu, 13 Mar 2025 01:06:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CD04402BB; Thu, 13 Mar 2025 01:06:18 +0100 (CET) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by mails.dpdk.org (Postfix) with ESMTP id C8F48402BB for ; Thu, 13 Mar 2025 01:06:16 +0100 (CET) Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e4419a47887so372820276.0 for ; Wed, 12 Mar 2025 17:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741824376; x=1742429176; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZowVNndj+qTfCDk/ONG6G2Uiv8jR9WBQrfhmH7vsVRs=; b=LaACpRLCE+3ugRXqvQuC84lSEWdrkXL8A8vIUwCbo070DkbKO2r736UJX7olW6erPO 1eCJyXaPKNwZE5AoF/Ncda1TUcLSSqB5ssxej0o6ojTdsVVPzYSScjydW5HBP3q5rW6E MY1XAtAQlBsvYk0oTyhdKbQoWAXJJDDUQoRKw3faTQiLQEuPt9IVfLRWjI5qXDR5DacF i5tFesa4u+8OUO2IGHUZhnsjBCO7zw8KC2cAlqb753Bj9QmdYqJ6l0pYDL83XF6UVkoV DSvvKqgN8ebKU78MWSny83/xH7HVIFtkP5loQ2Z4fbfD01qax7aJLq+7f/a1PgLjqrQx xo6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741824376; x=1742429176; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZowVNndj+qTfCDk/ONG6G2Uiv8jR9WBQrfhmH7vsVRs=; b=Dh7NevE8EqHTLdSLbTfzhq6zrl0wrLenmzPwlYvHW17DrOCJOYkjIECU5KhFoHpoX2 D2BNgxrRZle4ddEcjKB/wmTZOsMfjq9VIBbgh1ux/dZoiop2KhtuI3Mo+l7jAoLwY3xj J9XAG2NkojwSOttLp5ZXh9ee9g0focKe6+SpwJQ1w19HK5pIBB8J/uzgVZ3RmlzT2bCx IXDEayVrAyOVu2VsDV4fiBKx7bUWIWtFjIIO8daz3WFnxhMFbRFmjy+YJOFmRGmZzRw0 sYoBUP5v/ggmgt2gKRNTcy4IwjuoN4LP0z/pwKDPFFmW9Koc3TNWptYVh/qfofg+3xr9 JG7w== X-Gm-Message-State: AOJu0YwpCfISkMAl/eAYI4A9vV7sm9CCGRKcawICiTtOPRa2ssGpybGi 3HKzJtkAMteOlQiAAsf8JAMNomcHbEb6DWvN6mtGMzMLdxa1n2RMNJAPeLtiu7q6RbGnM2D8BJe 6FIH1cvbRUQitXqqLnYhD3+LSXZ8yjA== X-Gm-Gg: ASbGncu2x2SXviefcO8reBJ1KglZmy7hMiZkvdXe7VTbn4/SIoq4XFkBP6EO81d6m3D gGSL95btlGnCDv5Rjx8zxCdfdFRRzuYWRLrElje0TbDxXcsYYxm83zaKxOdw9Ug+EbV4IpCSEg/ 6XXiqBnmiGltUkMHaMEeARSzoUX/owrwT3KbbWolOaPnaiRKQt+VO+scjAlyGi X-Google-Smtp-Source: AGHT+IHqIdrLadNf9cOP9UipGua0zMN9vFtpdTVEWQicBSssN5vOcRxQ252gUQdOSU9GU5qnwWgtFECFvcV/rD+u2yI= X-Received: by 2002:a05:6902:27c7:b0:e63:ca13:efb7 with SMTP id 3f1490d57ef6-e63ca9cac9cmr4640905276.19.1741824376039; Wed, 12 Mar 2025 17:06:16 -0700 (PDT) MIME-Version: 1.0 References: <1741818796-591-1-git-send-email-longli@linuxonhyperv.com> In-Reply-To: <1741818796-591-1-git-send-email-longli@linuxonhyperv.com> From: Luca Boccassi Date: Thu, 13 Mar 2025 00:06:05 +0000 X-Gm-Features: AQ5f1JqN9usszxmtJvKZ_ra2VRua5cc3hzjfuP36aZGH9OeXqgmYtGE-mX6BFak Message-ID: Subject: Re: [Patch 22.11] net/mana: fix multi-process tracking To: longli@linuxonhyperv.com Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 12 Mar 2025 at 22:33, wrote: > > From: Long Li > > [ upstream commit 57aa3ec91ecf13ab2f11e4dc0dc74c50a2afa0cc ] > > The driver uses mana_shared_data for tracking usage count for primary > process. This is not correct as the mana_shared_data is allocated > by the primary and is meant to track usage of secondary process by the > primary process. And it creates a race condition when the device is > removed because the counter is no longer available if this shared > memory is freed. > > Move the usage count tracking to mana_local_data and fix the race > condition in mana_pci_remove(). > > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") > Cc: stable@dpdk.org > > Signed-off-by: Long Li > --- > drivers/net/mana/mana.c | 100 ++++++++++++++++++++++------------------ > drivers/net/mana/mana.h | 6 +-- > drivers/net/mana/mp.c | 2 +- > 3 files changed, 58 insertions(+), 50 deletions(-) Thanks, applied