From: Luca Boccassi <luca.boccassi@gmail.com>
To: Oleksandr Nahnybida <oleksandrn@interfacemasters.com>
Cc: stable@dpdk.org, stephen@networkplumber.org
Subject: Re: [PATCH 22.11] pcapng: fix handling of chained mbufs
Date: Mon, 28 Oct 2024 16:59:22 +0000 [thread overview]
Message-ID: <CAMw=ZnScu-Hu=m-eqqyVOKnR8odg=H_AemSCCV3Z-O=6qhSNWQ@mail.gmail.com> (raw)
In-Reply-To: <20241028140044.278128-1-oleksandrn@interfacemasters.com>
On Mon, 28 Oct 2024 at 14:03, Oleksandr Nahnybida
<oleksandrn@interfacemasters.com> wrote:
>
> [ upstream commit 6db358536fee7891b5cb670df94ec87543ddd0fb ]
>
> The pcapng generates corrupted files when dealing with chained mbufs.
> This issue arises because in rte_pcapng_copy the length of the EPB block
> is incorrectly calculated using the data_len of the first mbuf instead
> of the pkt_len, despite that rte_pcapng_write_packets correctly writing
> the mbuf chain to disk.
>
> This fix ensures that the block length is calculated based on the pkt_len,
> aligning it with the actual data written to disk.
>
> Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files")
>
> Signed-off-by: Oleksandr Nahnybida <oleksandrn@interfacemasters.com>
> ---
> app/test/test_pcapng.c | 10 +++++++++-
> lib/pcapng/rte_pcapng.c | 12 ++++++------
> 2 files changed, 15 insertions(+), 7 deletions(-)
Thanks, applied
prev parent reply other threads:[~2024-10-28 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 14:00 Oleksandr Nahnybida
2024-10-28 16:59 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMw=ZnScu-Hu=m-eqqyVOKnR8odg=H_AemSCCV3Z-O=6qhSNWQ@mail.gmail.com' \
--to=luca.boccassi@gmail.com \
--cc=oleksandrn@interfacemasters.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).