From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CD79464C7 for ; Mon, 31 Mar 2025 12:30:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7391940650; Mon, 31 Mar 2025 12:30:14 +0200 (CEST) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by mails.dpdk.org (Postfix) with ESMTP id 1CF8D40650 for ; Mon, 31 Mar 2025 12:30:13 +0200 (CEST) Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e53c9035003so3733726276.2 for ; Mon, 31 Mar 2025 03:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743417012; x=1744021812; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=q07wVs03jUHWFb8ifQjqY3IcAVoXkWuUwMqgCyH+QSw=; b=foNJ958r3wKYFPIClODbN8LigiWqDnylgBvtStMIfIxyzSbp4kj23HIDjAbSCW2F2w o8aQKwvd3Y2v4JuMJWFB1CUbzvc/Jg6KHutzWYT8I6NWzWja/Sc9a5/8KWZ5LdHI1qw8 zl1UkF++Z1zTqjKWq/2LVgOYNwFZJbmnGpMyYgOqhI078+5LRr170AhSYWrS3Q8t1zAb mW6hZxkkXV2O/eNC2/udQkbCyAEjenrSAqDY7KaS+9X2AfPeRJxM+jiy7ynwzk0KHb9g 4ShmTcJO0zSwRfIKgPlMHaq8E6Bek5MIvOrbBlzE83xKs7657qwdtRYu1aHU7pj8QbPr jahQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743417012; x=1744021812; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q07wVs03jUHWFb8ifQjqY3IcAVoXkWuUwMqgCyH+QSw=; b=k4jWizlClK2Z08JtFZKLa8nFLfWURbYbj0wgui2vg7aPpPBlYb3K/K1KQYdrwye7fj pEIGXQsNlqmURkn63k4eYm4CfWFWyg9TITmtNRaARPVpl7/f9y1MISoDE/WHweOA+6Zn YS6b4orzlNaKQORRSBvKR3spj+kOCSdHOXg41qGtJcgo3fI3yh1mT5QZP8thIaaPw9r5 bUBI2CT2yOub6V2pEL/2EqczgwALl2lhUNw3cKP0ydz17pH0z+yXb9ACN97S+kkeMNfp sd+bhOTAL67t2l7S5pACRnIRjnE5gdQ9o14+pbwJW8dKMJNQ7+29vHGOPr+uufm9kCwz 9EKA== X-Forwarded-Encrypted: i=1; AJvYcCWC+Nth68m+mvZsQE8fz0taeDMydkv+X1XDESDXaGDZoeJ+D+A6x1j1aII/3MWvO859M1SdW3Y=@dpdk.org X-Gm-Message-State: AOJu0YxwOpM+E4KZaND7CDbXUgbgYH9cv2LXn/baKP13R8z1G+mTDPQp wj6B+rQLN9yRT9dqfJmHufPAHPVeZQBOk9yXkb9HOLl4TDGg4t7b4NfENhkxWepCA7TNaP8jc5y 6SvHUS2dHHQ+iXAh09QwGQH371jc= X-Gm-Gg: ASbGncuC50SJvw6+Ky6GDxQR6e24VQTf53Cj7Kwn/3Y2reehwd69NKYN5L2ebQ/LfnQ Gd+XJlbAfYJ3NTgmIzgGTTHQtQUKE1r8BJ+3TqmijhNO0D3q01Vrf/kihSZsP1JBVC6AoQGFkk/ H/Z4J2hpHQRcuVnW9VsYCDaoy5XxdNFrF26KSKKQldhtQaQ2nYy7VQN7sDzwg= X-Google-Smtp-Source: AGHT+IEkb0l9wFFxinOGiyWTAcZhSLZohv//0CuYEeZzIqQyh9L0GqGY9F31GzCe0Ca62lSJ8RwBMZU3We15Pfedxc0= X-Received: by 2002:a05:6902:a86:b0:e5d:d6b8:2318 with SMTP id 3f1490d57ef6-e6b83ad64c9mr8961424276.34.1743417012442; Mon, 31 Mar 2025 03:30:12 -0700 (PDT) MIME-Version: 1.0 References: <20250217170456.1068278-79-luca.boccassi@gmail.com> <20250307122431.1415551-1-luca.boccassi@gmail.com> <20250307122431.1415551-9-luca.boccassi@gmail.com> In-Reply-To: From: Luca Boccassi Date: Mon, 31 Mar 2025 10:30:01 +0000 X-Gm-Features: AQ5f1Jrse61vYbJtgpKYpF8NXLpqIGV7Yx6jlZAq9Rt84Xmg6hhaZGp3DY32Mfw Message-ID: Subject: Re: patch 'examples/vhost_crypto: fix user callbacks' has been queued to stable release 22.11.8 To: "Jiang, YuX" Cc: Gowrishankar Muthukrishnan , Akhil Goyal , Maxime Coquelin , dpdk stable Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, 31 Mar 2025 at 08:31, Jiang, YuX wrote: > > Hi All, > > This patch will cause dpdk-vhost_crypto Segmentation fault (core dumped) when launch qemu. > Details refer to https://bugs.dpdk.org/show_bug.cgi?id=1685 > > Best regards, > Yu Jiang Thanks for the report, given it's a patch for an example program I'll revert it for now, it can be brought back for the next release if it is still needed and it can be fixed. > > -----Original Message----- > > From: luca.boccassi@gmail.com > > Sent: Friday, March 7, 2025 8:24 PM > > To: Gowrishankar Muthukrishnan > > Cc: Akhil Goyal ; Maxime Coquelin > > ; dpdk stable > > Subject: patch 'examples/vhost_crypto: fix user callbacks' has been queued to > > stable release 22.11.8 > > > > Hi, > > > > FYI, your patch has been queued to stable release 22.11.8 > > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > > It will be pushed if I get no objections before 03/09/25. So please shout if > > anyone has objections. > > > > Also note that after the patch there's a diff of the upstream commit vs the > > patch applied to the branch. This will indicate if there was any rebasing needed > > to apply to the stable branch. If there were code changes for rebasing > > (ie: not only metadata diffs), please double check that the rebase was correctly > > done. > > > > Queued patches are on a temporary branch at: > > https://github.com/bluca/dpdk-stable > > > > This queued commit can be viewed at: > > https://github.com/bluca/dpdk- > > stable/commit/6816d998b04e26ca4468356e0a3c10daf65412eb > > > > Thanks. > > > > Luca Boccassi > > > > --- > > From 6816d998b04e26ca4468356e0a3c10daf65412eb Mon Sep 17 > > 00:00:00 2001 > > From: Gowrishankar Muthukrishnan > > Date: Fri, 28 Feb 2025 19:17:11 +0530 > > Subject: [PATCH] examples/vhost_crypto: fix user callbacks > > > > [ upstream commit f7cf44d49b1115238a87c5852db4b47290bfdc25 ] > > > > In order to handle new vhost user connection, use new_connection and > > destroy_connection callbacks. > > > > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") > > > > Signed-off-by: Gowrishankar Muthukrishnan > > Acked-by: Akhil Goyal > > Reviewed-by: Maxime Coquelin > > --- > > examples/vhost_crypto/main.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c > > index 02987ebd76..b00daf74e7 100644 > > --- a/examples/vhost_crypto/main.c > > +++ b/examples/vhost_crypto/main.c > > @@ -362,8 +362,8 @@ destroy_device(int vid) } > > > > static const struct rte_vhost_device_ops virtio_crypto_device_ops = { > > - .new_device = new_device, > > - .destroy_device = destroy_device, > > + .new_connection = new_device, > > + .destroy_connection = destroy_device, > > }; > > > > static int > > -- > > 2.47.2 > > > > --- > > Diff of the applied patch vs upstream commit (please double-check if non- > > empty: > > --- > > --- - 2025-03-07 12:23:38.361858825 +0000 > > +++ 0009-examples-vhost_crypto-fix-user-callbacks.patch 2025-03-07 > > 12:23:37.998838059 +0000 > > @@ -1 +1 @@ > > -From f7cf44d49b1115238a87c5852db4b47290bfdc25 Mon Sep 17 > > 00:00:00 2001 > > +From 6816d998b04e26ca4468356e0a3c10daf65412eb Mon Sep 17 > > 00:00:00 2001 > > @@ -5,0 +6,2 @@ > > +[ upstream commit f7cf44d49b1115238a87c5852db4b47290bfdc25 ] > > + > > @@ -10 +11,0 @@ > > -Cc: stable@dpdk.org > > @@ -20 +21 @@ > > -index 558c09a60f..b1fe4120b9 100644 > > +index 02987ebd76..b00daf74e7 100644