Re: [PATCH 22.11] net/txgbe: fix to create FDIR filter for tunnel packet

[Luca Boccassi <luca.boccassi@gmail.com>]

On Tue, 15 Jul 2025 at 04:24, Jiawen Wu <jiawenwu@trustnetic.com> wrote:
>
> [ upstream commit a1851465f8252ee75a26d05b9b2d3dca7023e8f2 ]
>
> Fix to create FDIR rules for VXLAN/GRE/NVGRE/GENEVE packets, they will
> match the rules in the inner layers.
>
> Fixes: b973ee26747a ("net/txgbe: parse flow director filter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
>  doc/guides/nics/features/txgbe.ini |   2 +
>  drivers/net/txgbe/txgbe_ethdev.h   |   1 -
>  drivers/net/txgbe/txgbe_flow.c     | 585 +++++++++++++++++++++++------
>  3 files changed, 478 insertions(+), 110 deletions(-)

Hi,

Thanks for the patch, but this doesn't solve the problem, it still
fails to build:

../drivers/net/txgbe/txgbe_flow.c: In function ‘txgbe_parse_fdir_filter_tunnel’:
../drivers/net/txgbe/txgbe_flow.c:2599:60: error: request for member
‘a’ in something not a structure or union
 2599 |                                 if
(ipv6_mask->hdr.src_addr.a[j] == UINT8_MAX) {
      |                                                            ^
../drivers/net/txgbe/txgbe_flow.c:2601:67: error: request for member
‘a’ in something not a structure or union
 2601 |                                 } else if
(ipv6_mask->hdr.src_addr.a[j] != 0) {
      |                                                                   ^
../drivers/net/txgbe/txgbe_flow.c:2612:60: error: request for member
‘a’ in something not a structure or union
 2612 |                                 if
(ipv6_mask->hdr.dst_addr.a[j] == UINT8_MAX) {
      |                                                            ^
../drivers/net/txgbe/txgbe_flow.c:2614:67: error: request for member
‘a’ in something not a structure or union
 2614 |                                 } else if
(ipv6_mask->hdr.dst_addr.a[j] != 0) {


Could you please test that it compiles and works, and send a new
revision? Thanks