From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 901C946B7E for ; Tue, 15 Jul 2025 12:04:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65C724013F; Tue, 15 Jul 2025 12:04:27 +0200 (CEST) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by mails.dpdk.org (Postfix) with ESMTP id 425204013F for ; Tue, 15 Jul 2025 12:04:26 +0200 (CEST) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-70f94fe1e40so67827997b3.1 for ; Tue, 15 Jul 2025 03:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752573865; x=1753178665; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7KhVb4/bN8YGa7HgbL7kJdPHCoRzHKBMbzXMM8c8D10=; b=TyoTnZ6S8DqWEONDWW2ecmXjg8uvK0qXSOWtkkvueEsl9/M6KAtzehH8psuNw5QSd0 tGmCXXM0e0uNyLnzrERrw/tM8lwKVV+0nxOMWATE7kf0JpI19FxANS7Fjjt79CGej3Z6 DAtIZ1/ZqRb2dvvEi53AuFZrlWovgvovblWiFJsNhkHlMA5GQo4XNlGky3pDSjXshUWC RhV8y/E3jN2vJQr1yDJ9A4jQrOa2kRgFkZ8KffvKfdZ/oWXTQ4g+4RH/wYe5AfBj6e7a 8Iz7gN5ZaDPE9o9pPSK9ZXEUF8BXmKTpW0Pe/5xhm8V2SVHulswCgU/RcDhzINZwJqMX KznA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752573865; x=1753178665; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7KhVb4/bN8YGa7HgbL7kJdPHCoRzHKBMbzXMM8c8D10=; b=G51LseYFt25AKJO6UNdXYgNEKQz/ycGB29AE/x5X5o4CLlAXkFykOsQkYO0iAEm9/a gwDfhe2HBdaIqhQQqPGsMo5Jf/5KhHwHoPWpRm4ePOaDZ7v5z0Kboef6oy5RX+9EIpCo Dk8aaXqkT5eecLyFQSAsTqWLapSEgaflbDnOkp9ydb3m6Vxgpm82iVGFcMnF4qTaoCMq kucwn/FoizN7QC5wqnKDTLmQOT1zuvSqsaGcoucIs/jyOvYwouR9hJ4C7RaXY2tvLwt7 oBrgMOH8Tvb1mZnll7LxoibqfOV/LrVK9Y21W4TXwrucl8KwEWxNRNkNgvwUDWqCq9zt 9ANw== X-Gm-Message-State: AOJu0Yz9Fi5AAycEESrZnzDlIwIJLRn4omh9qOh6vtccW1xxf3GcaqrR R0z6nFn8IBYlIcuwUp+Pms2uc0weGPFaon8cfd3sSxjHtexEdnunL/eCSMrJTGM+oEiP6vJ/Ihc v3tjDW07yF2yqbSndZMBIoiWtrBlhZ4fmtRzQ2P4= X-Gm-Gg: ASbGncvalPo75vC4o5ZP4LeZwKqiClQH3TfNBE6PFPhgaBilQlpb0aWcKgKztpzHQwf rb+Eiteb68DUK7MZnic6YOP5HrEKMioghMc7hfKE1ktxJon1gssNhha3Cbos3xPr+eg8dm09sZW shy5+sjrnbr80Fw8MINw8r9dcXi+cyA+wOx/fvAkekxuip5SpdMutJdKUhSrAuEjVHwicw2HoEb TMUBjAv2pt55EHXkD/DvxsE/9o++BGLLckKt7LLwA== X-Google-Smtp-Source: AGHT+IGoheX5KQCUdmVpVIHdrEwlRfMibrO1+qSYFJQhg7LpELkEjOaTPI+3Zeo9iK0+a3l04L7Dweux9/pj91QyagA= X-Received: by 2002:a05:690c:6607:b0:70f:8830:809c with SMTP id 00721157ae682-71822c00b18mr42019417b3.12.1752573865300; Tue, 15 Jul 2025 03:04:25 -0700 (PDT) MIME-Version: 1.0 References: <20250715034849.1297724-1-jiawenwu@trustnetic.com> In-Reply-To: <20250715034849.1297724-1-jiawenwu@trustnetic.com> From: Luca Boccassi Date: Tue, 15 Jul 2025 11:04:12 +0100 X-Gm-Features: Ac12FXxzJsN243JnIMKAbKw-FGXv_JqRI-fkqVt7t48sIeeo_qg7z83i0a0Npps Message-ID: Subject: Re: [PATCH 22.11] net/txgbe: fix to create FDIR filter for tunnel packet To: Jiawen Wu Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 15 Jul 2025 at 04:24, Jiawen Wu wrote: > > [ upstream commit a1851465f8252ee75a26d05b9b2d3dca7023e8f2 ] > > Fix to create FDIR rules for VXLAN/GRE/NVGRE/GENEVE packets, they will > match the rules in the inner layers. > > Fixes: b973ee26747a ("net/txgbe: parse flow director filter") > Cc: stable@dpdk.org > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/txgbe.ini | 2 + > drivers/net/txgbe/txgbe_ethdev.h | 1 - > drivers/net/txgbe/txgbe_flow.c | 585 +++++++++++++++++++++++------ > 3 files changed, 478 insertions(+), 110 deletions(-) Hi, Thanks for the patch, but this doesn't solve the problem, it still fails to build: ../drivers/net/txgbe/txgbe_flow.c: In function =E2=80=98txgbe_parse_fdir_fi= lter_tunnel=E2=80=99: ../drivers/net/txgbe/txgbe_flow.c:2599:60: error: request for member =E2=80=98a=E2=80=99 in something not a structure or union 2599 | if (ipv6_mask->hdr.src_addr.a[j] =3D=3D UINT8_MAX) { | ^ ../drivers/net/txgbe/txgbe_flow.c:2601:67: error: request for member =E2=80=98a=E2=80=99 in something not a structure or union 2601 | } else if (ipv6_mask->hdr.src_addr.a[j] !=3D 0) { | ^ ../drivers/net/txgbe/txgbe_flow.c:2612:60: error: request for member =E2=80=98a=E2=80=99 in something not a structure or union 2612 | if (ipv6_mask->hdr.dst_addr.a[j] =3D=3D UINT8_MAX) { | ^ ../drivers/net/txgbe/txgbe_flow.c:2614:67: error: request for member =E2=80=98a=E2=80=99 in something not a structure or union 2614 | } else if (ipv6_mask->hdr.dst_addr.a[j] !=3D 0) { Could you please test that it compiles and works, and send a new revision? Thanks