From: Luca Boccassi <bluca@debian.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: stable@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com
Subject: Re: [PATCH 20.11] net/nfp: fix Tx descriptor free logic of NFD3
Date: Thu, 15 Jun 2023 09:42:52 +0100 [thread overview]
Message-ID: <CAMw=ZnSuPqD0h_3zXfTxd8v5RLMznW6QfS5-LxGVb3QpmNh5ow@mail.gmail.com> (raw)
In-Reply-To: <20230615062134.1266145-1-chaoyong.he@corigine.com>
On Thu, 15 Jun 2023 at 07:22, Chaoyong He <chaoyong.he@corigine.com> wrote:
>
> [ upstream commit 36d0f4238b2f79850695f49b191ddd4540ff88a6 ]
>
> In the Tx descriptor free logic of nfd3, the former logic might force
> cast a negative number into a very big unsigned number, and which will
> cause potential problem in the xmit loop.
>
> The xmit loop will continue in the place where it should break, and will
> overwrite the Tx descriptor which is not free to use by the PMD.
>
> Fixes: 74a640dac864 ("net/nfp: avoid modulo operations for handling ring wrapping")
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> drivers/net/nfp/nfp_net.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Thanks, applied
prev parent reply other threads:[~2023-06-15 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 6:21 Chaoyong He
2023-06-15 8:42 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMw=ZnSuPqD0h_3zXfTxd8v5RLMznW6QfS5-LxGVb3QpmNh5ow@mail.gmail.com' \
--to=bluca@debian.org \
--cc=chaoyong.he@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).