Re: [dpdk-stable] patch 'net/bnxt: check for null completion ring doorbell' has been queued to LTS release 18.11.3

[Somnath Kotur <somnath.kotur@broadcom.com>]

On Mon, Jun 24, 2019 at 8:56 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> Hi,
>
> FYI, your patch has been queued to LTS release 18.11.3
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 06/27/19. So please
> shout if anyone has objections.
>
> Also note that after the patch there's a diff of the upstream commit vs the
> patch applied to the branch. This will indicate if there was any rebasing
> needed to apply to the stable branch. If there were code changes for rebasing
> (ie: not only metadata diffs), please double check that the rebase was
> correctly done.
>
> Queued patches are on a temporary branch at:
> https://github.com/kevintraynor/dpdk-stable-queue
>
> This queued commit can be viewed at:
> https://github.com/kevintraynor/dpdk-stable-queue/commit/0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245
>
> Thanks.
>
> Kevin Traynor
>

Thanks Kevin! ACK-ed the rebase

Regards
Som
> ---
> From 0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245 Mon Sep 17 00:00:00 2001
> From: Somnath Kotur <somnath.kotur@broadcom.com>
> Date: Sat, 8 Jun 2019 23:22:04 +0400
> Subject: [PATCH] net/bnxt: check for null completion ring doorbell
>
> [ upstream commit 2807c5861e31b99295b915b28e121ce059a46416 ]
>
> It is observed that sometimes during init, the bnxt_int_handler() gets
> invoked while the cpr->cp_db.doorbell is not yet initialized. Check for
> the same and return.
>
> Fixes: f7ecea911ec5 ("net/bnxt: fix interrupt handler")
>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c
> index e03766b41..e3aac7cbe 100644
> --- a/drivers/net/bnxt/bnxt_irq.c
> +++ b/drivers/net/bnxt/bnxt_irq.c
> @@ -32,5 +32,5 @@ static void bnxt_int_handler(void *param)
>         raw_cons = cpr->cp_raw_cons;
>         while (1) {
> -               if (!cpr || !cpr->cp_ring_struct)
> +               if (!cpr || !cpr->cp_ring_struct || !cpr->cp_doorbell)
>                         return;
>
> --
> 2.20.1
>
> ---
>   Diff of the applied patch vs upstream commit (please double-check if non-empty:
> ---
> --- -   2019-06-24 16:18:56.998750420 +0100
> +++ 0037-net-bnxt-check-for-null-completion-ring-doorbell.patch 2019-06-24 16:18:55.067430374 +0100
> @@ -1 +1 @@
> -From 2807c5861e31b99295b915b28e121ce059a46416 Mon Sep 17 00:00:00 2001
> +From 0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245 Mon Sep 17 00:00:00 2001
> @@ -5,0 +6,2 @@
> +[ upstream commit 2807c5861e31b99295b915b28e121ce059a46416 ]
> +
> @@ -11 +12,0 @@
> -Cc: stable@dpdk.org
> @@ -21 +22 @@
> -index 918f3dcf4..0bb3eb4fa 100644
> +index e03766b41..e3aac7cbe 100644
> @@ -28 +29 @@
> -+              if (!cpr || !cpr->cp_ring_struct || !cpr->cp_db.doorbell)
> ++              if (!cpr || !cpr->cp_ring_struct || !cpr->cp_doorbell)