From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150053.outbound.protection.outlook.com [40.107.15.53]) by dpdk.org (Postfix) with ESMTP id 2CF272B93 for ; Mon, 4 Mar 2019 20:57:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OyArK5WLB8IlVbUAU0WoEYi/lOLrBbptlzCvdqmvU10=; b=AaBjvoQoSr1BArNOXe4i3DIMQVog9eYuILmP2R5Od4YhPaeWvbvrl6xl6QiKMKXorT3GMxaQYU/4Yl76CH3WracUzh2dMpPwW5S4n7m5Tns5gJOapIv6vARAjrmunJQujNKhhBwfEGyWx2n+VQqLm23A6Cy+wf3royAi7A8IT1c= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3962.eurprd05.prod.outlook.com (52.134.67.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.19; Mon, 4 Mar 2019 19:57:16 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50%3]) with mapi id 15.20.1665.020; Mon, 4 Mar 2019 19:57:16 +0000 From: Yongseok Koh To: Reshma Pattan CC: "stable@dpdk.org" Thread-Topic: [dpdk-stable] [ PATCH 17.11 1/2] ethdev: clear ethdev data upon detach Thread-Index: AQHU0CVl14k0rQ6SDEa+mwc0GfhZ8qX76KKA Date: Mon, 4 Mar 2019 19:57:16 +0000 Message-ID: References: <20190301115323.32420-1-reshma.pattan@intel.com> In-Reply-To: <20190301115323.32420-1-reshma.pattan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cd3de918-87ad-4178-da10-08d6a0db99fe x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3962; x-ms-traffictypediagnostic: DB3PR0502MB3962: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; DB3PR0502MB3962; 23:WSWQLp8m63tKxJLwMGiFXHQ7uMq/2cysq6/7eeS?= =?us-ascii?Q?B019TCpwDV0yGEnHkwGod12uwtYCw6XTU0kDHXJElbV347Loe0ou48E9Fjm1?= =?us-ascii?Q?1dvVt1PDRip4jG7urGfd9HWjwNhhN/jY/SvwJzjY58NmvFPu0j1TU9aOETaP?= =?us-ascii?Q?tpkQE3WJFSRry3Pj/8ISmvYAnE7NvPd2QJmzIaISgjqDLHcRO4CJenC5ALtw?= =?us-ascii?Q?yXnVa3hzO6XHtLcX+rMhXu45+LDduEf/P/htMq1En2+Qwo3zupik9byBnMwz?= =?us-ascii?Q?/XsVViBKr709qSP70qJPp7O1quk7z5yEsVYvQnzlu5eAi+6VJcO88FN6zjkw?= =?us-ascii?Q?xM5VPecUVX8pBsLT56vgSQEH2b88FmP+8uTw6OUO5QqG9wByBN82Wm65cUAd?= =?us-ascii?Q?yBBdJjoPAWTV3hNdMmryywPBufhk4ZTMHpx1/AK3Nbta78xF91JeEGiowARH?= =?us-ascii?Q?Ibv8V+OD40pt+3OgItdG7GNxo+6AVJZoBotOmfdRrlWTrWFYyw9f7SF9HMhA?= =?us-ascii?Q?q71x3qF0xZ7bzdjiOESDrr5E9DmMfUpIrn5fijqsjs1k5PzoBVT5coVRZToE?= =?us-ascii?Q?ec19LV45cV8tVYOsafBjMpFm5lT8u1Op8DNGBOeveZZGqlPm27hBre7aV14m?= =?us-ascii?Q?wmPR8zdC5/LV3n0YTwe9Bkk4Ap8FQzimr3Iq4ZvEReVTPOAJyOFh4yLKmh2p?= =?us-ascii?Q?w36/VF+1Vdd7QZS1CajB67nwxwTMppbS0pN6tJsC4+CETZ2LNFx6rnULMZtQ?= =?us-ascii?Q?3aK4B/O9t8lcOh4yu1VkJcmW+EiyXNFll7RSzdaQqwVEaaFqxYn0idQS8ahM?= =?us-ascii?Q?zx+u9XxCMd9gnTpj87AL+SX6JPySXyi8IKJnIcX+7F4mE0FOmr5w/xyVW2Ha?= =?us-ascii?Q?gKWkUCCHhPk4h09bC0iYJYkA+3Jjp56hOCT6KVr2yde1LMyYKmCoorLC7wHm?= =?us-ascii?Q?Tly1VwotVoTNDGglH1+7jsCm5zROBU5f3BaqIGS97vpuzTA28moDsv11LA95?= =?us-ascii?Q?/Ac7nEmi/GY+cN6EznObsuqYJIpXZ+gKTm8yiEDJ+GGLTh8P091rL4qnF2Y0?= =?us-ascii?Q?k/PFNB5r5aDr/pXwpb67IJA7KgBdm9/q65hG/wvWUoAZe9TQCxn5pudQzFyC?= =?us-ascii?Q?yV01dGMc+/oj2MxSO8zCb74FYu7zq+KEyRYB5nZPYm2fG8213iCDs12k6YI+?= =?us-ascii?Q?vmkTBkfV9uigc5eNIukTfVxPMIQn4m89lvWHOfKefwRDhzIBA1RdtBk0K7w?= =?us-ascii?Q?=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09669DB681 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(136003)(376002)(366004)(39860400002)(189003)(199004)(86362001)(6916009)(8936002)(186003)(106356001)(71190400001)(26005)(6436002)(68736007)(71200400001)(83716004)(6486002)(486006)(97736004)(5660300002)(81156014)(305945005)(81166006)(2906002)(2616005)(256004)(5024004)(11346002)(476003)(446003)(7736002)(316002)(14454004)(82746002)(6512007)(229853002)(478600001)(36756003)(66066001)(99286004)(53936002)(25786009)(6246003)(76176011)(102836004)(105586002)(53546011)(33656002)(6506007)(3846002)(6116002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3962; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: rZuWoWAePnm6YB0aBmboYwQYe6OBkq1+3BOSSULAikE2uHHsMXsGe5BuHpi4G94ZEALrF1PH1BlWSrHoFRLqLLbMZ6VVIiOCoJWRDZkjc46uJ6X2M/0/KKWxvqJjai3agEQRhDDofPkEUxdMNvoTuKsqxDx3Mke8WaimMHUfatHPALoLH+Wc3MAhQOD9TRPcemlqCqFzPuj2l1Ipo1lV8OnU4Mf9e+ElEiBmV2dbDJDYMQVXST2S2J58zyYpRqVnWp4GgmSWqtj338zpGNiWH6QnnYUf1XcEFlnsBHs2ruvLcy3APCEWftODqK1AQYnh398qzzxKBpnl2LqCleRmP++SSKZO5WtpS2wWZ8xOJY/Opw+cdd3BIFhdjq0WQ7SpTy3FfdYbzogUf/Wgh8TBWpVQ65T/cKeBNHCfx6lKKrA= Content-Type: text/plain; charset="us-ascii" Content-ID: <877C1087B2A34D4B8535FE0DEBEE8310@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd3de918-87ad-4178-da10-08d6a0db99fe X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2019 19:57:16.0451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3962 Subject: Re: [dpdk-stable] [ PATCH 17.11 1/2] ethdev: clear ethdev data upon detach X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 19:57:18 -0000 > On Mar 1, 2019, at 3:53 AM, Reshma Pattan wrote= : >=20 > When port is detached its relevant rte_eth_dev_data[port_id] > has to be zeroed, otherwise the next port creations > could get wrong port_id. >=20 > Fixes: 92d94d3744 ("ethdev: attach or detach port") > Signed-off-by: Reshma Pattan > --- > lib/librte_ether/rte_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c > index 096b35faf..7ba9bc564 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -443,6 +443,7 @@ rte_eth_dev_detach(uint16_t port_id, char *name) > goto err; >=20 > rte_eth_devices[port_id].state =3D RTE_ETH_DEV_UNUSED; > + memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data)); Hi, I believe such code is good to have. Before I merge it, I have a question. I wonder what the problem of the current code is. If the state turns into RTE_ETH_DEV_UNUSED, then will the eth_dev be re-initialized next time anyway? Thanks, Yongseok > return 0; >=20 > err: > --=20 > 2.17.1 >=20