From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEC77A0C41 for ; Tue, 19 Oct 2021 22:57:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E736B4111A; Tue, 19 Oct 2021 22:57:33 +0200 (CEST) Received: from AZHDRRW-EX02.NVIDIA.COM (azhdrrw-ex02.nvidia.com [20.64.145.131]) by mails.dpdk.org (Postfix) with ESMTP id 1E4EB4111A; Tue, 19 Oct 2021 22:57:33 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by mxs.oss.nvidia.com (10.13.234.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Tue, 19 Oct 2021 13:57:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QczvE742N4fmDM3lcDouqNRjHlb10OsThitwQw3AqXwcUSdjL02MahWzdjB19Vo+KS4rBpQs439YKUEJ3UNFYA1OdoDQB9qUUpI/9u2CnU43dp9PEqzR6D0z1qKoz9FsNyFBtt/gPEQ7jT0TxJypHOuA4j86DMS551eDt++I0+Hl6SBQEMJ8DK4MHaJAqoo2PR9elhRijcYU+8hl8jqNo559mgy0PakH4pcSYKwicBlR67CKuWTeNqoBQWaDoYnTZIQiwYGuQczoceKKRhV2cIIdSnbNBRbbd5qtMAY0H53eFVsktwfirRnwm+vwZ+FMeXCsTGJlXVi8qWjS2P2U4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCprQ+d5UYBBfDPONBWg/ut5a5t3q7jqMYmivUMH4cQ=; b=CP/CnnLYdqtcXz7Kxo4PAw9Ay0SqsMQgQW6ihMcT0xm/MzvA7QWWTmAYVQoD7LWBmZ/7QDfNNBB+7FNsJ5jY4NFxwYsuEIA3eFyMCV+vFSy67xtXntqNxn3wDlZ5xeL+o9tLyXuhvMRNyjY81aqOt5OIitjftdAA7IWMHwGDLjW43yphM7zc/tXd76ZwKwj4BZFPGljo+loECngRcZ0lYFpKPGndOggdGndweVmfXkEYsaoElggp0YNMC8Q+NSIQ2V+Afv+szOT76WfNe8yZRpwkhUWEkkaeNCbthjxefHckbikuEF+ScsRNpPDNR73k9/dGDvEwOCJonX1ASlJHEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tCprQ+d5UYBBfDPONBWg/ut5a5t3q7jqMYmivUMH4cQ=; b=PGd5/9cNhZhsRbBArbaBqT2uVfsRlBu1mI8VVC+v46TnHWluBOcKjHDQ+54257swU8ElhacCZsdTGZhWHQY01RA/srzfXVta3xYUKbqp1FXhQt24BHDGenETcZEPYQqyTRzfWAHb7oim36aBb77L6xjZlbvYHbwhIsPXpz7wqyqxlmVlqYvqw60CfN0c71QFURkjW6A9REhj1lsMG8NKW856Vra2tyCmhQ9H++Q8Rwli4okqrWbZpB37lYdJzMQa2NuJJQ4NR5YUVUkqV8KrOrl0PjbqnfxvZnvG48uMMkGDOVxVC4/BwUYPyYJS6ONsSOryHKxYwOo7D9KrPN9dBw== Received: from CH0PR12MB5091.namprd12.prod.outlook.com (2603:10b6:610:be::10) by CH0PR12MB5202.namprd12.prod.outlook.com (2603:10b6:610:b9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 20:57:30 +0000 Received: from CH0PR12MB5091.namprd12.prod.outlook.com ([fe80::59bf:640f:7140:ab97]) by CH0PR12MB5091.namprd12.prod.outlook.com ([fe80::59bf:640f:7140:ab97%9]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 20:57:30 +0000 From: Dmitry Kozlyuk To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Matan Azrad , "Slava Ovsiienko" , "Xueming(Steven) Li" , Jack Min Thread-Topic: [PATCH] net/mlx5: do not close stdin on error Thread-Index: AQHXwO/mpuZa93LDy0eOa8A70Wxecava1A6g Date: Tue, 19 Oct 2021 20:57:30 +0000 Message-ID: References: <20211014113718.12487-1-david.marchand@redhat.com> In-Reply-To: <20211014113718.12487-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c782eb3b-75be-40d8-bc35-08d993431109 x-ms-traffictypediagnostic: CH0PR12MB5202: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B0T96cOvyetyEw1AkmAXmsVp8X1fsKHAcyWwzlBkRmF/4WHRP3udbNoKULersui/7eO8NdjIsL2TtAKUzUBDWK/pHUvUa9IpyYhhobp0PtFO4eLfvkRTjoVt5cyc3qUe0kuCyjIDVoS1ijIKhzOS+WgC0yw8bRK+Lg/UrrAXDTO8Vr5ADOW7liPL5xf/BoZzARV5qf6n5bt9fjeZHspbAe9TGDF+aWqY7hjmu7j0EGxwyljMQcz0R19/SD4kBvL4U/3PFedzbkxMMLaKbWmojNJ3l6uZrVdwJhCebCCcUnOrG2cYP1V6Vc4cD4pSgMGF3YNCqtqL3bNvHL1OLt96/g7ctdvB5O8EJjlM9iFzevCVKjdmirh4oJOoNiyHgBzmE0DlXnLIlzD5TNuTj2PnwG0HZ5fZQ457e7rzfLK+kVws+1H/tdcB9ulB+0zp8hCjwlFOA1yu6uipMG5Ccr6ej+W42ogpCXzYGtHsmQw+9rylzcDxrw1Aq29xdIwoD8wctczzH62LP1otbFEMt3nBBD/7nqaCJhwVQhFSekfSiGfCqAtJbrQBfDgsa8Guo1HRUKUH2STL/+0SC+1CUD5G/dcN0q/Q3/1RFG8GGyyOh4XIo/YCwPeWhCkQsImCJdwuOAyb1LrBgDpDAbWMJ0ARyRsBCOW99Nf1oad+ZNjiow+gMEAv8z9i8Q/REupW+LUsGWsFZABjiyV9GjFTjs9Jww== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR12MB5091.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(186003)(55016002)(508600001)(122000001)(7696005)(9686003)(66556008)(8936002)(54906003)(66476007)(52536014)(6506007)(4326008)(5660300002)(26005)(76116006)(83380400001)(33656002)(450100002)(71200400001)(316002)(110136005)(38100700002)(66446008)(53546011)(86362001)(107886003)(64756008)(38070700005)(8676002)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?koi8-r?Q?V+O6SODLpywFqFej0+4J7u48i/kHG81bhegzdb3uK83P9xZsCgz6UiZZPMkEaE?= =?koi8-r?Q?hUrxVJZ1jhuoDyHCYf0iiYM/PRTOIf88cJsygMEDEm+5rFuI7DHdmVIpsu1hEL?= =?koi8-r?Q?0iYg0lq1xzTt85DpTTtDjxoMlT0ZEou1RN53DXp/W3krNL4Nv+g1SfsFyWxs2M?= =?koi8-r?Q?oV4dfdGyHeSPDEPx3xPKIaXRAxPpi6fWAk2848/AcFpw6AWbXcekanh5AHjLi8?= =?koi8-r?Q?ci355iXwptxjIOWd5xa6hrE9iAo65ISHhyyhDjthhHrTr0YY63JFCEaZnuxHWe?= =?koi8-r?Q?S9k7OzaAvTPyaSVeqqGFyvhgj1rwaL6UTu1gmixjDsPT7+5J975L7m30uwg6Kl?= =?koi8-r?Q?icuB8Tn6BS4yaajv9rbxkLBkMu0xOW0eKdcxAq+T2lA2K7zHe1EV0EI3ptscRn?= =?koi8-r?Q?kuUHCotV4FQMjo0pl6IqWWcUKbK88loRvSGwfJ3MbJvj9JzVyV/yVNbSWRpPmd?= =?koi8-r?Q?zVKyddIIWeIBkQsjHcZGNDCizvuZDa26xB95W1RIgDsNRVkQPnuGpR0mEmce2y?= =?koi8-r?Q?SGbseuDdk/cRndla0k29r4W91StZmC96hXOJCM46bIEyGq7MuROYUkl0D4XB76?= =?koi8-r?Q?z+9y+O57GmIZprYEWDbZwn3eQ+Tx2z8PgzLp4zZ7MgBr3E7t0g49AECQmSJSga?= =?koi8-r?Q?b05GcHPfgUtHmfFkdl/UMxCxBKxq1LLXdfjwLMY197lzgO1ZLjZo/AkSHDaqLG?= =?koi8-r?Q?TYt7mJR6ykZjsHl5boGdaGi5k0uTscKEydY67VVmjEnF/XL8fch4nY0LgahIFf?= =?koi8-r?Q?UfIEHfNVypfzCI350igGbsZffc42fdQWVH5qcPXGuW8MrgBjnimAK+SlKwTdSR?= =?koi8-r?Q?NPu2FkmN33e9L9E/ItTWkPOsh5Rl4dMVOgQHXuQ1RVlXiDWaeP1S8xQvCs8/nB?= =?koi8-r?Q?LNJEn9U+hkoPhJeis2yeYhoLR8IWS1ZRw97Bv3NO8JCuApJQr/JTljm3RdoV1E?= =?koi8-r?Q?swWklvlcyY+hBSfwqFSgZfbEJuh+RY4XC8UR/V+WXC3reIf5KoCJqSjCInC6eq?= =?koi8-r?Q?KmF5LNQFRenxdMP4n8lb33xdNVAG5Hipl24NM8frvfhtRio7wtKbENVAILNZ+Q?= =?koi8-r?Q?f52g3Fq23rAlyWXf8xKQlLUGP9NUTYKuo5200gJHgFuwsU0ff4XQfKgJsRd/Eb?= =?koi8-r?Q?aktdkF552zuepbmFPjeeX3U0b/MIwA0cbm6hz/XihyvH8HRycQkmyduAZzk7b6?= =?koi8-r?Q?6z19z7s8cjuvElIjGLY6TJ589jDqhWvvCnjECJ/tLL3dLxiqKOvr2tS49SEP+i?= =?koi8-r?Q?nd6Ki2flxv7MS6kRnnCck=3D?= Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5091.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c782eb3b-75be-40d8-bc35-08d993431109 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 20:57:30.6821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dkozlyuk@nvidia.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5202 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: do not close stdin on error X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: David Marchand > Sent: 14 =CF=CB=D4=D1=C2=D2=D1 2021 =C7. 14:37 > To: dev@dpdk.org > Cc: Dmitry Kozlyuk ; stable@dpdk.org; Matan Azrad > ; Slava Ovsiienko ; > Xueming(Steven) Li ; Jack Min > Subject: [PATCH] net/mlx5: do not close stdin on error >=20 > External email: Use caution opening links or attachments >=20 >=20 > If for any reason, a socket could not be opened, mlx5_pmd_socket_init() > could close the 0 fd (which is valid, and has a fair chance to be stdin), > since server_socket =3D=3D 0 from the variable being in .bss. >=20 > Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand Thanks for taking care of this. Reviewed-by: Dmitry Kozlyuk > --- Depends-on: patch-101572 ("net/mlx5: close tools socket with the last devic= e") [...] > if (mlx5_pmd_interrupt_handler_install()) { > DRV_LOG(WARNING, "cannot register interrupt handler for > mlx5 socket: %s", > strerror(errno)); Another bug, `errno` doesn't hold the error code here. I'll fix it in the follow-up. > - goto close; > + goto remove; > } > return 0; > -close: > +remove: > remove(sun.sun_path); > -error: > +close: > claim_zero(close(server_socket)); > - server_socket =3D 0; > + server_socket =3D -1; > +error: > DRV_LOG(ERR, "Cannot initialize socket: %s", strerror(errno)); > return -errno; > }