From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5E7943C4B for ; Tue, 5 Mar 2024 12:18:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF5CF40270; Tue, 5 Mar 2024 12:18:01 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2081.outbound.protection.outlook.com [40.107.243.81]) by mails.dpdk.org (Postfix) with ESMTP id 4C8DF4026B for ; Tue, 5 Mar 2024 12:18:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IkMFH+t22DeDr74vUCe4ZiFR73fIlt2zjgNtftM/Zck7L+ekGzdlfyPvMetfGhplWcRpnbDGpRbgHGqANBUx56niIqWlNQtaZh9MDt6PsUCaIzRSfF4HTBvNiSrpznHPHSCzR3NMR77ZUp2wxw+F3lj/chNkWN35L6PDWP6qV/nOZiZA/EMgsd7CdeMeaz8SqlYLLFlENNxX30T6+M5Z5rGDF0KC2zPZY+uLNVl//ZaaGfshZoXoRtxkuNPPG8A/DfU9oE9Pz6bruP/MVuW42LLAWaceWUwJmbkfE11ft+QY8VQIwgRmaVtP8DLCOrFJIlIAiGi7XMwcUwMwHO3elw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WhIB4PgE8tE5R0ILO/ntY1hVUV9JT5nfzDLRkcFkIeI=; b=OKfxQ3ryXLFSHO/Dd0DJBRzX6FV1JFeZM+EI56iiDtOMNor+C6Bspu2QG9urRNZH89olxSuL2dr91BC+i6PuH9e/pdiqGYdqEmmK/tYRfL3LlZ0D6qLa6MrtLNyZfIhudsTjlEMrb9TaZDEVwkMPG4I4KnzMEPvJXLvB6Zx3K05/obzi9nepfTqDqqYSKFFAQ59Dn9CnjAyv7eYCsCMqGPIB1qLffxckASS4p7ixUZ9kBp0xsSSHmarQdCTqVORMRVcUeG9yn1khhEm2oWaSEtBOp+B6/rQ5Dx5OeTD+iHPAqeYsVc+eKcTwR6k8IlNqOLo7n1WVJqbQU1+CRddmiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WhIB4PgE8tE5R0ILO/ntY1hVUV9JT5nfzDLRkcFkIeI=; b=CjEFxT/pJV32ldqRbqYLIEIjT07BWhmqaVGo1l4U/cyk/xOQpRctGLN4hhQVX8XNZ/+yrfqJXRcDrV4LodgyadzbeezjmgK1uNzRgtWHYP/62iFyq69dpOEiPQR/VHdMSRp6H0Oo/1GiYk6Y1626nWFdLZlUwQ/G+fgovxEX/Yg= Received: from CH3PR12MB8233.namprd12.prod.outlook.com (2603:10b6:610:129::15) by DM4PR12MB6087.namprd12.prod.outlook.com (2603:10b6:8:b1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 11:17:58 +0000 Received: from CH3PR12MB8233.namprd12.prod.outlook.com ([fe80::56c9:d5f3:2cb3:d9f2]) by CH3PR12MB8233.namprd12.prod.outlook.com ([fe80::56c9:d5f3:2cb3:d9f2%4]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 11:17:57 +0000 From: "Tummala, Sivaprasad" To: Xueming Li CC: "Yigit, Ferruh" , dpdk stable Subject: RE: patch 'eal/x86: add AMD vendor check for TSC calibration' has been queued to stable release 23.11.1 Thread-Topic: patch 'eal/x86: add AMD vendor check for TSC calibration' has been queued to stable release 23.11.1 Thread-Index: AQHabuKQz71JQGglREe8Mz7tvXO1qrEo/6gA Date: Tue, 5 Mar 2024 11:17:57 +0000 Message-ID: References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240305094757.439387-25-xuemingl@nvidia.com> In-Reply-To: <20240305094757.439387-25-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=423d4296-2238-4508-8f4b-71a2394b9b7b; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-03-05T11:17:31Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8233:EE_|DM4PR12MB6087:EE_ x-ms-office365-filtering-correlation-id: 84b5f495-a737-419b-75bb-08dc3d05e95b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xXiSVsYJ5MDzIsU1W6gzPsJp9LFfeYIHlOxcdHzWG8OW6aj8p3UdIbpb3hczk+DJ0s32IkIHfcUHKqvbKUAByLWmcQ39oaO//gZjqIO5joFAWLRHLFqkKDEXJRuE6WmjGmpPuxtwTOH0LU8SXl4zKxGMP/OCiB0ezsXxr71QymgTZsM4OY+hjfeRzAIL2dXJJeJjbl/wepQaaTKWDfpRyAfNwLmVmiGe/eN/W8cP2P5AaKknqqzdX7wntf8TTAzvc7BL2aBxcJMQCsF3KJWCtuwIXHvyaWzWufOrt0cFnas3NEZX8lQtnF6vUxGQYOKSiw2Z7Q+kWZ6fttHFTClKwx7wk6hYrkrzcZ6u+n0RBBCDoMbXl4tYPomc6vRuW4pDfu5MMxVU0M1yr8RZt4B7539MEhPqvFhubTU99yLBFPkswnn/TjCiyplrwTbPkrDUaBNh7Z1L9AjmR99NSd6mLbNKZBE+o7BRTJDC2kXpJRIvzjiYxP1RryxssUzTE5avRUS7gxAKNOAQRYJ1BUDQspJnCaQqWbxTg5AUVYF6HPIum5nI0oN0q44llHnhbfwCuNIhVQkBNlOjDz4KheLu6mZIR3v4Rn2bwrTa/91EYlHHkevZkGElzEfgWAOSlkhQPrsb2xxtKRQGD480/5UOULFmFAlUlxiBzcG6/vOmDMw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8233.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FSkQV5XQi1uy+ug12jj4Od91LnOW1Fxuw7FGvs4Yjsk4eRBMkMbhpkD3+CMD?= =?us-ascii?Q?oeYSumL1+iY8ShxMKi8vatfwRHmnzo4nYJ2Gnok6dWY7YdyqUogmeUIgmrbv?= =?us-ascii?Q?8vXFIWYugnyhgRwRv31ClQGM99XTugfK8BwiTug+HH3KtjQgCNBLTXR/sM6j?= =?us-ascii?Q?n43Y3t+pdCcFvg7WtFwGeCaTUcth4fSD0+Ffw58O4FsJZnYKK3s78U7ENB2q?= =?us-ascii?Q?VTCUoKo2ER5PM3Fa8EhvHLc37uSHcSsyt2BCsb6aZ3OLPiT7kQXGX2Ds+E5F?= =?us-ascii?Q?E0iufT+yksKjMbCe/yUkimP5Hf0Scmnr+RUWtLB5/QMORTB5Tawzrmf4MU14?= =?us-ascii?Q?F94VfM7L0D0A2l8Y92+XW2LoZN2Mq47/MWtf4hoADJ7otCgJB4Jlq4yQhyhT?= =?us-ascii?Q?off+EVDAYztwqle8Y6CVpuWQrRMVxAXohgTHlZKu8Yw48xisQaZAGQJITBy9?= =?us-ascii?Q?fpcZwooK4/LhjOc98yk1MGLsBNTFsEEwNF7xeIt+iMOwMO5LNgto5Jscfwop?= =?us-ascii?Q?GY1p+RnANfd23hIg06b1qKwUlR0/Nu8yLoGfJj2CeuR52UsX3F2M8GVl8p7r?= =?us-ascii?Q?nxiFvc9Wz+FosSUuTuWXtxAAwZvqduywEMl1PhgMqSE/wE+m2lgxZKpwTbJl?= =?us-ascii?Q?ynonFeANWqNHRem73PdchHp8ZYw0lh+kTG8PL4XeI+wAuUBJaGN4db9NEbG5?= =?us-ascii?Q?kMzVcQOW+s6aCDtNM31KxrZ2QGtoBwag4kR/0Wt1LeCXa5zRUCcy77/A3o12?= =?us-ascii?Q?jwoKlJb6MzPnZuHZ9ebyZvCW609wCbKlivdFYOneeRFel55qqbnPLNyd7yot?= =?us-ascii?Q?ixwG2KrXDEFvF/3Hwl05MzqhDDG+uvkwK96kZcPdoWDYAIHaBh5fiUwsoUYn?= =?us-ascii?Q?BkXPze/wYnrq8xaBxGFZUHmVGUXw6e/4dP6ZL/jtGTupM8CD0vye/X8fNKwf?= =?us-ascii?Q?hUkVtFNBqq6ssgke0MU3K6dI4gLbw4IHX7JAoaKEAkPitTxqJ7pSSZeHtoMj?= =?us-ascii?Q?gT+U/BDCsu6NAticm8rSPI/bTyvedRVp0TI/oYzdeNFPvpCjEEs/PX9cPR2D?= =?us-ascii?Q?6iSYHfRTFr3k6i50M6g6aNYq1V+tytcIHErDN3PbIwMO9RFYpO0koXInn6/w?= =?us-ascii?Q?k2u2Qeyp5zMq43YaB6fK3Zqzat1OZsnSOsZJF7ZwRbumzX7JPRSw4vdlje2j?= =?us-ascii?Q?CoJeWO1z7QkAfH2LEpSeYQuyOWymPjarf0x3JXL5NJtFpYZEP+pMJ7b+SETP?= =?us-ascii?Q?BTgVIdAZo9qAMj7BZZYHS1SOJYM6RtbVPedzqTyHS6XOfBhuC3uKh+E+ci7E?= =?us-ascii?Q?9c3StB/IDYR5CHrdQlldemdKDpYt/YeUOKab4jXZYSUQ1oRmJiK9StSwJYDa?= =?us-ascii?Q?1cppjNSe6KL2U1P8OVhQ75wrzKKX+yT5INaY2rvbMvMF9EaPvt6hUbU+qLMd?= =?us-ascii?Q?CThCJZXbmQUeXdVOqYoZbsjjQeoSeKh0/YCqt2t76iYSR+RtXCStQwcKvwf6?= =?us-ascii?Q?BRB0DDbdoDmrn3tuTbDpVlHg2IYmOioQkDitiSNHGqihLczQHkx18NPeHdhA?= =?us-ascii?Q?Pd4xLq4WkvH0N/puhRU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8233.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84b5f495-a737-419b-75bb-08dc3d05e95b X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2024 11:17:57.8356 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rYv2/uqagJvZ6PD1E5vsuZ2hwpHbghMT+qTaX55WVWsqq3NhiQofo+gg3XfrCkuZRgN4VCgvQ1OfmFha9DCrJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6087 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [AMD Official Use Only - General] Hi Xueming, LGTM! > -----Original Message----- > From: Xueming Li > Sent: Tuesday, March 5, 2024 3:16 PM > To: Tummala, Sivaprasad > Cc: Yigit, Ferruh ; dpdk stable > Subject: patch 'eal/x86: add AMD vendor check for TSC calibration' has be= en > queued to stable release 23.11.1 > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Hi, > > FYI, your patch has been queued to stable release 23.11.1 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 03/31/24. So please shout= if anyone > has objections. > > Also note that after the patch there's a diff of the upstream commit vs t= he patch > applied to the branch. This will indicate if there was any rebasing neede= d to apply > to the stable branch. If there were code changes for rebasing > (ie: not only metadata diffs), please double check that the rebase was co= rrectly > done. > > Queued patches are on a temporary branch at: > https://git.dpdk.org/dpdk-stable/log/?h=3D23.11-staging > > This queued commit can be viewed at: > https://git.dpdk.org/dpdk-stable/commit/?h=3D23.11- > staging&id=3D5f30c47cc54f320a4f7bffdd06abcbe6cc2bc7d0 > > Thanks. > > Xueming Li > > --- > From 5f30c47cc54f320a4f7bffdd06abcbe6cc2bc7d0 Mon Sep 17 00:00:00 2001 > From: Sivaprasad Tummala > Date: Wed, 22 Nov 2023 23:27:30 -0800 > Subject: [PATCH] eal/x86: add AMD vendor check for TSC calibration > Cc: Xueming Li > > [ upstream commit 31d72ff4dc7c057366153e9918ac92bf9123a3bc ] > > AMD Epyc processors doesn't support get_tsc_freq_arch(). > The patch allows graceful return to allow fallback to alternate TSC calib= ration. > > Fixes: 3dbc565e81a0 ("timer: honor arch-specific TSC frequency query") > > Signed-off-by: Sivaprasad Tummala > Acked-by: Ferruh Yigit > --- > lib/eal/x86/rte_cycles.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/lib/eal/x86/rte_cycles.c b/lib/eal/x86/rte_cycles.c index > 69ed59b4f0..f147a5231d 100644 > --- a/lib/eal/x86/rte_cycles.c > +++ b/lib/eal/x86/rte_cycles.c > @@ -10,6 +10,10 @@ > #include > #endif > > +#define x86_vendor_amd(t1, t2, t3) \ > + ((t1 =3D=3D 0x68747541) && /* htuA */ \ > + (t2 =3D=3D 0x444d4163) && /* DMAc */ \ > + (t3 =3D=3D 0x69746e65)) /* itne */ > > #include "eal_private.h" > > @@ -110,6 +114,18 @@ get_tsc_freq_arch(void) > uint8_t mult, model; > int32_t ret; > > +#ifdef RTE_TOOLCHAIN_MSVC > + __cpuid(cpuinfo, 0); > + a =3D cpuinfo[0]; > + b =3D cpuinfo[1]; > + c =3D cpuinfo[2]; > + d =3D cpuinfo[3]; > +#else > + __cpuid(0, a, b, c, d); > +#endif > + if (x86_vendor_amd(b, c, d)) > + return 0; > + > /* > * Time Stamp Counter and Nominal Core Crystal Clock > * Information Leaf > -- > 2.34.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if no= n-empty: > --- > --- - 2024-03-05 17:39:31.808571927 +0800 > +++ 0024-eal-x86-add-AMD-vendor-check-for-TSC-calibration.patch > +++ 2024-03-05 17:39:30.703566491 +0800 > @@ -1 +1 @@ > -From 31d72ff4dc7c057366153e9918ac92bf9123a3bc Mon Sep 17 00:00:00 2001 > +From 5f30c47cc54f320a4f7bffdd06abcbe6cc2bc7d0 Mon Sep 17 00:00:00 2001 > @@ -4,0 +5,3 @@ > +Cc: Xueming Li > + > +[ upstream commit 31d72ff4dc7c057366153e9918ac92bf9123a3bc ] > @@ -11 +13,0 @@ > -Cc: stable@dpdk.org