Hi Ian, Thanks for your help, patch enqueued to LTS release candidates. Best Regards, Xueming ________________________________ From: Ian Stokes Sent: Thursday, August 15, 2024 9:11 PM To: stable@dpdk.org Cc: Tomasz Wakula ; Ian Stokes ; Bruce Richardson Subject: [PATCH 23.11] net/ice/base: fix preparing PHY for timesync command From: Tomasz Wakula When preparing a port for timesync command SW should provide Rx type, which indicates the type for the Rx metadata in the ONPI interface. According to the documentation, Rx type should always equal 0x18. Fixes: 97f4f78bbd9f ("net/ice/base: add functions for device clock control") Cc: stable@dpdk.org Signed-off-by: Tomasz Wakula Signed-off-by: Ian Stokes Acked-by: Bruce Richardson --- drivers/net/ice/base/ice_ptp_hw.c | 4 ++-- drivers/net/ice/base/ice_ptp_hw.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index 548ef5e820..c507f211df 100644 --- a/drivers/net/ice/base/ice_ptp_hw.c +++ b/drivers/net/ice/base/ice_ptp_hw.c @@ -2817,8 +2817,8 @@ ice_ptp_one_port_cmd_e822(struct ice_hw *hw, u8 port, enum ice_ptp_tmr_cmd cmd, val &= ~TS_CMD_MASK; val |= cmd_val; - status = ice_write_phy_reg_e822_lp(hw, port, P_REG_TX_TMR_CMD, val, - lock_sbq); + status = ice_write_phy_reg_e822_lp(hw, port, P_REG_TX_TMR_CMD, + val | TS_CMD_RX_TYPE, lock_sbq); if (status) { ice_debug(hw, ICE_DBG_PTP, "Failed to write back TX_TMR_CMD, status %d\n", status); diff --git a/drivers/net/ice/base/ice_ptp_hw.h b/drivers/net/ice/base/ice_ptp_hw.h index 3667c9882d..f53b9e3ecc 100644 --- a/drivers/net/ice/base/ice_ptp_hw.h +++ b/drivers/net/ice/base/ice_ptp_hw.h @@ -295,6 +295,8 @@ enum ice_status ice_ptp_init_phy_cfg(struct ice_hw *hw); #define TS_CMD_MASK_E810 0xFF #define TS_CMD_MASK 0xF #define SYNC_EXEC_CMD 0x3 +#define TS_CMD_RX_TYPE_S 0x4 +#define TS_CMD_RX_TYPE MAKEMASK(0x18, TS_CMD_RX_TYPE_S) /* Macros to derive port low and high addresses on both quads */ #define P_Q0_L(a, p) ((((a) + (0x2000 * (p)))) & 0xFFFF) -- 2.34.1