From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E345446510 for ; Sat, 5 Apr 2025 10:00:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8673402C2; Sat, 5 Apr 2025 10:00:53 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2041.outbound.protection.outlook.com [40.107.212.41]) by mails.dpdk.org (Postfix) with ESMTP id 59A9D400EF for ; Sat, 5 Apr 2025 10:00:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WUsmYPh/HVYT1OsRh2KomvzWhmW9aagTMKCGRPPvOY/+8qkKET228Yjhw819/3Cq2E1motpD8A4t/z0FhvUBuKJZJnQPq+j3zbTAsdVOeyq9LBaBPoESMyb4wLriTaveCu2pJ1DtHe2XsyhM2apEmm3FsD2tkt86FSrj5e8Paqumc5jwXReTJWWnA6Zhr/65AXy2XTg/elIjrls34PAk5Y+T2UzxvXMxKew+ANpZ1AvfwerSJEb65wAroIZJiy1oj0bx04tAOdS7/4CBW7B8rfzKeb7EXUHh7FqgfjEiijmXzckoBP6VBUkweJUahnEOgu36BOE8hc/TwOazxtxNCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pFjS8xOq8W9D972R+pYUn8ZegiaHgYRgpDIMuGC3P0g=; b=EReFs1RrmqmFsfEc4gKAPzT3awgYlrgbOsD6PUk7VAL2FXJNGkuBKqR6qZ9dUgPHlqnvnYgwuYc41b9F/b8EoFqod1f+9CnVLu22hXO7EnQt3cVoI21wC9fRUUrSyg0dTRhz135BXvTMsZlYdZ0mBDRSn+x4sCPjMQsucn5QYqcqmiF/uElUAj64u75QOfJPElUfqjtJfA6HzS7vxMhKVgi0Wqxep9mDuoNer0WtcS+67ND6Xm+s1xD6W645zrL7k6FxFaCi8ZRUSMQqM8pEBK4QSkfBDVO15NOTtgSou1k9eW5F2u0rhEpAHr+OO+aLv4hDr4fwn1h7VHIMaEUKFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pFjS8xOq8W9D972R+pYUn8ZegiaHgYRgpDIMuGC3P0g=; b=ftdOmgnUZf5YtnOFje//5AJo2U/Z2o8s37KC56iiIQGNMCQYhCqUe1EadQYVHSlUMtr456AmQmSp/8brM1D0ZIHar18TK509iA9PWQns5tBj7ZetIMjuZQ2SqZDh4hFruEIBVQW2p8OIlc7ZlcwpfiNuCKngXaQAC3f5r/bHQv4/8/p5Hl8OjPCodfMb49ijvR6k69i/E9Vb+GI0dORiEZ/4sP141fg1wKvtQiEc65DCdqrhGxOEw4wkTiZo9QJ19znDgp2bHzz6NbFv0ZZblj1Mpdl34XX0jin5nZPElQSYSK41U0qEsSgkNKEOzJaHn3NJTiRLVeSjRPFuIw9m7A== Received: from CH3PR12MB8658.namprd12.prod.outlook.com (2603:10b6:610:175::8) by SA3PR12MB9159.namprd12.prod.outlook.com (2603:10b6:806:3a0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.43; Sat, 5 Apr 2025 08:00:50 +0000 Received: from CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42]) by CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42%4]) with mapi id 15.20.8534.048; Sat, 5 Apr 2025 08:00:49 +0000 From: Xueming Li To: Stephen Hemminger , "stable@dpdk.org" Subject: Re: [PATCH 23.11] examples/ptpclient: fix message parsing Thread-Topic: [PATCH 23.11] examples/ptpclient: fix message parsing Thread-Index: AQHbgvIEK8GHLlM/T02+K4BeoETnT7OU9TRCgAAGLfU= Date: Sat, 5 Apr 2025 08:00:49 +0000 Message-ID: References: <20250219171612.506172-1-stephen@networkplumber.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8658:EE_|SA3PR12MB9159:EE_ x-ms-office365-filtering-correlation-id: 726bc1de-129c-4431-fdaf-08dd7417fae6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|13003099007|7053199007|38070700018|8096899003; x-microsoft-antispam-message-info: =?iso-8859-1?Q?p/n9U5Uqv4aIsn09+BAHsIAO74otE97NjqRXhUKg5oXLKYVrgCPNYDX2JQ?= =?iso-8859-1?Q?N9rwTFFKw3ZmCwpQolQxabnRStCJIvw8yCh/auc8SO/k6nx27NEOd7vP2T?= =?iso-8859-1?Q?XayRaJINE/Ja7RUl+BuaDm2kz/fufl/CijsIoAxn89KfOLsxUx3TFvPYyW?= =?iso-8859-1?Q?ntqFKqBUb0gLPQLtnkXiaW0CSlGDiU/lPk5Z45fLuEuWBouKumFJqKBlNt?= =?iso-8859-1?Q?2pAlakW+Sr3czZuW40hqN9z8Rym21VUzLoppW21kde935vFs1ZrCIkWezk?= =?iso-8859-1?Q?sQSyYJ9uA+b0h4D0Il3Po7XldAPUWoqPIsyAhbz0/WMPXNsPjztgWBWmJF?= =?iso-8859-1?Q?0/ejM9eA4EqH0VcSuPCkZhox1NYUKBMVyeHtraKpNKKfmAIqa6rrDMPocj?= =?iso-8859-1?Q?wSUhrgexxm2l/+Jwga8MPQZBHsM4xVmzaP8hYgP1zJJd3UM4IJQa0YJuG+?= =?iso-8859-1?Q?FV05choYZIdDZ5ht6txvhbA9AC6GHMX3Yvs4F8wEnEri/bRS+vUrk5oCqE?= =?iso-8859-1?Q?kdhv0KnbOleS7d1gm6Ze79NGUFSMIkPFg7CdyuuZmKrTbgOirE3CoSJXNb?= =?iso-8859-1?Q?hSciGrT8DfbywWX1Jok7GksqQ2pDuNCSlEArSJW16jnfzhSOcg4b0+IBTv?= =?iso-8859-1?Q?/V+VSGhRu87sZiaF3HmPKs2o2jOhNP9fCkLttvzvrSjc6IwXwINrToZndm?= =?iso-8859-1?Q?FI2mkvFuPalV1oRjqMRAKGI/qCQDZIBJCP/I9oMd6+P2pxic9Yo+7tFYPB?= =?iso-8859-1?Q?ehZlApW0PDZUjqWNKQtIH2qG6/Aw9AeUpQpTaJcL8n94H0J+vusOuoWZxg?= =?iso-8859-1?Q?mKD7tCw3VQ4d1fCp3cTO9Wo4VGxTFNyz/U8tUYYQd6z8Ovk1zy1WGkWhi7?= =?iso-8859-1?Q?BU/wY6ettO3giFDwbxo+CVZ50EkTuOtT1+gHTztX5UaoIJGzccOQ4FM+ue?= =?iso-8859-1?Q?pphalLASjTHWoDBroZ6nHhg/+P7LAzO6CyHMxCdkEEuFUjlLd6QaHWwgI8?= =?iso-8859-1?Q?h/zBiSA4lrcaXoZ/8Ni8IdxFuXTHmDFDfek+mLc/LU2MhI8RX2BqLKcJMG?= =?iso-8859-1?Q?1+NOVBuRr3EmhP3A3AMqFleANWFfiCd7qdYz2q99JuFzAkYc9nyNMP1Ofe?= =?iso-8859-1?Q?XRbtsyKCaSuMF5FpDmvd3lIgdPJfnqEfxA8dZOTAtjk2iILlPoSSO7Hy4L?= =?iso-8859-1?Q?FaxbVbIq52wkZs+6Zl3tzAAaBwX5hPhg8RrZcS3yEhJPRUOSm/g40OMFVU?= =?iso-8859-1?Q?IFcqCYPnWqURm0NLQ93U4KX3+Qngg6nzFUVy4k04orpKb525Tsji+JK8d5?= =?iso-8859-1?Q?Qkt7hy2D2Pc9IwZnFkgjzjtiMhXHZJ2aaZceQQ6V5oiyRIydo7Z4/cmb5V?= =?iso-8859-1?Q?0/vHdJ9e3f2w545DGYLd6hzw98BCIe1y7BiRHVvMDxOPYU62204OHTiKiU?= =?iso-8859-1?Q?jz5cVy5rTL5hcSXHpIK8hRV8tOholLiyHWvVBONF0G11LGqSRFZq6INRoj?= =?iso-8859-1?Q?qitaV+tOLweG45o5SgBFPWch7G3rfuTpmhBj6dRHMgCw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8658.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(13003099007)(7053199007)(38070700018)(8096899003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?nx82g19zwJXiqTYErN9D3oy9ObjAIaz7iB8+kaxxKRFltRnh+qsa+cpEpo?= =?iso-8859-1?Q?WXqNwwH1Q3JynxmZ/agrM0p2dN/6qXu0MZhQAIS2l+GQiDhcDVUi9cCQcc?= =?iso-8859-1?Q?pZR1DfJ5ZX8AnYOv4Gbzu4mg7WZzK14Ir5Pth405g2u4yaYoumFRb3wKzQ?= =?iso-8859-1?Q?Uc5xshkufkQdKEwejgcJDox98yXwhiyGz9YI8VHVl1qha4deCkVUGIqriy?= =?iso-8859-1?Q?AJgf8QRLtC63YkSLnK06p1tQfcXDiizKAVrioxZHAi1qkBlcOakWrInSTm?= =?iso-8859-1?Q?lRNHU4gftzgTsL7CLT4fwW7GUzQu5+ed17E2vNEWFD22SCTVVHkawHDpv2?= =?iso-8859-1?Q?YTu61SCNiTL6vMSD+4acPC202xFFWrDIdZDzccUfCl2GjE93i20IyCV5Gz?= =?iso-8859-1?Q?L6VxYFsg8yKLieVS38NiQsul8AuVSCwfZWofEoXgo7umQUuefpEuwsEgUO?= =?iso-8859-1?Q?MF7wO8nv7sx0GPwob2w4XKU8McTUUNJOrDfJyl/RjyUd2WfEIKfGO9+5s9?= =?iso-8859-1?Q?CaC/Yely5yRfLASuOxmyqS+MZvQjerLR5EJH5vMFtY3Ilgb8qunlLdZVNy?= =?iso-8859-1?Q?gv7594pNMlLIDUxmHPG8e0C4lsBiGK1sAYRax3RUS7zkb0yvRcL1upRq7l?= =?iso-8859-1?Q?qBt1hJm3aPjN80TYm1vPz9d1lJHvqyyab7x9xk6sHzLzCesuwxncPbocJ5?= =?iso-8859-1?Q?ZrKh0VfYq9Y2XM3QREbFxRyEcbTIXsxFDuycHBDtTVh5hvx3ZiXgmXbB2I?= =?iso-8859-1?Q?wtvcz5LWnC6yz3z+cohNPKcBK034nClBktEjDzCzaNV2Qhi454xZd6SG9R?= =?iso-8859-1?Q?JqR35dpLuybkFpWfGyVJ/Dauc6bGcd3FuJwUhRDJBrHY+TvelOJ8r/lEw4?= =?iso-8859-1?Q?5APNF/lXnuN18LgV4CMrM6L7aNLFGsVaz+7jbE31M+hdRbuejBsAM6n/js?= =?iso-8859-1?Q?hyftuPDZ/gnbzR0Xv5ofS8FGNLaZQIz+VMl8+yFCRTUxz/a7FGDh2TsHr4?= =?iso-8859-1?Q?Her+ohVB4HWYYImfV65yu92iJBpTWTCRLnZdeWBm7LYwNkLVvfg5rJ46iB?= =?iso-8859-1?Q?TQakLhA3uKE+e4zyNiSjuqNjApq+gT9buL86+PsIInGhlc8FTCmDMvk+Eb?= =?iso-8859-1?Q?63pmQlqeOzvgr3KOi/ZFqt2J8U2RYP3CD9H857n6Xc4ux/anwhWWYRsEXt?= =?iso-8859-1?Q?27rRmJ/lbA3imqiLKPqWI+Qj2IONyrQw94729iLYwTF/oj3sGbNYWHz9QB?= =?iso-8859-1?Q?J8+4y+cpl9JuwmpvM1buDGZtuq4E8OF/3a9fmvfzPRhhLyRO/DG2dDIbWb?= =?iso-8859-1?Q?fyrzrXScLdAsevoei/nPi2seITvTUxiBtA2UdrcSoP1oiz6uEyar9by2J7?= =?iso-8859-1?Q?8XHFsSAtCOJycKJky/0qkBRjUtM94tTig3ko7SM0LS0444ufp0KIptC+8z?= =?iso-8859-1?Q?dDptS8/XD1kWRMxEFfzOu7tCRWqwJfm6SYZSmFjS5X4rUcO8iRbJvD02SE?= =?iso-8859-1?Q?HzuW6xecyxR9vCw80+jRFMluz4VvloXyj/4KBb/L0SXN7OZiHT3GQANBJi?= =?iso-8859-1?Q?Whjj/aM3nL8t9XX2n5Zlh79pmD0QES99uHd1w+JpiPOKvuKeQWzdYQTIE2?= =?iso-8859-1?Q?KvvzXdz1KiqUBQ50QqlgzicQbQYrhTS4cH?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB86582E49EBA91838C38E1E7FA1A82CH3PR12MB8658namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8658.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 726bc1de-129c-4431-fdaf-08dd7417fae6 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2025 08:00:49.8862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4AStgQdkQh7wIMXAOLWnh8JUq5llxD9TDgTrMwJrTOfeSQJbxCfbGqPsRGsTb0zfUOR/t8sPWFg2LbkrHUR8Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9159 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_CH3PR12MB86582E49EBA91838C38E1E7FA1A82CH3PR12MB8658namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Stephen, Found a compilation issue, I made following change to make it work, let me = know if you have any questions: - if (memcmp(&ptp_hdr->master_clock_id, + if (memcmp(&ptp_data->master_clock_id, Regards, Xueming ________________________________ From: Xueming Li Sent: Saturday, April 5, 2025 3:38 PM To: Stephen Hemminger; stable@dpdk.org Subject: Re: [PATCH 23.11] examples/ptpclient: fix message parsing Thanks, patch queued to 23.11.4 release staging Regards, Xueming ________________________________ From: Stephen Hemminger Sent: Thursday, February 20, 2025 1:16 AM To: stable@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 23.11] examples/ptpclient: fix message parsing [ upstream commit 19630bd0d735badb06143086d4f1c50d726b7bad ] Calling memcmp on same structure will always be true. Replace with same conditional used elsewhere. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Signed-off-by: Stephen Hemminger --- examples/ptpclient/ptpclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.= c index cdf2da64df..92b54f240e 100644 --- a/examples/ptpclient/ptpclient.c +++ b/examples/ptpclient/ptpclient.c @@ -365,7 +365,7 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, = uint16_t rx_tstamp_idx) ptp_data->ptpset =3D 1; } - if (memcmp(&ptp_hdr->source_port_id.clock_id, + if (memcmp(&ptp_hdr->master_clock_id, &ptp_hdr->source_port_id.clock_id, sizeof(struct clock_id)) =3D=3D 0) { -- 2.47.2 --_000_CH3PR12MB86582E49EBA91838C38E1E7FA1A82CH3PR12MB8658namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hi Stephen,

Found a compilation issue, I made following change to make it work, let me&= nbsp;know if you have any questions:

-       if (memcmp(&ptp_hdr->master_clock_id,
+       if (memcmp(&ptp_data->master_clock_id,

Regards,
Xueming

From: Xueming Li
Sent: Saturday, April 5, 2025 3:38 PM
To: Stephen Hemminger; stable@dpdk.org
Subject: Re: [PATCH 23.11] examples/ptpclient: fix message pars= ing

Thanks, patch queued to 23.11.4 release staging

Regards,
Xueming
From: Stephen Hemminger <stephen@networkplumber.org><= br> Sent: Thursday, February 20, 2025 1:16 AM
To: stable@dpdk.org <stable@dpdk.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 23.11] examples/ptpclient: fix message parsing<= /span>
 
[ upstream commit 19630bd0d= 735badb06143086d4f1c50d726b7bad ]

Calling memcmp on same structure will always be true.
Replace with same conditional used elsewhere.

Link: https://pvs-studio.com/en/blog/posts/cpp/1183/

Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client"= )

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 examples/ptpclient/ptpclient.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.= c
index cdf2da64df..92b54f240e 100644
--- a/examples/ptpclient/ptpclient.c
+++ b/examples/ptpclient/ptpclient.c
@@ -365,7 +365,7 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, = uint16_t rx_tstamp_idx)
            &nb= sp;    ptp_data->ptpset =3D 1;
         }
 
-       if (memcmp(&ptp_hdr->source_po= rt_id.clock_id,
+       if (memcmp(&ptp_hdr->master_cl= ock_id,
            &nb= sp;            &= ptp_hdr->source_port_id.clock_id,
            &nb= sp;            sizeo= f(struct clock_id)) =3D=3D 0) {
 
--
2.47.2

--_000_CH3PR12MB86582E49EBA91838C38E1E7FA1A82CH3PR12MB8658namp_--