Re: [PATCH 23.11] test/crypto: fix callback setup tests

[Xueming Li <xuemingl@nvidia.com>]

[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]

Hi Brian,

Thanks for fixing this, patch include in 23.11.4 rc.

Best regards,
Xueming
________________________________
From: Brian Dooley <brian.dooley@intel.com>
Sent: Friday, November 29, 2024 1:36 AM
To: Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>
Cc: stable@dpdk.org <stable@dpdk.org>; Brian Dooley <brian.dooley@intel.com>
Subject: [PATCH 23.11] test/crypto: fix callback setup tests

The test_deq_callback_setup and test_enq_callback_setup tests are
asserting the incorrect case and need to be reversed to reflect correct
callbacks being called.

Fixes: 4fe42b5bd587 ("test/crypto: fix enqueue/dequeue callback case")

Signed-off-by: Brian Dooley <brian.dooley@intel.com>
---
 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 6cd38aefae..005d3a87f9 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -13727,7 +13727,7 @@ test_enq_callback_setup(void)
                         "qp %u on cryptodev %u",
                         qp_id, ts_params->valid_devs[0]);

-       TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not called");
+       TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not called");

         return TEST_SUCCESS;
 }
@@ -13848,7 +13848,7 @@ test_deq_callback_setup(void)
                         "qp %u on cryptodev %u",
                         qp_id, ts_params->valid_devs[0]);

-       TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not called");
+       TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not called");

         return TEST_SUCCESS;
 }
--
2.25.1


[-- Attachment #2: Type: text/html, Size: 4382 bytes --]