From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C81D3465FC for ; Tue, 22 Apr 2025 10:06:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA88D402E6; Tue, 22 Apr 2025 10:06:29 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2079.outbound.protection.outlook.com [40.107.92.79]) by mails.dpdk.org (Postfix) with ESMTP id 8E4A3402E6 for ; Tue, 22 Apr 2025 10:06:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UJUr2FjQUNphUmYuRH1wgVEg7jujSJuKRi1V0w1wImv5Njy+WJ54F/XU6WdeN1zJWfcYxwgyHYGjwLQ1yHkM9Ed2BS50lulAn8t4crrxjP4+fLIJsWhL8BR1fZmzVS+hFsRM7110PomB2ukFZ1tNoA7tGLfmZt1bqCYj+yrZ3qP2VQy5SCdYkwQwvpiuS504Jr4C4WAhYbREt5DMw0IwoYeK5lqgS32MoCxcRSUuP80c36A4UDGI33DteOm7F0AS2wwFnB6c4g7saOGnEQth05j1L4WflDLH+3Jo2rCGrfUAqKNXT11tDO8FuRLbLunzllU5PxPFvXZ+8JaHs20Htw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+i6w7fi/fBbU6es/l1spcEAEI6siIkDWW+KCT495+Xk=; b=H2PZHtL99ngHSuQKbmTwqpEKTIX20rglCIMWNHjqeOT1kFxGleh7WGGgDk/4Ax/KHQGZN8W54VtJZd3Y67Y5ZUaYjWNZQmLfiJud1ghTYocqNrUgcj1fwgvwd7dqaDdTmuLz+fbp+xm6M58OSzbHm3ogtInXZXljBTOfX/b8Nzvz5hi2hb8BRxan80fYEWFGyZC71KU6VH1087n2o7BYWEUCl+OVTNnu2mKirQh3NrrTN+eqGGl8DqtEeNFgN/6SRcVhFC2EtjvApqpmbwyxPvJyStFhICTwAlpEcoPxJJE+lmdXPqOCcivV7KmzGQ/IlGseCZLWiYwUuGzbOYIFsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+i6w7fi/fBbU6es/l1spcEAEI6siIkDWW+KCT495+Xk=; b=mki+ro/o2izDw/sWRucyzz0I5F38PvCpLdyfoipkucyjan82cy9QiuCIZs6hMBxq1WX/4MYwIeWRutCJ5jWt5QP45ohr5LF078AFUfGTMoXxc8bwHnhMNT0w6MfldOSBxNZCs/Ix8mF1yjftE2C7fafU8xEVjueNAp1S6kfugJuLhLPXMEit2wnxYoR3KLbnU5OKPHuuIQh5rC1wmX8Qn5mNxTb8q0wPibpmtINERwE4ZA4uc0N00zajWXQIFvRaBl7+rX2MLaDGHvt+2zEDxPqi3oTZWXFODIn1KQRxpAm3CAF2DUkrjcu92TNPabIk0BnfddIcXZ2xFpCJriIGJg== Received: from CH3PR12MB8658.namprd12.prod.outlook.com (2603:10b6:610:175::8) by MW4PR12MB5643.namprd12.prod.outlook.com (2603:10b6:303:188::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.32; Tue, 22 Apr 2025 08:06:25 +0000 Received: from CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42]) by CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42%6]) with mapi id 15.20.8655.021; Tue, 22 Apr 2025 08:06:25 +0000 From: Xueming Li To: Brian Dooley , Akhil Goyal , Fan Zhang CC: "stable@dpdk.org" Subject: Re: [PATCH 23.11] test/crypto: fix callback setup tests Thread-Topic: [PATCH 23.11] test/crypto: fix callback setup tests Thread-Index: AQHbQbwhCV+H0FgvLkmkWJ3GVyP+ZrOwN0TA Date: Tue, 22 Apr 2025 08:06:25 +0000 Message-ID: References: <20241128173651.3962267-1-brian.dooley@intel.com> In-Reply-To: <20241128173651.3962267-1-brian.dooley@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8658:EE_|MW4PR12MB5643:EE_ x-ms-office365-filtering-correlation-id: 091fa10e-d015-485b-c1b3-08dd817493cb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018|8096899003|7053199007; x-microsoft-antispam-message-info: =?us-ascii?Q?i7IZA2zhfdafyxjJShJJ3w0d1UtjhmxFQ4pNv8RnRm5DK4AwiwVEfqJyI3lu?= =?us-ascii?Q?EJjUmbZLDQEc3OXWCzQvm09Yg55c3dUA9OWw1vP9cmVlDIZkHaDP6hZV+BNV?= =?us-ascii?Q?q3V+n7XiKwThHofTflt/kUw7w0vhJEdy7pqFU4GtlQCG1WHmZwSUKkSXphCm?= =?us-ascii?Q?ynKyUB9Pai3dJo0h5o6qaWtSG8S6xGNDkWaetaAitqYHzIa8SOlFA/PBKUCx?= =?us-ascii?Q?YTuzJZ9YjvkLK2UykF1ra6Mm+GSJ8g07yUKWcBzSl3ln+WDXxeP+gfIKd39N?= =?us-ascii?Q?rO218sL9S/pY1uSycwlUyPXNrjLFCYqDAuf8Yciw0xElMxqsk8shshFoiPpu?= =?us-ascii?Q?wSTJfEEQGII6j8OqXqlel1RpAXnSThcU9O5PexOn41/lBqh0gPeAeCwGb6+8?= =?us-ascii?Q?p1Zozhb0SuTkBxVdfvrIUfGTxpRwxiViXY00ZGGf8hfra6uqNBFfbHw4SY0q?= =?us-ascii?Q?coLClBi6vZJhLn+3NYu/Tn0XkKQ9Ycfjtw5pT4FJQ/SUm62wxrSg+ShVEWC5?= =?us-ascii?Q?TnMqR7TrTFF3gh0q+hOUCMJXM7SC6k98IuefWLwZqBWifCVC6RhBkTvIz6Wk?= =?us-ascii?Q?49SabdoYaY4WiJh6NDThs9fi1chmZjNw/M5xFMzqR0WNoy3uvwa2dvzl4TMk?= =?us-ascii?Q?7CF2BArvnBztixt+SrsfEvTmRjlw5dIxnCZod6GtQ/opSdM+zOeC//HcIIeg?= =?us-ascii?Q?oKmvPy5gXjNFE1lJY4h3wsfyyBCAb8Uw1pHNX57ufAEGThiAsF4JyrdM4n3W?= =?us-ascii?Q?QJKSB17C/TyJA0PjeKxrHYC3nQujOJ8hoUCAKA0YO2xEoKTZWBcaW5cwGeM5?= =?us-ascii?Q?BfNNWSUFYNAIf2y9arWTVYUQ7FBSIjxiqCDYqXqhElNP8L0/KuX0P7Ax3sUR?= =?us-ascii?Q?6iTFg2WJC0GiV9lz7D6eXar2LrfMSHwiGEEStOBKRN5XyWxiveANsv+MyK3Z?= =?us-ascii?Q?nXbdQvgD/H71QYuSDJ5wd9TggjdbU0n5IKd0QCFdUUQNlCQusCZxv0dpDm1F?= =?us-ascii?Q?JgWxG8pscQtHeRVzXzcCqyXPKd4niIv0Ha17IB0GXT78uG8MUWPrwwg/mHo2?= =?us-ascii?Q?IJW+o+lrctYZ5z/gFyWuH9xETuIyclEyo4Nv2nipRKl8D+E2bmu1uSsLgRyV?= =?us-ascii?Q?mqHH6hqzO4MKYoISEy0m92HA/J1JoiJmnG/rK885QPaZV41WL70U2nY3LxLr?= =?us-ascii?Q?ppQoljW+af4+tcvyqc6u5PvZ3VOhlRCX9wxSB6sSHEy6XKkj4/DnGSTBVU4i?= =?us-ascii?Q?jJ+81BEx+OPuT+RxdUMoB+Xx34QlaWlXgb7RqavcWMcRgNnHG225ZZhAlODM?= =?us-ascii?Q?VJ3LRpPBN5EIn0iR2OdHeYi9kCeCJ3OCCPrn0m8J0/KVTWzbSdBLtqwJ8uqn?= =?us-ascii?Q?Jlohu/9n/kwMu0PtXd7K8ybLmmCX49PHfwEos8xGPcP+QMTqs+2djWH+i0tG?= =?us-ascii?Q?jZmO0xq4WCzLXXOdxCiVXBg3nqTu/ONVexWr5z6XRN4PtqosEEBCnQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8658.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018)(8096899003)(7053199007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ttbyUUMdCruMpqFhqbnQmjrc9IB5Mv+2UkQfLhoE5IjrJUdsANWtTqDqHjJ6?= =?us-ascii?Q?dhtLTl1TbUkH/v/juM6efvxtkpW88MqAuyzNk8HGIqRbXA6LqZRdgc7YWgM5?= =?us-ascii?Q?KGUeoqu+uChY8E9g+4V0a+yEWTJmjxcfVGrShvVTLyWPQKCETau7gsC4c4zW?= =?us-ascii?Q?XTYyYFg+p7vU4xXF81Uom/i/xO7OOOYj5wnUAY8bLJ03B1B9k5fzMuuITZTR?= =?us-ascii?Q?RIDMxxulRSHX4eUSe59EKAD3aioipR/6zzwlPYOQFVbWxcn9pcEnm7tYk/x9?= =?us-ascii?Q?/lVo9PWq1D4crRSCQrkRZWsrQJLU2PuuWw6l1T6seiPU5+OQhWqIqE78jiRE?= =?us-ascii?Q?iLy5onvvatsCmhDSSMSd6ENf/BhfrM0uQEHGZpfbdKwHxCbsuD1YelueSSWb?= =?us-ascii?Q?7IpamwOmC7yY4wlO4bXHYUIL52FnMP9eIzm10Q8pH/syiWj3BkKyVH+GUEcK?= =?us-ascii?Q?vbuKX7ycquXR6ayU4N/+0uCf0H1vyUE48QeqTTqugGdhciwsLKbyUERzHYif?= =?us-ascii?Q?0HmSI2hGrfSGe0LGIE4nhN4GEiWA8Fy7ChTiKq5JmJnQIqb99VRls3/gc01P?= =?us-ascii?Q?fS9beUYRYa/GmvX9TZ0boDVm0ZWr3HGKB3S66AwW6N21uiq/RIRGVxjHv7pa?= =?us-ascii?Q?Kiu6a2C7GqV0OKfnmZ51CoFJZ2x2oPIoHrmiP4SXNTRTAF40bzi7IgTKLlCF?= =?us-ascii?Q?YhzVo1nW6jfUgx2u19BMZaJol/aAtxydsFJTz5jyIbSaIi+mLsW0+jg9fU0r?= =?us-ascii?Q?gGo3ZSk3a7xLDtq/r+8VxgGlAk8JaN8iHy+/tY9UlsqJ5cD4pVg+ywehAuFV?= =?us-ascii?Q?yk+5iWiEb0X1DbbJBzET5PNowsdgpD9qb1MoOa4cN7oF5VnjwE0Vn9vx7dVV?= =?us-ascii?Q?a44wuTojcYGcbcC96Ygh7FEB7fHxDy2997E7QQzsV6jH6rwb5mlq8QHT0Yl9?= =?us-ascii?Q?Ez4PJ/SeHaDX7dk/xDPkzVEJtvTQ8i737VH2BBfzdpQpNfftIuQjrnG7KKsJ?= =?us-ascii?Q?Yxxkj7XlDYXK4gNmlE67HMoIkusydsPPd1SPWkeVnsBcLnsqijhIIozjjAtx?= =?us-ascii?Q?TZjl04cgrs6lNnYYJkHtYBa6OW/JTVJP45POoD6lL4cwjV0WbCVUww8TvQkA?= =?us-ascii?Q?Zd8B+Acdv4ua61HQP8L+D3MHIuRyB7nh44sAUkxvXtnmh/gC2j5PieS8l1de?= =?us-ascii?Q?elbn11nLTYD8NhlRhQfkWEgrHGbz6ws/55pyUDn362VnFIld5TB+YOG6HHcj?= =?us-ascii?Q?ttrskppTqvXGEVfE11sBz9v68LoLg4ZWQWtBPaxZLk6grghtn4rXIjTJhZrN?= =?us-ascii?Q?TAvYW00MDyvAMIyaSmr1aO+Nr9/c5tPRKqZK3TA02b9XeXirUFEP+XwLCrDW?= =?us-ascii?Q?7yhMmAhiHWByav/ja9xUHKSjhfWM4Ofi/sW/JZTe/iSeD5378dVSI4Lqcv8m?= =?us-ascii?Q?JQP/MAZAaUfLUav7hZiYMlUbVeHH3YyGheKOIvDMUKRfMf8rmSNuIcSIFso9?= =?us-ascii?Q?0AhYUm+bCZUvwN+/VENzk2Jk3U1peXtnrqtDwGuD77Zx5xnT5QtGARrFBnqC?= =?us-ascii?Q?jSKVxXfZGim1E4limDY=3D?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB86586705D46400504BDEADE0A1BB2CH3PR12MB8658namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8658.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 091fa10e-d015-485b-c1b3-08dd817493cb X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2025 08:06:25.2120 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cgeBClpW+UieR2RxfKRk2denR2CLKXCwT5egQzrAJqj/srOOCngMyq9TtOhs26Ji+7hKhqZU/TbgUcfoOFE0cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5643 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_CH3PR12MB86586705D46400504BDEADE0A1BB2CH3PR12MB8658namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Brian, Thanks for fixing this, patch include in 23.11.4 rc. Best regards, Xueming ________________________________ From: Brian Dooley Sent: Friday, November 29, 2024 1:36 AM To: Akhil Goyal ; Fan Zhang Cc: stable@dpdk.org ; Brian Dooley Subject: [PATCH 23.11] test/crypto: fix callback setup tests The test_deq_callback_setup and test_enq_callback_setup tests are asserting the incorrect case and need to be reversed to reflect correct callbacks being called. Fixes: 4fe42b5bd587 ("test/crypto: fix enqueue/dequeue callback case") Signed-off-by: Brian Dooley --- app/test/test_cryptodev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 6cd38aefae..005d3a87f9 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -13727,7 +13727,7 @@ test_enq_callback_setup(void) "qp %u on cryptodev %u", qp_id, ts_params->valid_devs[0]); - TEST_ASSERT(deq_cb_called =3D=3D true, "Crypto dequeue callback not= called"); + TEST_ASSERT(enq_cb_called =3D=3D true, "Crypto enqueue callback not= called"); return TEST_SUCCESS; } @@ -13848,7 +13848,7 @@ test_deq_callback_setup(void) "qp %u on cryptodev %u", qp_id, ts_params->valid_devs[0]); - TEST_ASSERT(enq_cb_called =3D=3D true, "Crypto enqueue callback not= called"); + TEST_ASSERT(deq_cb_called =3D=3D true, "Crypto dequeue callback not= called"); return TEST_SUCCESS; } -- 2.25.1 --_000_CH3PR12MB86586705D46400504BDEADE0A1BB2CH3PR12MB8658namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Brian,

Thanks for fixing this, patch include in 23.11.4 rc.

Best regards,
Xueming
From: Brian Dooley <bria= n.dooley@intel.com>
Sent: Friday, November 29, 2024 1:36 AM
To: Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.o= ss@gmail.com>
Cc: stable@dpdk.org <stable@dpdk.org>; Brian Dooley <brian.= dooley@intel.com>
Subject: [PATCH 23.11] test/crypto: fix callback setup tests
 
The test_deq_callback_setup and test_enq_callback_= setup tests are
asserting the incorrect case and need to be reversed to reflect correct
callbacks being called.

Fixes: 4fe42b5bd587 ("test/crypto: fix enqueue/dequeue callback case&q= uot;)

Signed-off-by: Brian Dooley <brian.dooley@intel.com>
---
 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 6cd38aefae..005d3a87f9 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -13727,7 +13727,7 @@ test_enq_callback_setup(void)
            &nb= sp;            "= ;qp %u on cryptodev %u",
            &nb= sp;            qp_id= , ts_params->valid_devs[0]);
 
-       TEST_ASSERT(deq_cb_called =3D=3D true= , "Crypto dequeue callback not called");
+       TEST_ASSERT(enq_cb_called =3D=3D true= , "Crypto enqueue callback not called");
 
         return TEST_SUCCESS;
 }
@@ -13848,7 +13848,7 @@ test_deq_callback_setup(void)
            &nb= sp;            "= ;qp %u on cryptodev %u",
            &nb= sp;            qp_id= , ts_params->valid_devs[0]);
 
-       TEST_ASSERT(enq_cb_called =3D=3D true= , "Crypto enqueue callback not called");
+       TEST_ASSERT(deq_cb_called =3D=3D true= , "Crypto dequeue callback not called");
 
         return TEST_SUCCESS;
 }
--
2.25.1

--_000_CH3PR12MB86586705D46400504BDEADE0A1BB2CH3PR12MB8658namp_--