From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FCF545E85 for ; Thu, 12 Dec 2024 15:08:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC1BF40269; Thu, 12 Dec 2024 15:08:33 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2060.outbound.protection.outlook.com [40.107.244.60]) by mails.dpdk.org (Postfix) with ESMTP id 0BB8240269 for ; Thu, 12 Dec 2024 15:08:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AIbAE6kwT6QccGD6bMonCu5AzEOhMEMeBDuwQ05iY09F9sYiBa0WJVLd7/f4dhxRLrjoRLViGnVU2oLYhK2i0zP6VaxmyknOMyFjI3mdMfH0J/+LfUmfivO1hr2jGOCaciczz9cFe9Wd9msLbs56hMbUQp0dnajlXoIkTT+J0nTgxPAgxz0k/+C7WG2Vg3hUsbN80vfLFpbEX8Z0xNhxLA/y41r9X6+5qWcfGx3bIrDKFormy7rX3ylMEufgWkBCIL9BlKTrFq4IzvdmSsAE4PoFQ14NtQGTp7YB5QDIH7tuHAzi7Hu/hpjcbQhOstNjogS39XfGxbgLJpDqxam0jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LP5UkRt1uaEnGN9nEsUKKhABuzcC8Hil7qwbOMUw/DM=; b=ogdTPXDmMYPiRB0DWgXkN3r8wR2bgqUntFfcAeJzviBny54mAxBFCrkF4VqHsNOR9RmduEYmTCP94gND+k6ZOhxoQNsXNG/kU3CajJI9JPwR09FS8cUI6IXgaf5mRUyXDjrM7gpEwqYEgt6TMv4xRZKWbqOIFFX7YxlO4T+cRG5HJe6M+wKPazRB0vFa7FVk4vudNiplFGDaSj/BhXf/EtDbnKGxbkUosAH4j4QFFa9oVv7ujXZKK6u0djUD4/77LJETcTyd5ovmc8QgXBJW7n2Mh2wRooXxR57WDYVMBCOuELrhKp61t/+y/A2+QTp+gYQn53uByQf36WQBrQjtQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LP5UkRt1uaEnGN9nEsUKKhABuzcC8Hil7qwbOMUw/DM=; b=ZcQVMmsdAOt5swu/pzMi9fDKaFdEidc8baH3+ZzY4blFLseedRFw390+k33LQtanmAWLxY4PDpXc5AIOPNKlIxMQ2IzX+cIpaxiS56Nd+W6RbMzPoAccnv+UomrKkdTszh2WamIN/ImHtCzhOvAThf+mrs6VeJcmFC6aFdCdFuHjXKDNXa/NUXRknFVere4H8r/QHVWlGXXt4wEQUov/UrsL+55CRoucE6cCcMMhpb5gf16uXGwzPomXUlgyLx0qYKq7rA8dHQz4l0kxzIjWrEYEtDM13ljeXym0dfhy/vbHsyzKdwiI2qDDZYThVzKEltbAV4KEDNSWxd509x7E9w== Received: from CH3PR12MB8658.namprd12.prod.outlook.com (2603:10b6:610:175::8) by IA0PR12MB7724.namprd12.prod.outlook.com (2603:10b6:208:430::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.15; Thu, 12 Dec 2024 14:08:27 +0000 Received: from CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42]) by CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42%3]) with mapi id 15.20.8230.016; Thu, 12 Dec 2024 14:08:27 +0000 From: Xueming Li To: David Marchand , "stable@dpdk.org" Subject: Re: [23.11 2/2] power: fix log message when checking lcore ID Thread-Topic: [23.11 2/2] power: fix log message when checking lcore ID Thread-Index: AQHbTJkl32QBp+kWW0mKodH5n/LgxLLipQwU Date: Thu, 12 Dec 2024 14:08:27 +0000 Message-ID: References: <20241212132358.602485-1-david.marchand@redhat.com> <20241212132358.602485-2-david.marchand@redhat.com> In-Reply-To: <20241212132358.602485-2-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8658:EE_|IA0PR12MB7724:EE_ x-ms-office365-filtering-correlation-id: f981c514-d356-48de-f674-08dd1ab67338 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|8096899003|7053199007|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?fqpRhTbled5Lh1Cjw9hBhUCd6JZO0RzjcfWkVsnY4rWInVckdcsrFYLYfq?= =?iso-8859-1?Q?PI6CMM89fhBhteU/fzkuelKb0HcXR2VgBIbRXbFzWwo2SSzDmgz/U268qC?= =?iso-8859-1?Q?2GRlClRnvz8ZWGClWzFrpPq3ls2venORg10jWaFdyU40FkB7QCkkUblTsE?= =?iso-8859-1?Q?H0l2di6bXrPhZCDm95PlYAuVtVzfR3aSgFI/37qUGHOuKiH8dqcBfhflVb?= =?iso-8859-1?Q?KormsPAdq6LH36UD6gpEIsETsuCtzqC3WhGs7+a4bZQmoAkv46HIuAP4W9?= =?iso-8859-1?Q?RxAuUNKzZr4uREgLw8lXBdJpRTc/mF9zqAI1PSxUejXowm8W8pVgdG7yQn?= =?iso-8859-1?Q?KiAvySeKdQnJ1j1/G+czWNItwDtdZRsAD6AbqWi0VBPfYQcO2OTIBGuS1i?= =?iso-8859-1?Q?zMsoLe12Sr29eY4IBma7jqlw9X/cQy2N4rqk/iFH0L29wHBaNlcXAnUIas?= =?iso-8859-1?Q?Ordb8IFm9q2luVk2WT+ryudYpVHBrzG/QmPhPSvy4Et/pkXqYJFpuaDoJ5?= =?iso-8859-1?Q?p00o3VF29VtIcSOk2p6AXY2G0apacxCK/jvMWp+Y9B77zXSuaFT17tVpLV?= =?iso-8859-1?Q?pdV5dvAgAuuSgr/Ncrr/v1RhjyX3LHRE8vbxLOQuUtYr0kAe9biDw5pshi?= =?iso-8859-1?Q?ydIdPObgH7of+fhPSWi2FAYA+KfldQ286NO/L/4KVlZop7EgAqpHelrxWC?= =?iso-8859-1?Q?bO5PBDu3hk2mreC/fDAAQbwCp8n4Nt9JzDklpdApUjB/qLBtXYuDrtSz9b?= =?iso-8859-1?Q?Q88RS2d1FEfkt9TYDs87jCmdqYy4SZcG8fnErHEsx87W5fudMnwiHyvbuk?= =?iso-8859-1?Q?E1iwwsOIbD9Xc9vGXpUTB96xOkXkKN57S4R2lpI2iMD31eCjcBImb0dYV9?= =?iso-8859-1?Q?++V4vKffhSdJ4QvhuZPMVN54QQr1OAeg8ed933jDkQMLDnVqQ3Ui2ABhXc?= =?iso-8859-1?Q?3G7vVqyUys+h3kLb7hrZG0Q5GCl+bZgkjOoaAOVeV6yepFIig0QahYjqL3?= =?iso-8859-1?Q?nEywPTypAXrbCpsmefDuKS0QZZi+znv8T9iKMKpFtI6SGnoEwTX6sfznOL?= =?iso-8859-1?Q?L0/pvZ95y444cpJ3inUl/BIUiP5JZNqh1VUlBnKub+wavDvvQELJJbrSw4?= =?iso-8859-1?Q?vuwldQqc/C5eT8m1rPOe9uPwe21iLNSji/plPChE7mh/OjRUlSf4dAfNBa?= =?iso-8859-1?Q?ah0br0VvPTo5Rn06nQgmrDT61zWnPxCmlxcXbTVftcBONzkSrz1geiVkuN?= =?iso-8859-1?Q?IdY9CzCkj/Oj/a05vbcYggM4O8DWoTBmNNPboXZ7epj2l+DHBmohI4JGVK?= =?iso-8859-1?Q?3Jp6vCTqENhDErUQ61X7xx5J0eGTVvENbOhoKctmCy4zzJOwgFHMl2DZDT?= =?iso-8859-1?Q?MSoNfyr6Jhnco6kwd8MOreCsMWPRaQYrdy7bHGeB4W2TatjwIAkTepT364?= =?iso-8859-1?Q?+gtgGcvWqRIIlJGPalorHVwbBTUEqrhzehmNqw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8658.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(8096899003)(7053199007)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?zhWlbCBd+vVk+vg3E+b6XUo0Q8BViGX9OzGoNi97et2GZ/lBtgCNp04lmn?= =?iso-8859-1?Q?XXfPNBPYHajLkAs68x71zCgSyFrD/B/GmUYWG/QVk3fIrqfLhEGe3N9y2B?= =?iso-8859-1?Q?l/GmFVORR/mY7BdjyrTT9v2latw/iTJEp8cczfr9zxGvza++7GYXojezFu?= =?iso-8859-1?Q?s/TuHA+Ktsm1cITJFs92wudGh+bJ97PpDHyhEOtDTxthkgRoiGgdtbMWwp?= =?iso-8859-1?Q?90n3IgJYF6TdOJuXiqvKNPWovsshn114wYPxqjsjQHgBSreDyAvtcjv7D/?= =?iso-8859-1?Q?VPhvh5XDZkkA0j6G1mdUQabukJKWujADCUyIh9WYYuOMK05l+H2zDu9fYr?= =?iso-8859-1?Q?wvhx2d7C77lHE0mfyMJq5hyQChJuQM8UQIo1QVP8FXFDFQBwQyCaU8uwf9?= =?iso-8859-1?Q?tq1Z41RONSEgivN+Be0G1iaOz/1Zoixc9K87A15NjhL5M+mrVatpbOcROP?= =?iso-8859-1?Q?yDXUL3VDWhlr5kTzbBfp6y3mSdkAV+FLHa/LFvBxYRqxJ7Yd/5pX3weS0r?= =?iso-8859-1?Q?0U8qJ05V60Tp2j8jLn4k7TfPUiHT7Qpb6OMm/tLAnjx2zEXZmuK+FUouEM?= =?iso-8859-1?Q?Xqe4QUpdxZXWp1dJ6tRus71zZl3VtTr43kPeHlyxTviOuz78/gUs1lTK+7?= =?iso-8859-1?Q?90t8suVU2jyEsg7gXqhIK9t+yol7ZWAq7YVMATaKnIaB0bmTlpdPq3tkRb?= =?iso-8859-1?Q?wDAX2pWXcCHUrssW5+BmepJDl1bhwLLgbv49+KjNhOG89Idf4Yq3iq9ccH?= =?iso-8859-1?Q?NX0uqAFMOo43u8FbjhpRdmfwouIR5XFripeZgCgHhWam487rHwoKm6sa1r?= =?iso-8859-1?Q?aSHlLzMcMYh8hrF9gEudKZdQU1JZUTw4DByx1x1ENKAbY4qy/Lu0nW0WKd?= =?iso-8859-1?Q?mHSi4Xyf6G7EsPHcTgMukWHB8cMj6TIibkW68YBbi6oUQzFPRSjGS6RtWb?= =?iso-8859-1?Q?IcOrrk1fhCR3Gu1/n/BljALQpeOqkI765Gf6E42iIPSeefGLz3Ei6zF2RD?= =?iso-8859-1?Q?T1wPqVfQqE1Soxd+JrlVOAw8tbwRp2hbQBj58t0PJJI9ItN7D6Yq29Yv9W?= =?iso-8859-1?Q?C4jujuKB6Awhhgf6WA6kKK3uelFrIPPIncgRQ8h8e9jGg20w3i65N6GZVR?= =?iso-8859-1?Q?ySXKNj5fKrQI5FJGHh8V1HThPiogVFHmoo9bfcF7Ubk5eyLTZi+2/yx28b?= =?iso-8859-1?Q?HP1ffOPLvvjwHNoNMjTjbP+z4kk+EJ2FlDeKUA0rTPFYq4BUUQ2c59bUGu?= =?iso-8859-1?Q?r5EKKUpH7EXLFvDMK4x5RiRT2cSCNUzcEsryP7AFKuP1rkUXJbo/pHDrQH?= =?iso-8859-1?Q?m37zvHkmGl9RMb/8y0ld1h5dU6D5fM65eXgguwTegeObLF5bW7K3w30S2F?= =?iso-8859-1?Q?9NYu+RRGEQ7ncep7XLMFEgjZZy3KW/HLuz3IRXl/Z5/Q27OJMfcYyyKy5+?= =?iso-8859-1?Q?0lcT/Q3dwo1Rn2kCC0RbNHo4ukRu7B0sfsc2YjBvHCbJPK4F8PI2euUibx?= =?iso-8859-1?Q?6NY3Er9hptPcUCuda8xkIIm/VIsRZPuc1mxaqY96z/WMzIOTQZqzKIvblS?= =?iso-8859-1?Q?hMfz17tKGCnNHjMFa3OnPUAFYzlSDsyQnxWZFOenc12oRF7s15DcwWRWwA?= =?iso-8859-1?Q?lONVaEAgVKEsV9kwY+6KzC1Pa40Zn1DtX5?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB86587D9D95781B7CB420ED00A13F2CH3PR12MB8658namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8658.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f981c514-d356-48de-f674-08dd1ab67338 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2024 14:08:27.5325 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 282AfuP0UwNPECfwyGt+jjwHjW/8ay7Mzy8mVm8dZO1DHsF62RIzmi7ZtXrDm5WbZJSpGpT9bY8IlYXHj3y0Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7724 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_CH3PR12MB86587D9D95781B7CB420ED00A13F2CH3PR12MB8658namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi David, Thanks for the fixes, will apply and create a new tag for it. ________________________________ From: David Marchand Sent: Thursday, December 12, 2024 9:23 PM To: stable@dpdk.org ; Xueming Li Subject: [23.11 2/2] power: fix log message when checking lcore ID Caught while inspecting changes backported in 23.11 LTS branch. The POWER_LOG() macro in the main branch automatically appends a \n which is not done by RTE_LOG(). Fixes: 1afa4c7c5ea6 ("power: fix mapped lcore ID") Signed-off-by: David Marchand --- lib/power/power_amd_pstate_cpufreq.c | 2 +- lib/power/power_common.c | 4 ++-- lib/power/power_pstate_cpufreq.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/power/power_amd_pstate_cpufreq.c b/lib/power/power_amd_pst= ate_cpufreq.c index 7b8e77003f..ff63e91183 100644 --- a/lib/power/power_amd_pstate_cpufreq.c +++ b/lib/power/power_amd_pstate_cpufreq.c @@ -377,7 +377,7 @@ power_amd_pstate_cpufreq_init(unsigned int lcore_id) } if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { - RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u"= , lcore_id); + RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\= n", lcore_id); return -1; } diff --git a/lib/power/power_common.c b/lib/power/power_common.c index 8ffb49ef8f..ee0c264c8d 100644 --- a/lib/power/power_common.c +++ b/lib/power/power_common.c @@ -211,8 +211,8 @@ int power_get_lcore_mapped_cpu_id(uint32_t lcore_id, ui= nt32_t *cpu_id) lcore_cpus =3D rte_lcore_cpuset(lcore_id); if (CPU_COUNT(&lcore_cpus) !=3D 1) { - RTE_LOG(ERR, POWER, "Power library does not support lcore %= u mapping to %u CPUs", lcore_id, - CPU_COUNT(&lcore_cpus)); + RTE_LOG(ERR, POWER, "Power library does not support lcore %= u mapping to %u CPUs\n", + lcore_id, CPU_COUNT(&lcore_cpus)); return -1; } diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpuf= req.c index 890875bd93..fa9ef2aa8a 100644 --- a/lib/power/power_pstate_cpufreq.c +++ b/lib/power/power_pstate_cpufreq.c @@ -565,7 +565,7 @@ power_pstate_cpufreq_init(unsigned int lcore_id) } if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { - RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u"= , lcore_id); + RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\= n", lcore_id); return -1; } -- 2.47.0 --_000_CH3PR12MB86587D9D95781B7CB420ED00A13F2CH3PR12MB8658namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hi David, 

Thanks for the fixes, will apply and create a new tag for it.

From: David Marchand <da= vid.marchand@redhat.com>
Sent: Thursday, December 12, 2024 9:23 PM
To: stable@dpdk.org <stable@dpdk.org>; Xueming Li <xuemingl= @nvidia.com>
Subject: [23.11 2/2] power: fix log message when checking lcore ID
 
Caught while inspecting changes backported in 23.1= 1 LTS branch.
The POWER_LOG() macro in the main branch automatically appends a \n
which is not done by RTE_LOG().

Fixes: 1afa4c7c5ea6 ("power: fix mapped lcore ID")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/power/power_amd_pstate_cpufreq.c | 2 +-
 lib/power/power_common.c       &nb= sp;     | 4 ++--
 lib/power/power_pstate_cpufreq.c     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/power/power_amd_pstate_cpufreq.c b/lib/power/power_amd_pst= ate_cpufreq.c
index 7b8e77003f..ff63e91183 100644
--- a/lib/power/power_amd_pstate_cpufreq.c
+++ b/lib/power/power_amd_pstate_cpufreq.c
@@ -377,7 +377,7 @@ power_amd_pstate_cpufreq_init(unsigned int lcore_id)          }
 
         if (power_get_lcore_mapped= _cpu_id(lcore_id, &pi->lcore_id) < 0) {
-            &n= bsp;  RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u&= quot;, lcore_id);
+            &n= bsp;  RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\= n", lcore_id);
            &nb= sp;    return -1;
         }
 
diff --git a/lib/power/power_common.c b/lib/power/power_common.c
index 8ffb49ef8f..ee0c264c8d 100644
--- a/lib/power/power_common.c
+++ b/lib/power/power_common.c
@@ -211,8 +211,8 @@ int power_get_lcore_mapped_cpu_id(uint32_t lcore_id, ui= nt32_t *cpu_id)
 
         lcore_cpus =3D rte_lcore_c= puset(lcore_id);
         if (CPU_COUNT(&lcore_c= pus) !=3D 1) {
-            &n= bsp;  RTE_LOG(ERR, POWER, "Power library does not support lcore %= u mapping to %u CPUs", lcore_id,
-            &n= bsp;          CPU_COUNT(&l= core_cpus));
+            &n= bsp;  RTE_LOG(ERR, POWER, "Power library does not support lcore %= u mapping to %u CPUs\n",
+            &n= bsp;          lcore_id, CPU_CO= UNT(&lcore_cpus));
            &nb= sp;    return -1;
         }
 
diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpuf= req.c
index 890875bd93..fa9ef2aa8a 100644
--- a/lib/power/power_pstate_cpufreq.c
+++ b/lib/power/power_pstate_cpufreq.c
@@ -565,7 +565,7 @@ power_pstate_cpufreq_init(unsigned int lcore_id)
         }
 
         if (power_get_lcore_mapped= _cpu_id(lcore_id, &pi->lcore_id) < 0) {
-            &n= bsp;  RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u&= quot;, lcore_id);
+            &n= bsp;  RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\= n", lcore_id);
            &nb= sp;    return -1;
         }
 
--
2.47.0

--_000_CH3PR12MB86587D9D95781B7CB420ED00A13F2CH3PR12MB8658namp_--