From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 290D0458CA for ; Mon, 2 Sep 2024 09:11:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00743402F1; Mon, 2 Sep 2024 09:11:08 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2046.outbound.protection.outlook.com [40.107.223.46]) by mails.dpdk.org (Postfix) with ESMTP id CCF42400EF for ; Mon, 2 Sep 2024 09:11:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hpGyMK4bJGvgRV+pSt5Xofv6gCba4w3NpwNQHlTfKzvgWmStmh4z4P9gup4VntFVIy0OsxmLLQ/DNYtnvpFRBEtZIcyVZW6Ch81iB23Ndt64cMgg/XQqHTBysjSaCTnAOLok4Ea9otyygi6fVuVV/5glBtyyly53D/Sx4dHh/R1aYNVOptITDBl3v/FoprKBRPZlxUkQf3A2w4Wi0+rJbTZfnYeBjUWhqPpqxdhSedBfAmNRsii9ZNh/TonynmSYZNx2YjgBKmAeOHSS71D9Vvgqc7P+GuJ1Niz/e7X5Lor3wer5c9/7Vph/NAWDcvGDMIM6Q4UCzwHk0LXHimjtPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qjN/MW8DI+Edw3wTkdiwAouJQfDzyumG0q4nAJZD4PQ=; b=lYl81iNuSC3dFbj47AAvXiNa3WQs2Ru+fhZe9TeSY3i/XK02cAowsWYtCCeT80QvES7YdDkx/X+zOkooS4nh1iKI2yiJ/qVyetjXhlQS2E12bdfLm7ZOfCxY5PUFetu2D7pHW2EbXBrb+Kc3lyeitScR5ZCWpe+cnhpjx29cz4r/J3D6j2rvzcsTVsqkktzFfVlLPiKcyfnkI+9dKhz2DdpuKqrx2mtv6iPtSeLJeU1SX8dwGG0BbA+3uPG+Qa2k2UJelZHHDQ6sLhE6t4pYjU9ReUwJVQSd3JfJsVngzwrWETBvz9FdS97eeX9oO688BramNMxxJZ1spNvP79eXNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qjN/MW8DI+Edw3wTkdiwAouJQfDzyumG0q4nAJZD4PQ=; b=KiZh2vOTFRnQH078wFpM2e3pSCA/4NZvaoO6oZ5gYgtMl4wdY4mFiSANRwzjWeHzBuvmQKAO2nXXaU70Yl8WQg0HT6KHRl2yM/1h1OaiPauMy96M4ADY2WZxnGm775kdcOE+bz/1FG9Bbi+rr+KWUxZHmOKDhTvvr7IqZMiR2Q4jlJzyBvFG3pTu4G9pBvNW5SDGAnx4ZFtDg1MMT6oti8tQvZ4h2xn0MLtyX6i6WngcV2rAvH0UcwCYENB0xRAhOMW2AxlNCEaGu7fiB85COpXaoCuFKCkS5g+VpXre74dhjQHzQJiYiv6FhVEm082mqJJJ9hwEibuwkk45uNIXpA== Received: from CH3PR12MB8658.namprd12.prod.outlook.com (2603:10b6:610:175::8) by DS7PR12MB8202.namprd12.prod.outlook.com (2603:10b6:8:e1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.24; Mon, 2 Sep 2024 07:11:02 +0000 Received: from CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42]) by CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42%4]) with mapi id 15.20.7918.019; Mon, 2 Sep 2024 07:11:02 +0000 From: Xueming Li To: "Jiang, YuX" , "Ye, MingjinX" , "Xu, HailinX" CC: dpdk stable Subject: Re: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Topic: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Index: AQHa1EtHfPPnkrN6C0OUF0DCQUGlcrH6N38AgEeJP52AAk65AIAAVlaj Date: Mon, 2 Sep 2024 07:11:02 +0000 Message-ID: References: <20240712104528.308638-1-xuemingl@nvidia.com> <20240712110153.309690-1-xuemingl@nvidia.com> <20240712110153.309690-21-xuemingl@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8658:EE_|DS7PR12MB8202:EE_ x-ms-office365-filtering-correlation-id: 72d276bf-a112-4736-c075-08dccb1e672e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?Windows-1252?Q?NLm91NBCSv37f99K4wZoInUXJLpp7nYPDI6Lrgt2AXdpznf9dQUloejw?= =?Windows-1252?Q?sWb0xsgmKn/7gZrDMmLcb4GvKlNKeUDI4YxASkoJ1GkR12AzyP3wCve3?= =?Windows-1252?Q?A+pM5wflAk/mNoyYL6YICWgIIlL1+JBgyfEp74cYZHNveNwVMYka7pOt?= =?Windows-1252?Q?eD1uxJuE/6gaNNqqqxbVSiL5HCULoi5glnhCWkQTOLMNoDk6o5esvZaN?= =?Windows-1252?Q?r895YMJ4aGnFTyQcoQ84CKq6K9rT5/HkOw4DKqXnZFNpm0UQmubJu4yD?= =?Windows-1252?Q?ky6QV4pZqPC+tbE2o3vA363kd6yCi5I95hvM4aDPNfiGtC9p1qRruMjB?= =?Windows-1252?Q?E2WgRQjFV+kfyiWrC8z07tsMOE48oTBvuiTYfohurqBB+S9r4QoVIzlp?= =?Windows-1252?Q?yo/GnjpCSMpZnDjz4gNATYzg80bgxlKWWBKRJcAzACiDkCduaKHEJCoV?= =?Windows-1252?Q?MpuEW4ttqCzIge1aTht0QEsisLY6UnGv5m84hVhgHOZX2nRlsiPxQDPx?= =?Windows-1252?Q?Pgj88Q5e5OyHusP0Sj6vFRg5u0KcBnhXqsqSYxxtpdsQsqBgRwbfpl/r?= =?Windows-1252?Q?k6UtndBRQyRvJ9IR/o0yM1WX5h6rR7TkGUn1x+LeJ6ruOShDL45whNJ6?= =?Windows-1252?Q?60oRqPidtydVvaAv/C3YY2XML4ahb/tKRCChdIpQ+wvqQ2jKmSbrEeVO?= =?Windows-1252?Q?u4lUwEsT9qfBZUOX7ivCGty9QZpaYNeEZK+PGPATn1/eBdmAbQCS357A?= =?Windows-1252?Q?Vqu6oq4aGgPsFrMdw97BM8PQL5BtkezKKjGhYYZCDP8m+K7hZB9HdKDV?= =?Windows-1252?Q?vjysucDXh2VN30Dxpql01GeXB/9WYZykhl1yoUyVbRqWi4YnD219rUyN?= =?Windows-1252?Q?LdYjlOGPIe3jCu2rp2ntzsnW1aJarli/XnG0IxP7BXSukQQBJ2jNUzCp?= =?Windows-1252?Q?pZ3IyO51WkTWOOP2xcJ1xMDGPM1bEiISf+ff6B+yI3mW6zbwmYrR/QlT?= =?Windows-1252?Q?ioHuxjQHHR65Aub/mltL5KHs58QafZGE4ri8/dZimZ0uf2Ae/aI7lWdw?= =?Windows-1252?Q?hXQghBiplfs1e3zqLGe91v8yXjIwioIttBl77eW/n9rnKY9aD1L4lUYX?= =?Windows-1252?Q?TmpiqbieCXMuLISf307H4Kxhyq+Ec268buNNw5eerz0ItaZAGwBpUpI0?= =?Windows-1252?Q?7Z/5XhDr9qCxKL/7pXDk9p0kE2UQOITbd1IvQ12rLk5vTviaagqUAmEB?= =?Windows-1252?Q?8+bRXY2H8G1y2IutAZR4yuN98zosbbmFdH3Yo2p5fCydLrsmSPfutgKz?= =?Windows-1252?Q?B5FQ0OLbKbHAKyPOfP6eR7DH/35B2oYoj4uxAHqaVYAyliDlpkCgwZLk?= =?Windows-1252?Q?EKt9pPcs5ISNwsP2sxJ0Q1htjotGXB3SdGtm5bHaRI7yMdJ69xI4ZA+1?= =?Windows-1252?Q?fqNXZUkuyzbn9VFVpik81RqnhZvEjCGJt1GdD4TtT1v6M5nPddo5vOun?= =?Windows-1252?Q?HpJGxTNb/pxF+snmNh+mZVT48vqShA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8658.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?HthdQXGfm1VLcN/QUrNTFrYwybTk8c63FabDCLgzxx3H8GlpB/CAo1Pj?= =?Windows-1252?Q?lGmNTh7fiQO2GUAIdykDfd72wLXmpKVC7scAjc5q78Es629BVPMqcz9k?= =?Windows-1252?Q?EtpQMd7sPi8f7m0pXBEAWy5D2oAl4vawJxpaPDQwDkpj52Rb1E+uZK6R?= =?Windows-1252?Q?YmPUJPYcz1tLOv1vbeni8tz7LdPVjvzHCorydIglqEdcieTYsSszGxZ+?= =?Windows-1252?Q?gwGJzrJni0h7cmwSV/fmJgD/e+hYhR1gnnJRdP4GhAx4TI0QP/0V7Dgd?= =?Windows-1252?Q?711LXMis3+5Z2lGMGhav3YMbchnTdBsnTQfd3HmscsNBqQal/mIKbRNL?= =?Windows-1252?Q?jaIYMPJnBM/YFiWe1MoPQ2BuwFtLF8yUSw6AZJ1JPIuG+59kvlmIYUOH?= =?Windows-1252?Q?bOSerHuFnwe3oaO7+YacNEYjgXhJPCBOa0zZUjdcORO3ir3TM6TZ2TZu?= =?Windows-1252?Q?G5fgYWYDJAMQve6N9f+xUnaqIM52JBpWDc63Kx9u9rym3+kY+EZhDDYI?= =?Windows-1252?Q?HMFb7QsOi/EoexigSnUWwt0/GAoi2sFk8LSS92UP6bzTKqTH7fy5Rk12?= =?Windows-1252?Q?iVkCSK/9rYKdOBfJ+rmJj0VTA4lL/RHnvF5tXF42CCRrLFuXWYsM2YvL?= =?Windows-1252?Q?7QNq2d+/xhvrvchI2SAKv0kO7AldYpaRWfDaEzC/5h3H5qxtx1dZFl2k?= =?Windows-1252?Q?NKSZQGmVkx2CzfuMZ8JQ2cibd0TdT+TwRbMJ2idFAVQzru3ZMqcuCWfA?= =?Windows-1252?Q?MjsBfuMdhpeR9eV7AHk44m4cH0KAl1I4hIpKxFYws+AqJHNra9M2GIJM?= =?Windows-1252?Q?pIIYRXvU+WY7zV6Snw66W0ed05eTGvqbaIuz9sHBjLgkEAob2UEVuHs1?= =?Windows-1252?Q?cM5gRUP6sWjNL0uKscvOrAFU5TnjQWw3++SIoF9En6CpfLIIPVP7K6OH?= =?Windows-1252?Q?WgGhmQjKg6LAFTPwik2V/cyG5SHkZpC7yU+K/vj2MA5iG1pNlvv8OgSP?= =?Windows-1252?Q?68Nb7W3TxqpH2gw+KoZDIWsJ+YxYCmji+MefH00e0sVESI3wr853LT+g?= =?Windows-1252?Q?o7vPBjjAcegATGcxKO6EPTP2fn0lrajt1X3Q2aglJuVq00iT3imE1zuo?= =?Windows-1252?Q?KBL0x5cmNXw1vHvSB4WNcOJ0B5k0+OtXzeZLfaqaNaKTUyCR6wihiGFz?= =?Windows-1252?Q?rUBRODrJdvBP7Rwdc7hpjUhD6NLnq1ecFZZXgZXiigh59hjXWo8WjRKg?= =?Windows-1252?Q?93qEvMfTiJdnS5f4HaQHxsTHGBVmbxstQjrhAAaHKYIAqxX6gxQCqwnS?= =?Windows-1252?Q?kxpwkVgP3xgbgO1jPcJyh6SphmakObyBE7eQsmleZ/ayrWjhN2WDTYZe?= =?Windows-1252?Q?qcyWOmlsWWME0eaWMFGpMY5L+oJ+62t1YnKpMO9XiiOx8QdPgvnMEl64?= =?Windows-1252?Q?TrhC9tLCcdtxFin7tF0er1SISxZ+Ad6zkCXm6twrjJOqzRbdxnqFd+ge?= =?Windows-1252?Q?dR3DHunRuKvYWVgEudgI4UWnTiPEgkEpWBWRfFOhIAiv/gg5cLDRT/Kt?= =?Windows-1252?Q?enwHeelcrx9tZ4mirWKcLu3H7c1xjAwhTXOHBeCP18aYsJCtj1zWTZ7Q?= =?Windows-1252?Q?2kn6kjs7oF5UO2ta/LgMiAl5bBJubNXcSYD7bm5qJpRY3002Ot+PcqRZ?= =?Windows-1252?Q?WhPNWFc41UaLyAWHtXcGSzBhJPotRmeT?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB865888F473E97E3900E80CCFA1922CH3PR12MB8658namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8658.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72d276bf-a112-4736-c075-08dccb1e672e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2024 07:11:02.0092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xRLfu9UdgCPgaBH0YL8X33WQlzd3IZdEtY21/d5KupQc0tY2rbeSZ2kZp27C+GTKPeA7ze+40+m36aIWgaxmfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8202 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_CH3PR12MB865888F473E97E3900E80CCFA1922CH3PR12MB8658namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Thanks for clarifying, patch queued to 23.11.3. Best regards, Xueming ________________________________ From: Jiang, YuX Sent: Monday, September 2, 2024 10:01 AM To: Xueming Li ; Ye, MingjinX ;= Xu, HailinX Cc: dpdk stable Subject: RE: patch 'bus/vdev: revert fix devargs in secondary process' has = been queued to stable release 23.11.2 Hi Xueming, Yes, we need the fix. It should be backporting to 23.11.x, since the previous commit =93bus/vdev:= fix devargs in secondary process=94 which is also backporting to 23.11.1 t= hat cause bug 1450 =96 Regression: vdev device not setup in secondary proce= ss (dpdk.org) exists in 23.11= stable branch. This bug=92s resolution is the fix (http://git.dpdk.org/dpdk/commit/?id=3D2= 2ce39b3aa) in main branch, so pls schedule this fix patch to 23.11.3. root@virtio-tester-217:~/jiangyu/LTS/dpdk# git show 6148604a43 commit 6148604a438aad21e5d74f414976666b370582c1 Author: Mingjin Ye mingjinx.ye@intel.com Date: Fri Sep 1 07:24:09 2023 +0000 bus/vdev: fix devargs in secondary process [ upstream commit 6666628362c94a0b567a39a0177539c12c97d999 ] When a device is created by a secondary process, an empty devargs is temporarily generated and bound to it. This causes the device to not be associated with the correct devargs, and the empty devargs are not released when the resource is freed. This patch fixes the issue by matching the devargs when inserting a device in secondary process. Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct") Fixes: a16040453968 ("eal: extract vdev infra") Signed-off-by: Mingjin Ye mingjinx.ye@intel.com Acked-by: Anatoly Burakov anatoly.burakov@intel.com Best regards, Yu Jiang From: Xueming Li Sent: Saturday, August 31, 2024 10:51 PM To: Ye, MingjinX ; Xu, HailinX Cc: dpdk stable Subject: Re: patch 'bus/vdev: revert fix devargs in secondary process' has = been queued to stable release 23.11.2 Hi Hailin, This patch was originally queued to 23.11.2 list, but removed per Mingjin's= request. If we do need the fix, let's schedule it to 23.11.3. Regards, Xueming ________________________________ From: Ye, MingjinX > Sent: Wednesday, July 17, 2024 10:21 AM To: Xueming Li > Cc: dpdk stable > Subject: RE: patch 'bus/vdev: revert fix devargs in secondary process' has = been queued to stable release 23.11.2 Hi, Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything. Thanks, Mingjin > -----Original Message----- > From: Xueming Li > > Sent: Friday, July 12, 2024 7:02 PM > To: Ye, MingjinX > > Cc: dpdk stable > > Subject: patch 'bus/vdev: revert fix devargs in secondary process' has be= en > queued to stable release 23.11.2 > > Hi, > > FYI, your patch has been queued to stable release 23.11.2 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 07/14/24. So please shout= if > anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Queued patches are on a temporary branch at: > https://git.dpdk.org/dpdk-stable/log/?h=3D23.11-staging > > This queued commit can be viewed at: > https://git.dpdk.org/dpdk-stable/commit/?h=3D23.11- > staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b > > Thanks. > > Xueming Li > > > --- > From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > From: Mingjin Ye > > Date: Thu, 14 Mar 2024 09:36:28 +0000 > Subject: [PATCH] bus/vdev: revert fix devargs in secondary process > Cc: Xueming Li > > > [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > > The ASan tool detected a memory leak in the vdev driver alloc_devargs. Th= e > previous commit was that when inserting a vdev device, the primary proces= s > alloc devargs and the secondary process looks for devargs. This causes th= e > device to not be created if the secondary process does not initialise the= vdev > device. And, this is not the root cause. > > Therefore the following commit was reverted accordingly. > > After restoring this commit, the memory leak still exists. > > Bugzilla ID: 1450 > Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process") > > Signed-off-by: Mingjin Ye > > --- > drivers/bus/vdev/vdev.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args) > return devargs; > } > > -static struct rte_devargs * > -vdev_devargs_lookup(const char *name) > -{ > - struct rte_devargs *devargs; > - char dev_name[32]; > - > - RTE_EAL_DEVARGS_FOREACH("vdev", devargs) { > - devargs->bus->parse(devargs->name, &dev_name); > - if (strcmp(dev_name, name) =3D=3D 0) { > - VDEV_LOG(INFO, "devargs matched %s", dev_name); > - return devargs; > - } > - } > - return NULL; > -} > - > static int > insert_vdev(const char *name, const char *args, > struct rte_vdev_device **p_dev, > @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, > if (name =3D=3D NULL) > return -EINVAL; > > - if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) > - devargs =3D alloc_devargs(name, args); > - else > - devargs =3D vdev_devargs_lookup(name); > + devargs =3D alloc_devargs(name, args); > > if (!devargs) > return -ENOMEM; > -- > 2.34.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2024-07-12 18:40:18.570682691 +0800 > +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch 202= 4- > 07-12 18:40:14.356594197 +0800 > @@ -1 +1 @@ > -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00 > 2001 > +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > @@ -4,0 +5,3 @@ > +Cc: Xueming Li > > + > +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > @@ -20 +22,0 @@ > -Cc: stable@dpdk.org --_000_CH3PR12MB865888F473E97E3900E80CCFA1922CH3PR12MB8658namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
Thanks for clarifying, patch queued to 23.11.3.

Best regards,
Xueming
From: Jiang, YuX <yux.ji= ang@intel.com>
Sent: Monday, September 2, 2024 10:01 AM
To: Xueming Li <xuemingl@nvidia.com>; Ye, MingjinX <mingjin= x.ye@intel.com>; Xu, HailinX <hailinx.xu@intel.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: RE: patch 'bus/vdev: revert fix devargs in secondary proces= s' has been queued to stable release 23.11.2
 

Hi Xueming,

 

Yes, we need the = fix.

It should be back= porting to 23.11.x, since the previous commit =93bus/vdev: fix devargs in s= econdary process=94 which is also backporting to 23.11.1 that cause bug 1450 =96 Regressio= n: vdev device not setup in secondary process (dpdk.org) exists in 23.1= 1 stable branch.

This bug=92s reso= lution is the fix (http://git.dpdk.org/dpdk/commit/?id=3D22ce39b3aa) in main branch, = so pls schedule this fix patch to 23.11.3.

 

root@virtio-teste= r-217:~/jiangyu/LTS/dpdk# git show 6148604a43

commit 6148604a43= 8aad21e5d74f414976666b370582c1

Author: Mingjin Y= e mingjinx.ye@intel.com

Date:  = Fri Sep 1 07:24:09 2023 +0000

 

   = ; bus/vdev: fix devargs in secondary process

 

   = ; [ upstream commit 6666628362c94a0b567a39a0177539c12c97d999 ]

 

   = ; When a device is created by a secondary process, an empty devargs is

   = ; temporarily generated and bound to it. This causes the device to not

   = ; be associated with the correct devargs, and the empty devargs are not

   = ; released when the resource is freed.

 

   = ; This patch fixes the issue by matching the devargs when inserting a

   = ; device in secondary process.

 

   = ; Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct&q= uot;)

   = ; Fixes: a16040453968 ("eal: extract vdev infra")

 

   = ; Signed-off-by: Mingjin Ye mingjinx.ye@intel.com

   = ; Acked-by: Anatoly Burakov anatoly.burakov@intel.com<= /span>

 

Best regards,

Yu Jiang

 

From: Xueming Li <xuemingl@nv= idia.com>
Sent: Saturday, August 31, 2024 10:51 PM
To: Ye, MingjinX <mingjinx.ye@intel.com>; Xu, HailinX <hail= inx.xu@intel.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: patch 'bus/vdev: revert fix devargs in secondary proces= s' has been queued to stable release 23.11.2

 

Hi Hailin,

 

This patch was origina= lly queued to 23.11.2 list, but removed per Mingjin's request. If we do nee= d the fix, let's schedule it to 23.11.3.

 

Regards,

Xueming

From: = Ye, MingjinX <mingjinx= .ye@intel.com>
Sent: Wednesday, July 17, 2024 10:21 AM
To: Xueming Li <x= uemingl@nvidia.com>
Cc: dpdk stable <stab= le@dpdk.org>
Subject: RE: patch 'bus/vdev: revert fix devargs in secondary proces= s' has been queued to stable release 23.11.2

 

Hi,

Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything.

Thanks,
Mingjin

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Friday, July 12, 2024 7:02 PM
> To: Ye, MingjinX <<= span style=3D"font-size:11.0pt">mingjinx.ye@intel.com>
> Cc: dpdk stable <stable@dpdk.org>
> Subject: patch 'bus/vdev: revert fix devargs in secondary process' has= been
> queued to stable release 23.11.2
>
> Hi,
>
> FYI, your patch has been queued to stable release 23.11.2
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-= stable yet.
> It will be pushed if I get no objections before 07/14/24. So please sh= out if
> anyone has objections.
>
> Also note that after the patch there's a diff of the upstream commit v= s the
> patch applied to the branch. This will indicate if there was any rebas= ing
> needed to apply to the stable branch. If there were code changes for > rebasing
> (ie: not only metadata diffs), please double check that the rebase was=
> correctly done.
>
> Queued patches are on a temporary branch at:
> https://git.dpdk.org/dpdk-stable/log/= ?h=3D23.11-staging
>
> This queued commit can be viewed at:
> https://git.dpdk.org/dpdk-stable/commit/?= h=3D23.11-
> staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
>
> ---
> From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00
> 2001
> From: Mingjin Ye <<= span style=3D"font-size:11.0pt">mingjinx.ye@intel.com>
> Date: Thu, 14 Mar 2024 09:36:28 +0000
> Subject: [PATCH] bus/vdev: revert fix devargs in secondary process
> Cc: Xueming Li <xuemingl@nvidia.com>
>
> [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ]
>
> The ASan tool detected a memory leak in the vdev driver alloc_devargs.= The
> previous commit was that when inserting a vdev device, the primary pro= cess
> alloc devargs and the secondary process looks for devargs. This causes= the
> device to not be created if the secondary process does not initialise = the vdev
> device. And, this is not the root cause.
>
> Therefore the following commit was reverted accordingly.
>
> After restoring this commit, the memory leak still exists.
>
> Bugzilla ID: 1450
> Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process&= quot;)
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
>  drivers/bus/vdev/vdev.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)=
>        return devargs;
>  }
>
> -static struct rte_devargs *
> -vdev_devargs_lookup(const char *name)
> -{
> -     struct rte_devargs *devargs;
> -     char dev_name[32];
> -
> -     RTE_EAL_DEVARGS_FOREACH("vdev", de= vargs) {
> -           &nb= sp; devargs->bus->parse(devargs->name, &dev_name);
> -           &nb= sp; if (strcmp(dev_name, name) =3D=3D 0) {
> -           &nb= sp;         VDEV_LOG(INFO, "de= vargs matched %s", dev_name);
> -           &nb= sp;         return devargs;
> -           &nb= sp; }
> -     }
> -     return NULL;
> -}
> -
>  static int
>  insert_vdev(const char *name, const char *args,
>            = ;    struct rte_vdev_device **p_dev,
> @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, >        if (name =3D=3D NULL)
>            = ;    return -EINVAL;
>
> -     if (rte_eal_process_type() =3D=3D RTE_PROC_P= RIMARY)
> -           &nb= sp; devargs =3D alloc_devargs(name, args);
> -     else
> -           &nb= sp; devargs =3D vdev_devargs_lookup(name);
> +     devargs =3D alloc_devargs(name, args);
>
>        if (!devargs)
>            = ;    return -ENOMEM;
> --
> 2.34.1
>
> ---
>   Diff of the applied patch vs upstream commit (please doubl= e-check if non-
> empty:
> ---
> --- - 2024-07-12 18:40:18.570682691 +0800
> +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch &= nbsp;     2024-
> 07-12 18:40:14.356594197 +0800
> @@ -1 +1 @@
> -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00
> 2001
> +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00
> 2001
> @@ -4,0 +5,3 @@
> +Cc: Xueming Li <xuemingl@nvidia.com>
> +
> +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ]
> @@ -20 +22,0 @@
> -Cc: stable@dpdk.org

--_000_CH3PR12MB865888F473E97E3900E80CCFA1922CH3PR12MB8658namp_--