From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C05414650E for ; Sat, 5 Apr 2025 09:38:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94CFA400EF; Sat, 5 Apr 2025 09:38:35 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2081.outbound.protection.outlook.com [40.107.220.81]) by mails.dpdk.org (Postfix) with ESMTP id E002C400EF for ; Sat, 5 Apr 2025 09:38:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YA3KjrOLDjuibHuEVBNG333vKNTjKB6xkSCPsifVoNTx16LMq6XAXs7bAvse2KEW3jg3XfUCx62JYAELwTAZWKzFleCepUOgORnhMMfwrVIJeYkR0xTrbxoTJ55SEaBLx0l1OYeqxNIAQmWfdygTP/uo8HSCcbXbHHtIcxCKgGBNXN8n8bHSe8OHjfELQPLQr6YpXmtbaAEWx73PQDfv+IqTA24G9yQP4ZZFeaqYe3PlohUBcI6W80yuNJFdagJwgoi9pgE0cYbbGkXXrDANj/YF2GZcYeoFB6ryb7pyGUO38+dHIyKPI9qqgY4RzJqEF2rkA8ay5JF3BkrPfx6rYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QimDeMjkveH5yXQ0ELZBFM3VUUKbIVOyA7Xfan7pjZ8=; b=cPVsQlrdthBuVqgqNFIATUoHvwzvWA/2fegXI3bEFTW2mL+uEhXzCcveEZTYTZlGwWtFEjxu6CE45o2uIph/48T6h1ZQkLuN9Nn3aHGqCZuZnl4ENigR6Xc8Wl+uGt55LhkOQ6ayaYGlI/ns0r43AVQyor03Ml+J+wb8ueOLYwUGL3+nbJQEjY0zs9VOmuA/kbAT9d1W1YIK8bok0Qkfk2f8itkSFzJC7MOJC2B13DhF/iOJ2sKoOuRdz2wHeSXDWlmRpx+wEwMqVBRT3lThw9yyxsLH54sY2P5qn9tL3KaftsgDU4VGlS4wjOPklXsTYFoLVu7DkeaQRygsg0KnNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QimDeMjkveH5yXQ0ELZBFM3VUUKbIVOyA7Xfan7pjZ8=; b=ZBXVvNNnoLhim88Dbfb33F9rf/0G5icGWUfLsoMYI4LiCRqYgOJ0DahMRv569UztR6hpAOcvoQXeOhbp2ln96A1HwZNjxTGDe3NCfaeAOL3ryIZDXNm6jtwm72cXhtiNfDa7dueCqdzsnGYL5rwCuY1dEFo/HRnZgEKhw3WTBNvwaJg/nhLnZi518Ne3a3TQ+QZe1KBnVjEnVfoWIZxJVypMw4ATQvE3eHuvuZs4wiGqToG0mR5g2EXgz1s5+oFQDsemNyR2tWgXVQgwom38/yc6TfqvOvsvtIdJAj2wHSRjjZSGh8wY7EsN3iH9FDOSz38XYPwbUId9CqsD/6lx9w== Received: from CH3PR12MB8658.namprd12.prod.outlook.com (2603:10b6:610:175::8) by PH7PR12MB9174.namprd12.prod.outlook.com (2603:10b6:510:2ed::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Sat, 5 Apr 2025 07:38:29 +0000 Received: from CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42]) by CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42%4]) with mapi id 15.20.8534.048; Sat, 5 Apr 2025 07:38:29 +0000 From: Xueming Li To: Stephen Hemminger , "stable@dpdk.org" Subject: Re: [PATCH 23.11] examples/ptpclient: fix message parsing Thread-Topic: [PATCH 23.11] examples/ptpclient: fix message parsing Thread-Index: AQHbgvIEK8GHLlM/T02+K4BeoETnT7OU9TRC Date: Sat, 5 Apr 2025 07:38:29 +0000 Message-ID: References: <20250219171612.506172-1-stephen@networkplumber.org> In-Reply-To: <20250219171612.506172-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8658:EE_|PH7PR12MB9174:EE_ x-ms-office365-filtering-correlation-id: 3a91fad1-fac8-47c9-cdb4-08dd7414dbad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018|13003099007|7053199007|8096899003; x-microsoft-antispam-message-info: =?us-ascii?Q?O3tzpqyth+Bwsy/GckzuyW4ZF6IDjE54/zZ/+LD+pcJ5X6Qehxqjgqn9f6Sq?= =?us-ascii?Q?uKjW+vtqWZZUZThFE+CM5E2NiQhFu+2EmhVw3qYZvWGT8GFgtN5AZCQrB3dF?= =?us-ascii?Q?M5slzhCenLBRdNl5Orc5Ipd6FPqd2UIPV/erpuI1CMJ1BeZgx97XfE8k0uBC?= =?us-ascii?Q?4vwpuANQRdvbaqY4ETuoBJKpOEdS23FfAyppsj/L/lYpPTLx4QYsJBr4HJCE?= =?us-ascii?Q?4Dpp3LvZJ1RHU7Z4Gymx1sSkmgkSg4QjMzNfB1rGnESaKFUXxuwwxNyA7Jea?= =?us-ascii?Q?gYgV6QnDiqBqiyJISpq8FoJnPs/tojLS4i0hyxvhj+XliDuUDW7GDJb6M0EO?= =?us-ascii?Q?hP2aLGTylPKRw7zciAGXgFJrKoNDAoKhUwd1l1WhBU3Pw6KSumlT01Y/1lU3?= =?us-ascii?Q?wGqO6LTHlRas6ITXN+2InhqeJ/blAnpPz9VJRJvbZZCBdA89y0C9/K0EnWlg?= =?us-ascii?Q?+TCj+NO6ho6Nr9jEUrLqXY/K7hz39lUGpUG2QwENL+sqOrtHNH3s0dtwbTDC?= =?us-ascii?Q?6TlsVJKdn+3TNFfM4/YoBHIHC6BBFADoF+AHsYMi9Oznj5AS/DaKT9Fg2fYI?= =?us-ascii?Q?9KMCIQHRcbdAl6bfXyii9vE+NbOAcjL+OcPRzzXX1QSNfhDHQXmSNOKyA4Oo?= =?us-ascii?Q?djrC+63OsImTuCtItEoX/iv3jU5ucopdOOrGcY/DvgReKh7jkuU3jNf3Ox/l?= =?us-ascii?Q?zE0mrLsRDeFCDtT7fctmF953tO9H/cYUgDvsQKcBDQkF4WuCMAtnbZSoWXxW?= =?us-ascii?Q?0xg+epvIGCIh21oNI4PRYGswNvBg3X5dfgo8NLxQgbLh4ZMB79lzg2IBbsGt?= =?us-ascii?Q?3pypsVKZg8RYEtaWHvsY/z3twGV4XWmaw64XEGk2uYmxcqNt2v14w4M5YnPI?= =?us-ascii?Q?FU35/x78AfUl5HZuOoCuOJ/sx1QXHOtTUrW/gs9BTQIrCCLDSEjBwoGTVDUS?= =?us-ascii?Q?j+2HvimwIdnTKzVtQtJwyVnKt/qdL2UJ8BXfUxWmNmOg6NPaJQ9ODQ3f48JX?= =?us-ascii?Q?IE/efaF+AR0Dq0rELBEPbQXKviqm/whyC4CFNwXJE4L3d/QbOzkfP0+McSBE?= =?us-ascii?Q?v3hX5mc7H+8gyPfV+4IBvvWXyfZ82FxlPS74yakteVa5r7gmqk6tFh6f/91/?= =?us-ascii?Q?553xXcvXdIXJrdg4PElMfg1KgfyPyUluBoWZ06RbfrwAJxCD8+2MOkiq7zNO?= =?us-ascii?Q?xWNoaIhj3Qe6ODyYqHZUR9OQIe00YAX6XiAeyGlSJJylaHEMtRZAbYVmxjwm?= =?us-ascii?Q?KYQdM5TK6qNnTZupNh+Vhq1jalz1nmNrQNVI2XgbeDZG7r0dAiEQmYutAv7z?= =?us-ascii?Q?a1o7naUPMvMt+85g5EyV5UqyXCi9mzZ4ShE4nxMFI6zfMwjATrqFoudOtzB9?= =?us-ascii?Q?ApM2i5Ssjq+hWV+8cAuWMqodviRkuIZWf5a5Y/QQgQu4orrN2FtdqohnYd8O?= =?us-ascii?Q?23flvwW/6zZbRLj5MQg9oZIYzRIjINBH+6sedssIniu9nTvHtHnkigmRrilW?= =?us-ascii?Q?Q5jH8wXjSN7C/Kg=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8658.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018)(13003099007)(7053199007)(8096899003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kR+l/7K2Rw7sH7Qg8Nl4bO2wG5nxyyHpz/wQf6zCTcmYgudPjG9m6O1mNEpm?= =?us-ascii?Q?6L9WaZcmwzlZDrPLOtzQwjAz6W94J7k31mMtCc2rtMyz70T6MLfiosudqvCI?= =?us-ascii?Q?sznqLI1lOIKA+Z0rb4v6bVqHtkSgH55zyWyCJTTglPsdwh4BRyexiP2ZiAkP?= =?us-ascii?Q?mV7HoSlsL8AMNTw9xt9JSkH7EyrmOW6cekto6RrpkqfPF2CA5H5xt0Mr0mHq?= =?us-ascii?Q?vIQI9+/1uJmMYid17BBaIioFS7LeBFRsn3NNbMB3bFjjGldDj6QosSzKEJMU?= =?us-ascii?Q?Cy7tvPnVh9I89niaNBU0GZqgEm9ttIpTwGfmPdiv7T5FFq3UrHvd1nsBV2d0?= =?us-ascii?Q?4qLDEjccy0PDJKbrNkKIkFWYfe+RmeuWFdvxUk+Qhapr1jlOpr9zrdZ0JRsr?= =?us-ascii?Q?CrVmXgZxPJBOIdC/+JYjH2z8EoHa8wI6GLiTxC/g3/18NeoU6rNQs4LDV1J+?= =?us-ascii?Q?HnOeg+uDIcPziCGEkpQqLTyp+4Y3CZtEU9rxQxLBQ3lm5FKYzdDG7kkBCoq8?= =?us-ascii?Q?Y6gj/n4hn3eyd9tmJty1pht4psW29+vvV9oqwgEcMrmWlcxxJLm5s9MdBaQE?= =?us-ascii?Q?sjp1A5uBoAIlgtzuhUTAX7FRT1TLw3q+242RBzIhLmuj3GU3769n3zU1yE08?= =?us-ascii?Q?Q4vwtAy1IEXvCISUDJL4mZpvAxJYQKQKaUT32k5bLL6T+S3pgKxlOKkzYVkL?= =?us-ascii?Q?4cMm13nuT4Aj+ihkNB/qMOoFPmmyFJqxUo9EgD2vaOVFcg8Ahd6guY3VOe6L?= =?us-ascii?Q?Qj2QB81B9t8+XKabhIeDHeq5TIVcRE2s4R+pvRoSmakb3x9l6aYSQFPBmlC1?= =?us-ascii?Q?RSuNGzwuzsWZPET9FG42ROFkn4T+UgGPcxPEMS77+8gZOXHT4PaObuhHstil?= =?us-ascii?Q?fXCy64CluITSrD22Jhg60EgOh4l3wJz6ic9HHXxoPQYU9reIfNSTDa9lctPK?= =?us-ascii?Q?U+ZExLdZ0oJubOTKtQKnQsnC/Gyf0OwLE6ld4wJPS8yosBKoc6Tw778Nh631?= =?us-ascii?Q?R0gYnfNwy/6ZmkfzGl/Qb1eovmwKNomnhCz+zIIJKzYSrIfg/pPAf/oiSW+8?= =?us-ascii?Q?WEW7fgQBr+l2sIT/o1gXGBwPQcGj4QxXGwXo81S4Kp3PqbvJwna/y/SW0t4K?= =?us-ascii?Q?ZKVKOQATZ7aCbPA2XGHCPH8swA7fVUuvt8dk0Oiva3BjybPM/S74A4UR/aR1?= =?us-ascii?Q?mQTY1duydHi3kDmHWrEm//y7FPb+9D9slGoKtSzuDgNJOLKJqRZjBurcBih9?= =?us-ascii?Q?hotu4Iet2jU6/9J5dnfPSE0cXxb8PyzafByKDstCs3RwxrEBot7nVrqeP5CP?= =?us-ascii?Q?FfBwDxPZOWof2qHkbO0vcln42PA8bXoZyMSAW92lD8/sf48M4ru7QoPDMP+1?= =?us-ascii?Q?ubYu9f9+OyTsAFD49ldLqO/SWL67/cyF4Mc0Q3tm9WUdrkBUaUoOwIuA32Aj?= =?us-ascii?Q?ioZ+8Or40ux67RONRJzBVVtwqOkZQjvQP4Zbj2Wvt9TrJdryfS3hLClV6mgC?= =?us-ascii?Q?GZvy4FeGaapSkEfjW+DlsEyv57g1xXTQ6Qj3e7JYTTosPn8ki+YFRJ81J4BH?= =?us-ascii?Q?rNyG77kLWtv+ViuTL4iStYtT6o6vwVUgV3fhSAMj?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB8658C393F74857B2BE616926A1A82CH3PR12MB8658namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8658.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a91fad1-fac8-47c9-cdb4-08dd7414dbad X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2025 07:38:29.0211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OkTZ7fl4tlbcIQaxwAS6Y+SyNsCtG2Wf8rG58N++Z/7CxtUdm8nFe3wKR7SlCh6EA2eeQNfgGgAnty+PO0rf1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9174 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_CH3PR12MB8658C393F74857B2BE616926A1A82CH3PR12MB8658namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, patch queued to 23.11.4 release staging Regards, Xueming ________________________________ From: Stephen Hemminger Sent: Thursday, February 20, 2025 1:16 AM To: stable@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 23.11] examples/ptpclient: fix message parsing [ upstream commit 19630bd0d735badb06143086d4f1c50d726b7bad ] Calling memcmp on same structure will always be true. Replace with same conditional used elsewhere. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Signed-off-by: Stephen Hemminger --- examples/ptpclient/ptpclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.= c index cdf2da64df..92b54f240e 100644 --- a/examples/ptpclient/ptpclient.c +++ b/examples/ptpclient/ptpclient.c @@ -365,7 +365,7 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, = uint16_t rx_tstamp_idx) ptp_data->ptpset =3D 1; } - if (memcmp(&ptp_hdr->source_port_id.clock_id, + if (memcmp(&ptp_hdr->master_clock_id, &ptp_hdr->source_port_id.clock_id, sizeof(struct clock_id)) =3D=3D 0) { -- 2.47.2 --_000_CH3PR12MB8658C393F74857B2BE616926A1A82CH3PR12MB8658namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Thanks, patch queued to 23.11.4 release staging

Regards,
Xueming
From: Stephen Hemminger <= ;stephen@networkplumber.org>
Sent: Thursday, February 20, 2025 1:16 AM
To: stable@dpdk.org <stable@dpdk.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 23.11] examples/ptpclient: fix message parsing
 
[ upstream commit 19630bd0d735badb06143086d4f1c50d= 726b7bad ]

Calling memcmp on same structure will always be true.
Replace with same conditional used elsewhere.

Link: https://pv= s-studio.com/en/blog/posts/cpp/1183/

Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client"= )

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 examples/ptpclient/ptpclient.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.= c
index cdf2da64df..92b54f240e 100644
--- a/examples/ptpclient/ptpclient.c
+++ b/examples/ptpclient/ptpclient.c
@@ -365,7 +365,7 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, = uint16_t rx_tstamp_idx)
            &nb= sp;    ptp_data->ptpset =3D 1;
         }
 
-       if (memcmp(&ptp_hdr->source_po= rt_id.clock_id,
+       if (memcmp(&ptp_hdr->master_cl= ock_id,
            &nb= sp;            &= ptp_hdr->source_port_id.clock_id,
            &nb= sp;            sizeo= f(struct clock_id)) =3D=3D 0) {
 
--
2.47.2

--_000_CH3PR12MB8658C393F74857B2BE616926A1A82CH3PR12MB8658namp_--