From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9790F458B9 for ; Sat, 31 Aug 2024 16:51:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DB6840272; Sat, 31 Aug 2024 16:51:05 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2085.outbound.protection.outlook.com [40.107.100.85]) by mails.dpdk.org (Postfix) with ESMTP id 2173540263 for ; Sat, 31 Aug 2024 16:51:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F4KX1G4JZYnP4Ym7XjCGt0epblexqdkhXBPJ7rP82rTGxSILcY2DHjDgga+xtlBxJapO6LDjlohD7aOxt+QcGXrcUovZMSsKSnhJWTbUxZK/DEL61S/zgNYpKa3qA3vAswB5ll/BwpSTUTi6ZrW4w8XeAOtHDj2VvCOyB1jLoPQnWJjxGG1cc3V70G11lOEqJFethYSUohzQW+QcOlkRiC6Mt0ZkkBDQ4d6XCe4+8gQHt1DCZtl0YMeieh5yuXVWCjELmAOU8Wm0TSdsxhfz8ZMXRrJxtbRb9FLmKMMnRXr95dL1KZL7a+Eq/RsgYTiHA0OrJ4MEsqmSitrMxMXR5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sZ35xK6i+CLW0gCuFJX9nRpSPhTgndiRat1QLAZZ1FQ=; b=EZhUQ894SW8hvvWEvnHX14hm3f5cTMpuw9HoF4ENPtpb/WIARtP5xff1vtWmAcOkDOcSjqffkg2OSoNrS2A0N9OKeQBSIDqa2D0XysrESuZFrqBStNoVBdvtvVFv3kDQeWF5n/5DSywouLk1RLTWimlWPmFuwgoh2H/gcMjOBZ2L2RxDF7rcxAugqHAi59Q29TFroQr8ble+nIwLTFMDFTXmZ4fK+YhuvKPiHqGrQdD0LK49qeKBvR0IWNhj+pG6E1/noNVadhw0BfShqEmpZIM32oVjg9RfYMe3DwwyAsLzYjeRZ8YXoB5M6BQ8frou3Hv5wfbmTdo9/KlqXMV7yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sZ35xK6i+CLW0gCuFJX9nRpSPhTgndiRat1QLAZZ1FQ=; b=gA3llx6dUK369FlaBb7ZB/pmW6eU5QAwJESEOCkQXArC5TVM32qoKz+8KGyBzXtlJoR631N1zlShniF100ytXfhsNGnVOnnxIEepsHtySKS3Stuod6nZQZK+dF3KpPuvSnFOJKajbpx5nrcpOWow3CDGrGt2EEf4GKNyDK+MqTS0ZJfFBckmbAbM13b0WN5tFdO0sfP9Y5ZAWgXQCxXRFatYwh1JZbZIaJxIdBkuel+QzJjdbnVKfQxWsOD6Ygcz74TpjAjMo9jCmSD4htOMr3ta185t5FebgmVHEP4qhxyb/hmHRYF2sY/Td2/yohzXVTFf2nb1JVT4QUT0h8aNlw== Received: from CH3PR12MB8658.namprd12.prod.outlook.com (2603:10b6:610:175::8) by SA1PR12MB6917.namprd12.prod.outlook.com (2603:10b6:806:24c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.20; Sat, 31 Aug 2024 14:51:01 +0000 Received: from CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42]) by CH3PR12MB8658.namprd12.prod.outlook.com ([fe80::d5cc:cc84:5e00:2f42%4]) with mapi id 15.20.7918.019; Sat, 31 Aug 2024 14:51:01 +0000 From: Xueming Li To: "Ye, MingjinX" , "Xu, HailinX" CC: dpdk stable Subject: Re: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Topic: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Index: AQHa1EtHfPPnkrN6C0OUF0DCQUGlcrH6N38AgEeJP50= Date: Sat, 31 Aug 2024 14:51:01 +0000 Message-ID: References: <20240712104528.308638-1-xuemingl@nvidia.com> <20240712110153.309690-1-xuemingl@nvidia.com> <20240712110153.309690-21-xuemingl@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8658:EE_|SA1PR12MB6917:EE_ x-ms-office365-filtering-correlation-id: 90cc5972-33fc-44e5-f793-08dcc9cc54ae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?QYtVPP5gQo/u22pJ7PGKjF4bMYPOw6Ft3WsUyaOo4rasmAIi6rzmSUIKKuZD?= =?us-ascii?Q?AU/feXjTj6QdP7h/RHTWH7FKyNi8PVLDYV4FglTwwzX0G3mPT0ej0JetiZHX?= =?us-ascii?Q?jPfUWXyfTn/cZ+9KFFDRtYYQHdb7nz8DzM7FmMj+YO4SaLWmcB5MXOMXOpxr?= =?us-ascii?Q?csBbpMqI5CxH/tk5bXfWbj75pk/XMOKz02EKPNiFitVb8YyfIJGHz4/sBxuY?= =?us-ascii?Q?n+siSnUNYc0PGBJqwlZ7938a3d84nZlgp0eyklFzziBubSNMoWNMmk1iBOjd?= =?us-ascii?Q?N+ZLh7FwhHducSq4/vBtWTBAy45MsrCKNJCFiGMdXacMpeAgdscUWDQSXb60?= =?us-ascii?Q?pcHGK8fkaHKMdHhlw0XVWZNtSS1sHW+asvM2OAXKYbi7SKQrDsP4YwnRPZwg?= =?us-ascii?Q?yaBC8PbJH0rX9rokNw7PiySgaiLUtXKbWhAMILyuPO8CjCp+7gXqTbtcSZ+O?= =?us-ascii?Q?818S/kXcStK/G2pSB3hLJoZferg7Kp5tugIxFPNjbdXABueKLr3JNm9mPxwu?= =?us-ascii?Q?BFYEUUoid8DlbQ4Wanjl08UQFyUZAlyYG4XujPbTaaCQseXp6NUQmJDwZFFh?= =?us-ascii?Q?8KIxdpbe52EL1clgPezIjgEPKIXrstJ5wjMqUC48xFqUtFhwmoq/364DGn1e?= =?us-ascii?Q?h7LNFTOhyivdj5cVKk2c9bNZQ1iN/HC80mFD7SJJOWQ+ETNuAvX5+GftyV/Z?= =?us-ascii?Q?MsD3OLxx8KMnZKC0HQoNgnijYtv65ELe9IByYGV2M1QH6ScdTwlnHvKxk8ZK?= =?us-ascii?Q?XxvIMaH65frYHBROLIiqqxd2pHhf442GMnXYNK17il1MxJfMS8lU8hbHT7Q0?= =?us-ascii?Q?XJXaMT4SEPOH9kONJNavpb/blfmM9FdqG/vdoCQQ94cpE90QwbLUqNCH8ECT?= =?us-ascii?Q?GdexHGaU+P24SUvXDr69qA0c+JwzO4FBVowOXkw1b1NvCGh31SyJ2QuZCu5+?= =?us-ascii?Q?EdSVuKPQyH2H5IjljbN343JS2fvjt/2+PLjWijdmbkKbDT1RfPJJPfSf0KGG?= =?us-ascii?Q?bAW6RdWifs3aP4N5rgIiENmRhZ5Rw2S/yqqhKWUAitM4GaehWf7nl0oOCCIm?= =?us-ascii?Q?PX/g6nOx8SCxfkozYWUInGpOvutqB0bcllsF4zVp8YP48I3uYREaSEnnyG1x?= =?us-ascii?Q?KWgFZapaTXTG1Qahr1heqvuRFgO0SZ3LFJ8BNEozyMLqp9w/vQPMX0JpLmit?= =?us-ascii?Q?926P1YnUAordNFPP9jcVAwN/bqRmI1y49/aMXQCZtwrTqd+O63hqBACAygjF?= =?us-ascii?Q?7ICYonnNfIAqmIQrDLlk/5glfCUIYJCKUVVJbCJt9ADjjEezcAfiRNEADJyR?= =?us-ascii?Q?7ZfxLrS9Db104stiwsU4MHaNVLKmhC36Rw9b9t9/XfrPqbXhIyWGeM8P272U?= =?us-ascii?Q?3ZFkhp0GP1uoTKvXVzvJbmSV2Rme0BKK5VOC+aR53Esr1s3XlQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8658.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jSsmDufvFn2VD59V1z5PYd01Q0R4YxlQ4t2/6uvS+Ptn3FNM0TmGUi3TOVft?= =?us-ascii?Q?4ZXqU7fX5Og0faqnIQsT9TyaReeql7qRY/qE9WxLMbbKxDP9cztrdYdqAlP8?= =?us-ascii?Q?l70jkOnH2ISs1RkIxZL7N78Vk3l24U25ddKSiYuBFuWfepbMfEBff9KseP6R?= =?us-ascii?Q?uvPFlROPiheEpW4SAKt/0nQYzgK5gqZlMAEKMYITKaH3mx/pjpAYOsqkn1it?= =?us-ascii?Q?YKDIeZ9UHbM+j7wlrsB4iXnBH92zxrWEbiCtjcyONpffiZbYBGRi3+u0lALU?= =?us-ascii?Q?Cid9JIkR6/ZvQmPF2K8qxKSXSfylrsWWmnir7gNHhMIUpKfAwJA8ldbgR6Pc?= =?us-ascii?Q?BsV0FK8ND7xBnj+MbitCgVoYoPUP4jVTZukn8JNglGqnVIkgJKgC/q6sJPHx?= =?us-ascii?Q?iNuTjDcvQk4oN0hyZVNHW6xFhT8wDEW22XBoihhI13qYfVihiviHoZL20rBc?= =?us-ascii?Q?lX1t6J8g9uRk78itd94X7dyug0raKTGvUCVUXuc417kobMTJbcGgAri5YCIr?= =?us-ascii?Q?sLtEte9FnFVKYJ/ucpFBjxTFJuEuJ92RkF4ypsg2c4G0Njzmrbd8C+maBTu4?= =?us-ascii?Q?ATbxu43XJcPHXeIPL3IvbzMKcMjSQ/kbmaLHGvsbsgjq3G8wRHcQDB/+GZ30?= =?us-ascii?Q?6h1IoXDUbDGMjdJJkN+bkomYeyez6FAE0wqROECRf0V/4tA8pBXRG5GXjQZk?= =?us-ascii?Q?wMm0gNWyCwUip6xh+2lgk4TCJCq5lKfl9peK9I0xvuMFsjidFvfQTwo70k1r?= =?us-ascii?Q?aG2WIjwvVXU0BFdocpbdw8BLXAbfTTjDhki/k0MR3/CWM8rQ++SkB/LrKHP/?= =?us-ascii?Q?SxNG6D5EwxNfw3h3jZjLQN7J4ol5RuFmIDn89uid4eKlzVjNjie2XU3QLYTc?= =?us-ascii?Q?m2+X2mo6jXvoTYxpcAeSvzHSR8vR+Py+cltmsQpF+RGKW8QKsrraKNhSvwMD?= =?us-ascii?Q?pd9xlYy2C8OHSGpIbdR677qbVv+gXdgSLCTfr+uD+OGKi54fC103bql8k7qd?= =?us-ascii?Q?BVZmpD6sRTH2KBv7Gjv+47raKlINNrA8V0zEapJX86LoUdISgDpnANjL7mP4?= =?us-ascii?Q?/8gaKTqSx5zb6lb4h+RXuRseM9XMo6h548JJ1xTlCEKBBhgJNV8nYiFeuEHD?= =?us-ascii?Q?ESk2hCH/6DwGxbI8ih/mrURZwUXWYwiG+GPuSGotvUb7WbNN8ZEC25G7caeO?= =?us-ascii?Q?0SUIhEy1lti/2FsjpPYFIK1rC8pF/UmCnSxxoXfHxrka+Zzgu650J2BdK6lc?= =?us-ascii?Q?QvTRH+6ygYHW9+g092Jri0slTjH8Km+WTupYXkKQQbXORUpHPS+d14AnmD3H?= =?us-ascii?Q?67bMwOo8Ud4AodztC9XFMWJugmyjt88pO1ZR4jFN946HxULYdDSxVPBL5kT9?= =?us-ascii?Q?9Ya8Gs3u1dtsVLRgO756sIB1q9atN/L/9KXnwfpTPpYa/KZ2BCdvCDFh/L8Q?= =?us-ascii?Q?nf/oBHLIS+LRsIoMImd6zEdppVQ25EyOTKiEdBlv86gm/iHMsxNcz20QwXbZ?= =?us-ascii?Q?rkvzAln0qJlGtKIbM3PYELwbOtKK2zM5JRgxM+YKxnvfQorARC96J5JMKJeY?= =?us-ascii?Q?lT9H2nepWXjs6emlu9rUa9jq+dx3qr8+ynbEgqHR?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB8658C8737685302D2F1566F6A1902CH3PR12MB8658namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8658.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90cc5972-33fc-44e5-f793-08dcc9cc54ae X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2024 14:51:01.0737 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MIZKx2UYu3i1kKi9yw6Dv5gcu7nfzem6b5jqbbWHPufNMx16VvWsGD/mIf0JshLlM5tVYKu6JCNosfqDqZlBUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6917 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_CH3PR12MB8658C8737685302D2F1566F6A1902CH3PR12MB8658namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Hailin, This patch was originally queued to 23.11.2 list, but removed per Mingjin's= request. If we do need the fix, let's schedule it to 23.11.3. Regards, Xueming ________________________________ From: Ye, MingjinX Sent: Wednesday, July 17, 2024 10:21 AM To: Xueming Li Cc: dpdk stable Subject: RE: patch 'bus/vdev: revert fix devargs in secondary process' has = been queued to stable release 23.11.2 Hi, Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything. Thanks, Mingjin > -----Original Message----- > From: Xueming Li > Sent: Friday, July 12, 2024 7:02 PM > To: Ye, MingjinX > Cc: dpdk stable > Subject: patch 'bus/vdev: revert fix devargs in secondary process' has be= en > queued to stable release 23.11.2 > > Hi, > > FYI, your patch has been queued to stable release 23.11.2 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 07/14/24. So please shout= if > anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Queued patches are on a temporary branch at: > https://git.dpdk.org/dpdk-stable/log/?h=3D23.11-staging > > This queued commit can be viewed at: > https://git.dpdk.org/dpdk-stable/commit/?h=3D23.11- > staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b > > Thanks. > > Xueming Li > > --- > From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > From: Mingjin Ye > Date: Thu, 14 Mar 2024 09:36:28 +0000 > Subject: [PATCH] bus/vdev: revert fix devargs in secondary process > Cc: Xueming Li > > [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > > The ASan tool detected a memory leak in the vdev driver alloc_devargs. Th= e > previous commit was that when inserting a vdev device, the primary proces= s > alloc devargs and the secondary process looks for devargs. This causes th= e > device to not be created if the secondary process does not initialise the= vdev > device. And, this is not the root cause. > > Therefore the following commit was reverted accordingly. > > After restoring this commit, the memory leak still exists. > > Bugzilla ID: 1450 > Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process") > > Signed-off-by: Mingjin Ye > --- > drivers/bus/vdev/vdev.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args) > return devargs; > } > > -static struct rte_devargs * > -vdev_devargs_lookup(const char *name) > -{ > - struct rte_devargs *devargs; > - char dev_name[32]; > - > - RTE_EAL_DEVARGS_FOREACH("vdev", devargs) { > - devargs->bus->parse(devargs->name, &dev_name); > - if (strcmp(dev_name, name) =3D=3D 0) { > - VDEV_LOG(INFO, "devargs matched %s", dev_name); > - return devargs; > - } > - } > - return NULL; > -} > - > static int > insert_vdev(const char *name, const char *args, > struct rte_vdev_device **p_dev, > @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, > if (name =3D=3D NULL) > return -EINVAL; > > - if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) > - devargs =3D alloc_devargs(name, args); > - else > - devargs =3D vdev_devargs_lookup(name); > + devargs =3D alloc_devargs(name, args); > > if (!devargs) > return -ENOMEM; > -- > 2.34.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2024-07-12 18:40:18.570682691 +0800 > +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch 202= 4- > 07-12 18:40:14.356594197 +0800 > @@ -1 +1 @@ > -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00 > 2001 > +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > @@ -4,0 +5,3 @@ > +Cc: Xueming Li > + > +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > @@ -20 +22,0 @@ > -Cc: stable@dpdk.org --_000_CH3PR12MB8658C8737685302D2F1566F6A1902CH3PR12MB8658namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Hailin,

This patch was originally queued to 23.11.2 list, but removed per Mingjin's= request. If we do need the fix, let's schedule it to 23.11.3.

Regards,
Xueming
From: Ye, MingjinX <ming= jinx.ye@intel.com>
Sent: Wednesday, July 17, 2024 10:21 AM
To: Xueming Li <xuemingl@nvidia.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: RE: patch 'bus/vdev: revert fix devargs in secondary proces= s' has been queued to stable release 23.11.2
 
Hi,

Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything.

Thanks,
Mingjin

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Friday, July 12, 2024 7:02 PM
> To: Ye, MingjinX <mingjinx.ye@intel.com>
> Cc: dpdk stable <stable@dpdk.org>
> Subject: patch 'bus/vdev: revert fix devargs in secondary process' has= been
> queued to stable release 23.11.2
>
> Hi,
>
> FYI, your patch has been queued to stable release 23.11.2
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 07/14/24. So please sh= out if
> anyone has objections.
>
> Also note that after the patch there's a diff of the upstream commit v= s the
> patch applied to the branch. This will indicate if there was any rebas= ing
> needed to apply to the stable branch. If there were code changes for > rebasing
> (ie: not only metadata diffs), please double check that the rebase was=
> correctly done.
>
> Queued patches are on a temporary branch at:
> ht= tps://git.dpdk.org/dpdk-stable/log/?h=3D23.11-staging
>
> This queued commit can be viewed at:
> https:= //git.dpdk.org/dpdk-stable/commit/?h=3D23.11-
> staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
>
> ---
> From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00
> 2001
> From: Mingjin Ye <mingjinx.ye@intel.com>
> Date: Thu, 14 Mar 2024 09:36:28 +0000
> Subject: [PATCH] bus/vdev: revert fix devargs in secondary process
> Cc: Xueming Li <xuemingl@nvidia.com>
>
> [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ]
>
> The ASan tool detected a memory leak in the vdev driver alloc_devargs.= The
> previous commit was that when inserting a vdev device, the primary pro= cess
> alloc devargs and the secondary process looks for devargs. This causes= the
> device to not be created if the secondary process does not initialise = the vdev
> device. And, this is not the root cause.
>
> Therefore the following commit was reverted accordingly.
>
> After restoring this commit, the memory leak still exists.
>
> Bugzilla ID: 1450
> Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process&= quot;)
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
>  drivers/bus/vdev/vdev.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)=
>        return devargs;
>  }
>
> -static struct rte_devargs *
> -vdev_devargs_lookup(const char *name)
> -{
> -     struct rte_devargs *devargs;
> -     char dev_name[32];
> -
> -     RTE_EAL_DEVARGS_FOREACH("vdev", de= vargs) {
> -           &nb= sp; devargs->bus->parse(devargs->name, &dev_name);
> -           &nb= sp; if (strcmp(dev_name, name) =3D=3D 0) {
> -           &nb= sp;         VDEV_LOG(INFO, "de= vargs matched %s", dev_name);
> -           &nb= sp;         return devargs;
> -           &nb= sp; }
> -     }
> -     return NULL;
> -}
> -
>  static int
>  insert_vdev(const char *name, const char *args,
>            = ;    struct rte_vdev_device **p_dev,
> @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, >        if (name =3D=3D NULL)
>            = ;    return -EINVAL;
>
> -     if (rte_eal_process_type() =3D=3D RTE_PROC_P= RIMARY)
> -           &nb= sp; devargs =3D alloc_devargs(name, args);
> -     else
> -           &nb= sp; devargs =3D vdev_devargs_lookup(name);
> +     devargs =3D alloc_devargs(name, args);
>
>        if (!devargs)
>            = ;    return -ENOMEM;
> --
> 2.34.1
>
> ---
>   Diff of the applied patch vs upstream commit (please doubl= e-check if non-
> empty:
> ---
> --- - 2024-07-12 18:40:18.570682691 +0800
> +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch &= nbsp;     2024-
> 07-12 18:40:14.356594197 +0800
> @@ -1 +1 @@
> -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00
> 2001
> +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00
> 2001
> @@ -4,0 +5,3 @@
> +Cc: Xueming Li <xuemingl@nvidia.com>
> +
> +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ]
> @@ -20 +22,0 @@
> -Cc: stable@dpdk.org
--_000_CH3PR12MB8658C8737685302D2F1566F6A1902CH3PR12MB8658namp_--