From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3765A052A for ; Mon, 25 Jan 2021 18:52:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D91EE141160; Mon, 25 Jan 2021 18:52:00 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id B2791141160; Mon, 25 Jan 2021 18:51:59 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10PHo3F6028358; Mon, 25 Jan 2021 09:51:55 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=W+IlrQXAwFZ8GIJU3DF4uB2qTfUayZNGDjX/18Bw/KA=; b=M4P2HZxoVm2buWdvaYW4i+k2G+LVPbyrSjsd4sWZLlmsduqUOZXQ/3HarHaJKjRhrqUu vGRCWimz8jogvyFWi3h5sl2oypnK+xOU7sU256RTm3BIOExCex4v479BYfbYX3O1NUGY 5ZZhG290k5gkXzcDxxEIwxC/mT/VZYFpQCYOfLE2BD0QJYsov3BYylX87cRg+PmG50qz lsJPAaFwH6TXKemT6Bs2zX8ZKrzvde6BhuRlEVYbi7fux4BUpk7T5/V57iAftEIHj8Ux JW+GmV/34c5qaCwo7oudOpE8qTz3URDk7ele4i3GxAPhjEjdawswgnbCa00REVprTZQo 0A== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com with ESMTP id 368m6ud83y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 25 Jan 2021 09:51:54 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Jan 2021 09:51:52 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Jan 2021 09:51:52 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 25 Jan 2021 09:51:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J2X4KB5Gt+3VbLZAU6zk2G3199jh/QB9OecwsT8vrOZIuW94KE1D0rYOkM6HwGCGCSI1TZvo47txkcVssixQiAfM2CXxDjkirLp20zAoQd1pNEG0DrBdPtO+aBRWH8Zh6rmvqB9NQvGYf4usm34njVNIfr06raA9THo5yMtXLxVPljGE6ylPJI2ZK1HxEqDMt0o+TEqtgXFt/BZzIwmFoBAZZS6uwbLtWuDi5Tx39FyCn6E/2KaQ20lTyL2cwkFzI5rvD0zYHt/BmutHLLipLFAlI2C8UCYYzEEswysPk0hHHSxeVJ44+yarp9uWROIOKYvAQ4ouVqfrgKoZKmIoJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W+IlrQXAwFZ8GIJU3DF4uB2qTfUayZNGDjX/18Bw/KA=; b=h6aihUP7wSNxUp+xcmJSsTtk0GEBkLMfo2F8nUWwlA3RcmBIFw3hB1/fYEkjXNZHy9kb7sncjtUNOblT2CXT/sKma/0wcVxvtfZS0T+CXxuglwy5Pi0E3pmmUYYk/MjKPwktAJ5fAMYKN36nXl+VnVJpr0jYxbwnZWjyNACnGjJKpWB24mXJt+NNULENM2j52Ce9hLOFnmdLqTYZO3JSHWsSt+LS6JOgusgVsaRKqA5Y6jdb6iKRtq6oWXnNQR3oZRL4Gj8ZCTjCwmsrmfYpdzmlzyhtd/jl4owiWqd5gJQX70CkpJGraMwWqIUEOkqPQwH95x/ekMCILkvmDxqnHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W+IlrQXAwFZ8GIJU3DF4uB2qTfUayZNGDjX/18Bw/KA=; b=nq1C37GvMs1Jp04PBWioI7SOGhoNiRIM61vwL1UGYMlV+bJxjqG4ozcp6eirzhOCmj95Z2dNKKJ4zdsVa1n1zIxPfpxdYuXwHpKzlEgag9rQhxYQVI+FjlFRRN8ScQlM/16Cgy/B0snTIIKitt0PcZDb/Hgi5w/JXPPozSDgcnE= Received: from CO6PR18MB3828.namprd18.prod.outlook.com (2603:10b6:5:346::20) by CO6PR18MB4084.namprd18.prod.outlook.com (2603:10b6:5:349::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.14; Mon, 25 Jan 2021 17:51:51 +0000 Received: from CO6PR18MB3828.namprd18.prod.outlook.com ([fe80::5c2c:a13a:4f3d:94df]) by CO6PR18MB3828.namprd18.prod.outlook.com ([fe80::5c2c:a13a:4f3d:94df%5]) with mapi id 15.20.3784.019; Mon, 25 Jan 2021 17:51:51 +0000 From: Pavan Nikhilesh Bhagavatula To: Feifei Wang , Harry van Haaren , Pavan Nikhilesh , Nikhil Rao CC: "dev@dpdk.org" , "nd@arm.com" , "stable@dpdk.org" , Ruifeng Wang , Honnappa Nagarahalli Thread-Topic: [EXT] [PATCH v4 3/3] examples/eventdev: move eth stop to the end Thread-Index: AQHW6mBshadkx1iaFk2dO6lzaYTvx6o4sLDw Date: Mon, 25 Jan 2021 17:51:51 +0000 Message-ID: References: <20201221053454.47307-1-feifei.wang2@arm.com> <20210114103101.738262-1-feifei.wang2@arm.com> <20210114103101.738262-4-feifei.wang2@arm.com> In-Reply-To: <20210114103101.738262-4-feifei.wang2@arm.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2405:201:d009:380f:50b:3c28:481f:4468] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 696b6eae-bf78-4bd9-d39c-08d8c159e512 x-ms-traffictypediagnostic: CO6PR18MB4084: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yxHjgnCiw0FTYYpgeG+KFY2XNUVnlSy013nq+c8kqP92heN8e7+I7fq8nHKzCoNn726n7ErB93X+O5mO9wm/Hn9BL4KFYJIwLfN2ondjQ7u1OQoPIx9o3+iDcF7vJL2H2BXIql+v+SSGInZp1Ee1JHOH/VhssZZGkCAjP30BCHXLyHeHwQ0bpmLs2k1T7wha/2PMwEMCHzcgLWotTUGz77v9PZoReE6GH4pVN67GHMdTU0eetJFtt8VTcnQleTBmvhCZlHMjGRzhutDKhOn6cm3rZ1Ph+0EOjfMovAYEY+5PZLktSm3LJpaPzElE85JcyRDvbCXh1v0LV18uUX14/tk5I76EuVaRIWfP+MmDSC7BqvrQbEVOfKFy1GhgeU7mBvlf9xULVR7mwkZ+NKjvGA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3828.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(39860400002)(136003)(376002)(396003)(8936002)(83380400001)(66446008)(186003)(9686003)(64756008)(33656002)(8676002)(478600001)(6506007)(55016002)(66946007)(110136005)(76116006)(54906003)(71200400001)(7696005)(4326008)(52536014)(86362001)(5660300002)(66556008)(2906002)(66476007)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?PD9xfKIY5drQ3gO0BqkZ9NNhIx85AfiNbNojKKOUN5vgfO/oo4ViBjbFAR7x?= =?us-ascii?Q?0/zSqHEP0XL5zTSiPqVoNuahRXTD2wBwFzmUdpFTMXf17h3ZD69+xebskdLo?= =?us-ascii?Q?1RQJ0LA/pIYOXWn4NQlmcl/g805MwHRvcDQa4Jajxz8M20+MTrLkXgazMCfV?= =?us-ascii?Q?xgl4EhWeaL+6NoUtwjcIDWq80B+HyT9LfKALM3YcYGrOiWQSuxUMP8nzL0u0?= =?us-ascii?Q?3dbPBReoaNnePbhx3F2VZRyCKcpR575874+TGbpTbuQRv1MvrWgX2R4s2Sd5?= =?us-ascii?Q?J7tDiRoHIeV2h5N69McaXJX9cjo+4p0cGgYKPZLW4LR4V22IUirJtJaSOmgt?= =?us-ascii?Q?zzhl0fi/xNl4mDN5IUC4Wl4PQESOf9gxpE3OzyoqP7CLsKxLYCsxg6e3lfWI?= =?us-ascii?Q?S+CxycLUmGwtcll8SDERFR2dIN9Bm3T3DstNgIXD/ifC7ZyWXHafg/UWUaxX?= =?us-ascii?Q?ObVscJ1B4iChdDkV5LzrxhSmme524gZkhoA34tzJ4VyTaCmke6AKgSyKJqtY?= =?us-ascii?Q?ZP57T2eVzb45PXnRkBk7bOCvn2OPqYdbnhHg7ZwxhndbXFP39Eu0aa5w1Ko2?= =?us-ascii?Q?s41TqLqT89kiJhwGtVXp7NwQRzZ3GpKpLY4ZOpxqTJRSpU2TUOvZvLXGujTu?= =?us-ascii?Q?p0U0OHqX8nooUcYbTmGv0+bpB8Vw2KA75QDRG5rDR7f5NXrrZvuxfs7YiVTL?= =?us-ascii?Q?OduCdTrDR6D1bKUtFgK40vxImmlsL785vSdfLwLUPMkq0WM651Txqr1aV3sq?= =?us-ascii?Q?GJwNGsvBosBihG1/IqAsXcYpzxpOw+yRt6ZQecAE3rLdFVos+gS+sT1WKTzK?= =?us-ascii?Q?jSAjg9/uhxD7Qx69/tc3QUKeHCoeq+2vDQe6Zs2+T1lSmiHF0rAVdfz8CKlo?= =?us-ascii?Q?lZ9M4grYgusboRmdK8QBrtIgImHP24bs3flglMIbmp03x/Pk3nx/8WsNplBt?= =?us-ascii?Q?WRSf3KIguaLcwJJFm7FHZ+9TuXUcdqLuaWkHHwxMNoiSLNh/mJUCQq5QHeco?= =?us-ascii?Q?C7VqAcGLavpONO0IqUywdyWFWWPehY2ktlaPTsXv/lyf6rHnl0HXogLoE66J?= =?us-ascii?Q?V2HnX1XCLe5FYF44pjcPcLJXWg4eB6dQMayzxDUn5qqu0HZJnImjfqJJ8Xi+?= =?us-ascii?Q?OooFZokTJc7f?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3828.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 696b6eae-bf78-4bd9-d39c-08d8c159e512 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2021 17:51:51.1366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cScaDBJRqetMkHThnVYtmGDoDpRb4Tu1tumToXmTq9bCZRg5YA01RkeJCGlC2zUxY31wFVM88kwrSuZ8+rihRlOcHGBHc9N+DDh03cwrbrM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4084 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-25_07:2021-01-25, 2021-01-25 signatures=0 Subject: Re: [dpdk-stable] [EXT] [PATCH v4 3/3] examples/eventdev: move eth stop to the end X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" >Move eth stop code from "signal_handler" function to the end of >"main" >function. There are two reasons for this: > >First, this improves code maintenance and makes code look simple and >clear. Based on this change, after receiving the interrupt signal, >"fdata->done" is set as 1. Then the main thread will wait all worker >lcores to jump out of the loop. Finally, the main thread will stop and >then close eth dev port. > >Second, for older version, the main thread first stops eth dev port and >then waits the end of worker lcore. This may cause errors because it >may >stop the eth dev port which worker lcores are using. This moving >change >can fix this by waiting all worker threads to exit and then stop the >eth dev port. > >In the meanwhile, remove wmb in signal_handler. > >This is because when the main lcore receive the stop signal, it stores 1 >into fdata->done. And then the worker lcores load "fdata->done" and >jump >out of the loop to stop running. Nothing should be stored after >updating >fdata->done, so the wmb is unnecessary. > >Fixes: 085edac2ca38 ("examples/eventdev_pipeline: support Tx >adapter") >Cc: pbhagavatula@marvell.com >Cc: stable@dpdk.org > >Suggested-by: Ruifeng Wang >Signed-off-by: Feifei Wang >Reviewed-by: Ruifeng Wang >Reviewed-by: Honnappa Nagarahalli > >Acked-by: Harry van Haaren Acked-by: Pavan Nikhilesh >--- > examples/eventdev_pipeline/main.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > >diff --git a/examples/eventdev_pipeline/main.c >b/examples/eventdev_pipeline/main.c >index 3526d4d3d..4621e8a89 100644 >--- a/examples/eventdev_pipeline/main.c >+++ b/examples/eventdev_pipeline/main.c >@@ -311,7 +311,6 @@ static void > signal_handler(int signum) > { > static uint8_t once; >- uint16_t portid; > > if (fdata->done) > rte_exit(1, "Exiting on signal %d\n", signum); >@@ -322,17 +321,6 @@ signal_handler(int signum) > rte_event_dev_dump(0, stdout); > once =3D 1; > fdata->done =3D 1; >- rte_smp_wmb(); >- >- RTE_ETH_FOREACH_DEV(portid) { >- rte_event_eth_rx_adapter_stop(portid); >- rte_event_eth_tx_adapter_stop(portid); >- if (rte_eth_dev_stop(portid) < 0) >- printf("Failed to stop port %u", portid); >- } >- >- rte_eal_mp_wait_lcore(); >- > } > if (signum =3D=3D SIGTSTP) > rte_event_dev_dump(0, stdout); >@@ -483,6 +471,10 @@ main(int argc, char **argv) > } > > RTE_ETH_FOREACH_DEV(portid) { >+ rte_event_eth_rx_adapter_stop(portid); >+ rte_event_eth_tx_adapter_stop(portid); >+ if (rte_eth_dev_stop(portid) < 0) >+ printf("Failed to stop port %u", portid); > rte_eth_dev_close(portid); > } > >-- >2.25.1