* [PATCH] test/crypto: fix IPsec AES CCM test vector
@ 2023-05-12 12:59 Tejasree Kondoj
2023-05-12 14:02 ` Anoob Joseph
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tejasree Kondoj @ 2023-05-12 12:59 UTC (permalink / raw)
To: Akhil Goyal, Fan Zhang
Cc: Anoob Joseph, Ciara Power, Jerin Jacob, Aakash Sasidharan,
Gowrishankar Muthukrishnan, Vidya Sagar Velumuri, dev, stable
Fixing IPsec AES-CCM test vector IV length.
Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
Cc: stable@dpdk.org
Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
---
app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev_security_ipsec_test_vectors.h b/app/test/test_cryptodev_security_ipsec_test_vectors.h
index 2686bbeb62..462cef6785 100644
--- a/app/test/test_cryptodev_security_ipsec_test_vectors.h
+++ b/app/test/test_cryptodev_security_ipsec_test_vectors.h
@@ -417,7 +417,7 @@ struct ipsec_test_data pkt_aes_256_ccm = {
.op = RTE_CRYPTO_AEAD_OP_ENCRYPT,
.algo = RTE_CRYPTO_AEAD_AES_CCM,
.key.length = 32,
- .iv.length = 12,
+ .iv.length = 11,
.iv.offset = IV_OFFSET,
.digest_length = 16,
.aad_length = 12,
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] test/crypto: fix IPsec AES CCM test vector
2023-05-12 12:59 [PATCH] test/crypto: fix IPsec AES CCM test vector Tejasree Kondoj
@ 2023-05-12 14:02 ` Anoob Joseph
2023-05-16 10:18 ` Akhil Goyal
2023-05-24 12:51 ` [PATCH v2] " Tejasree Kondoj
2 siblings, 0 replies; 5+ messages in thread
From: Anoob Joseph @ 2023-05-12 14:02 UTC (permalink / raw)
To: Tejasree Kondoj, Akhil Goyal, Fan Zhang
Cc: Ciara Power, Jerin Jacob Kollanukkaran, Aakash Sasidharan,
Gowrishankar Muthukrishnan, Vidya Sagar Velumuri, dev, stable
>
> Fixing IPsec AES-CCM test vector IV length.
>
> Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> ---
> app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] test/crypto: fix IPsec AES CCM test vector
2023-05-12 12:59 [PATCH] test/crypto: fix IPsec AES CCM test vector Tejasree Kondoj
2023-05-12 14:02 ` Anoob Joseph
@ 2023-05-16 10:18 ` Akhil Goyal
2023-05-24 12:51 ` [PATCH v2] " Tejasree Kondoj
2 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2023-05-16 10:18 UTC (permalink / raw)
To: Tejasree Kondoj, Fan Zhang
Cc: Anoob Joseph, Ciara Power, Jerin Jacob Kollanukkaran,
Aakash Sasidharan, Gowrishankar Muthukrishnan,
Vidya Sagar Velumuri, dev, stable
> Subject: [PATCH] test/crypto: fix IPsec AES CCM test vector
>
> Fixing IPsec AES-CCM test vector IV length.
Please add appropriate description.
>
> Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> ---
> app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_cryptodev_security_ipsec_test_vectors.h
> b/app/test/test_cryptodev_security_ipsec_test_vectors.h
> index 2686bbeb62..462cef6785 100644
> --- a/app/test/test_cryptodev_security_ipsec_test_vectors.h
> +++ b/app/test/test_cryptodev_security_ipsec_test_vectors.h
> @@ -417,7 +417,7 @@ struct ipsec_test_data pkt_aes_256_ccm = {
> .op = RTE_CRYPTO_AEAD_OP_ENCRYPT,
> .algo = RTE_CRYPTO_AEAD_AES_CCM,
> .key.length = 32,
> - .iv.length = 12,
> + .iv.length = 11,
Add a comment here that IV includes 3 bytes of salt and 8 bytes of IV.
> .iv.offset = IV_OFFSET,
> .digest_length = 16,
> .aad_length = 12,
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] test/crypto: fix IPsec AES CCM test vector
2023-05-12 12:59 [PATCH] test/crypto: fix IPsec AES CCM test vector Tejasree Kondoj
2023-05-12 14:02 ` Anoob Joseph
2023-05-16 10:18 ` Akhil Goyal
@ 2023-05-24 12:51 ` Tejasree Kondoj
2023-05-24 21:29 ` Akhil Goyal
2 siblings, 1 reply; 5+ messages in thread
From: Tejasree Kondoj @ 2023-05-24 12:51 UTC (permalink / raw)
To: Akhil Goyal, Fan Zhang
Cc: Anoob Joseph, Ciara Power, Jerin Jacob, Aakash Sasidharan,
Gowrishankar Muthukrishnan, Vidya Sagar Velumuri, dev, stable
Set IPsec AES-CCM test vector IV length to 11
instead of 12 as it includes only 3B salt and
8B per packet IV.
Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
Cc: stable@dpdk.org
Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
---
app/test/test_cryptodev_security_ipsec_test_vectors.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev_security_ipsec_test_vectors.h b/app/test/test_cryptodev_security_ipsec_test_vectors.h
index 2686bbeb62..6e60e32b9d 100644
--- a/app/test/test_cryptodev_security_ipsec_test_vectors.h
+++ b/app/test/test_cryptodev_security_ipsec_test_vectors.h
@@ -417,7 +417,8 @@ struct ipsec_test_data pkt_aes_256_ccm = {
.op = RTE_CRYPTO_AEAD_OP_ENCRYPT,
.algo = RTE_CRYPTO_AEAD_AES_CCM,
.key.length = 32,
- .iv.length = 12,
+ /* IV includes 3B salt and 8B per packet IV */
+ .iv.length = 11,
.iv.offset = IV_OFFSET,
.digest_length = 16,
.aad_length = 12,
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] test/crypto: fix IPsec AES CCM test vector
2023-05-24 12:51 ` [PATCH v2] " Tejasree Kondoj
@ 2023-05-24 21:29 ` Akhil Goyal
0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2023-05-24 21:29 UTC (permalink / raw)
To: Tejasree Kondoj, Fan Zhang
Cc: Anoob Joseph, Ciara Power, Jerin Jacob Kollanukkaran,
Aakash Sasidharan, Gowrishankar Muthukrishnan,
Vidya Sagar Velumuri, dev, stable
> Subject: [PATCH v2] test/crypto: fix IPsec AES CCM test vector
>
> Set IPsec AES-CCM test vector IV length to 11
> instead of 12 as it includes only 3B salt and
> 8B per packet IV.
>
> Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-24 21:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-12 12:59 [PATCH] test/crypto: fix IPsec AES CCM test vector Tejasree Kondoj
2023-05-12 14:02 ` Anoob Joseph
2023-05-16 10:18 ` Akhil Goyal
2023-05-24 12:51 ` [PATCH v2] " Tejasree Kondoj
2023-05-24 21:29 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).