From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 672694586A for ; Mon, 26 Aug 2024 10:07:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3ED334025F; Mon, 26 Aug 2024 10:07:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id CEBED400D6 for ; Mon, 26 Aug 2024 10:07:29 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47Q2vWDW005272; Mon, 26 Aug 2024 01:07:25 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 418hcbgt2p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Aug 2024 01:07:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MCl37nI5i7BTZKsYF5HciW06ApWTCHvH7XwHN/q5dOYrMyL554teXRNKPeOzblF62tW996W6Navj771qYgcfx0+iBsp8O7nq/FqS9cYJAZc+k/oUlCR4Khh1jy48jY68jH4WEx0tyHsCmW1EunFH2MaeU+wFX0/sdWlJZM340Rpi2SVyuTevQodJCif7zZSHJi6snXI8GWowNxEHb77LuLvEeZyhYgmBz8J6LHRzFPz1R+v646/DvPAfpnWJdDOzCX2dtwL9noYguwQzUeLFGp5wAxNZkXz+CuwO5vWHSpzJkLcG5F9E+J3v896F1RIU94qA5CTGCcKDX3d7xUzz0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6D/fBw7k0RliaYz2rOXS8FOwo0ZlGf3cVK/UIMJuS4c=; b=MLb3/h6UOLmxoDsVR3/fonqfQd9NAxTnUgwxsLt/ItKzWIu9Adj/0s4nTAoaruCsrys5YNx4KUmWHxzKoI/reQlc/eiaX0CYvTSUVcqRQKUQLFuyTN5TbcAQ5N7gy9/G8wfm7UtOR05tJ6dzgeEkzVcENvJYZ87EohxpMGjblipfHFEOiLhGwFO4fV6QUtIMzVEVuQp+s29QXGlFInuMAtVCmFGRR0+pJ55RWZ1KhHyl3g3CcFQyHqX56UYZIHN/FiOaDEUI6jYQ8aSjSKBkvyg+eJLjij6gwc6kVSVUh7fK2csur7HlefR0MxN+juXzhNHJtJrNiMp/1ZSyyPQygw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6D/fBw7k0RliaYz2rOXS8FOwo0ZlGf3cVK/UIMJuS4c=; b=KJV3vTzaxIMp+Ry/OI6d3qykCq97JET20ngIovdTVoDw/nDBalcfmeWF8TjYtk5Gd1So3OFFn49ZdbMqOCcXVPuNUdSh3B83H9AUOVXL3P0GVf8CBuSCz1e9YGXOgsHQHOGZOwG1u92B0J/KWzmZu6HAyyg8Sv6hvXbmR5XAoJY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM6PR18MB3620.namprd18.prod.outlook.com (2603:10b6:5:2aa::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25; Mon, 26 Aug 2024 08:07:20 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d%4]) with mapi id 15.20.7897.021; Mon, 26 Aug 2024 08:07:20 +0000 From: Akhil Goyal To: Kevin Traynor , Shihong Wang CC: Chaoyong He , dpdk stable Subject: RE: [EXTERNAL] patch 'examples/ipsec-secgw: fix SA salt endianness' has been queued to stable release 21.11.8 Thread-Topic: [EXTERNAL] patch 'examples/ipsec-secgw: fix SA salt endianness' has been queued to stable release 21.11.8 Thread-Index: AQHa9Xie3mVIM/LG0Eubz1GhTQW4D7I5Mr9Q Date: Mon, 26 Aug 2024 08:07:20 +0000 Message-ID: References: <20240823161929.1004778-1-ktraynor@redhat.com> <20240823161929.1004778-69-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-69-ktraynor@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|DM6PR18MB3620:EE_ x-ms-office365-filtering-correlation-id: 1bcd5866-f311-42eb-ad22-08dcc5a61be5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?ZWI5MXBLa3VsS215RWtteWhlTWhTNENEVjRXOVVYekxvalNOWkZVREwyKzBx?= =?utf-8?B?czVpOEVaQ04yMDFCNzQxWnRYQWNpNHdmQmdOcjk2YWVrY0JsVDBkbG5lWHlE?= =?utf-8?B?ZnAxeWNXSk1IUmFWTE1vaGZyN3R4TnI2cnBDaEJuV0laRzA3M1A4SFkwUi9P?= =?utf-8?B?L0JYN1MzWHhXZHFxNW9YV0dvWk5yMGdpRVFoS2xMV0JGRTNEQWw0ankyaVFO?= =?utf-8?B?RTZDSUptbzhqTTQyMVFjT1BUMnJDT0NOMzJxWmRGNldRUkNFK2xESXFCOU14?= =?utf-8?B?R01wdkNEUGI5enE5NEk2VHIzMURaYnNNWHNGazl6RmI3a2VHd2c0RzdWMkpy?= =?utf-8?B?M3ZiT1NscFVYekhucmVsb1pXQUJNcHFCYUFsUHVQMEMya1Uwb0FSbmNNRW5D?= =?utf-8?B?bkw1Mk1BaU9rNFRBRVJ5SnZKV0VDN3EvenhRYmZ3SW5vQTFTeEZPM2lKRVB0?= =?utf-8?B?NjdmVEdSZ2RNM3RLNEE5MFYrRERlMDZjVVR5L0d2Zk92NzhoR1l1UzFkZEVI?= =?utf-8?B?bS9UZHJSNFdoMmdKZTlyZTRHZk1FcWwvZitIVVZkSEtMbE5RekV2ZUVGUEZK?= =?utf-8?B?cUxtdFcxaVN6cE9pWkRGUWVvKy9aMCs0RUdBYUg3OGFCWmYzdGxuV3hiMGdX?= =?utf-8?B?dzBqaXY4UjU2Nk5hQU51ZkViR2NHVDl0L2lZOGJKT3BFSlFTbzhSSTd4dE41?= =?utf-8?B?MzZaRFduTWNzdndqTVNvaVpXWUpSWEpOSjZJeCtYMGJvMkIzd2VJTzIzbG1O?= =?utf-8?B?Sm54SytEcjRDRlI1THA2Q09rcDBCR0liUUZlenRrNDJVbGRnV1RZL0Y5Q2dO?= =?utf-8?B?a2Y4eTlEZ0E1NDdkaW4vS09mYVVUOXR3VTlJODhHLyt4UnZVN1dVNjNpdEQ2?= =?utf-8?B?WHh4Kyt5Vlplajd4cFZJVnBoWGFKYmZhUEhBbGEvNTJ5Y21BM0xrTXp2WWtX?= =?utf-8?B?RjJiWFdIRDhGbHNUUk1FZWQrblpLTXMyY09JdE85ZTFiS0tYYnpYUTFBUFhl?= =?utf-8?B?eWh6RHJoWGwzUWhEeUQ2Nko2L2VDbFBiUjUvNi9pbzJsQlhOY0Qra2oxZ3pq?= =?utf-8?B?dUdYcFFQbWI4OTFKKzMrWFBYRXJZZ1UyWjQ0ZFFhalV1N1QrUjRZK3dmMmZR?= =?utf-8?B?L2F2bWNDQVNLbTBSKzYrZHFUQXZOMFErbHpMMG10bXo3K0EzRFpMeGt1N3Nn?= =?utf-8?B?WFE2NUJEb2NBcEFSQVhnakxhWElqUERIcnBOMVhIM28ycDhVS2VxazViNDNi?= =?utf-8?B?N1BBWFF4NGRiTURLanlPYkg0Wmx6c3llQ2pMc3lJYkoxdmoxQlhNVTYyKzRV?= =?utf-8?B?WGpRNVJYcDFsWER2L0VBQWpPUUd0Tk5EVEZMVmJPRUhGSHVnUUxIaHQvdTRI?= =?utf-8?B?aFBEdk9Wa2ZIMzV5bllHa1ZQcDVNcldObWRYTitERHJwVGU4RDkrZkZQUlZi?= =?utf-8?B?MWlOOTZhT2RKM09jMlZNdXpiTkVBdXVqVWRNVk42ZDcvSHA3cXAyQ042Zml5?= =?utf-8?B?aWk0NEhUUGhhaXpJZWlPbmgzNXdrendCbXViSjl5amErei9SeUtRYngvZSt6?= =?utf-8?B?NTJrYUh0ZTRHMDhXMk1seXpma2RubEpEUGhGS3dhaC93TTBnYWhnVHNucFRr?= =?utf-8?B?dXcwR1ZMbGMwVUJXNEptazl3NDFiYkRlOEhnWVcxblR3anQ0bGgydG8xemdx?= =?utf-8?B?Wk9yYUtwbTNMYWpxQndkcC9zYXNFckNTUjdpdTd5ZFlqUG1PL3F1dDlZVHJm?= =?utf-8?B?WHhzZVJzeDN0UGRrSWRocGViTGZsL3kvL3VOL1JJZTVza3I2U2dhNHZCbUFn?= =?utf-8?Q?T758yAPZS482/WsbtYbL2hAJdywztVX02RWSg=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U2I1YmxWUFRySTdWVW5xMnUwOXloZnNXYTB0SnhSTVJjcHY2RFNUcENuL2Nt?= =?utf-8?B?Um15SlFDdkJ3VzFGTHM4UHZvZC9qNHFZNHR2aWRiWE04YjY4NFo5Q3A2bk9W?= =?utf-8?B?Q1loenBFTW5WMHpUSnBaS3pLengxNFJWa2wwdjgvTUhwTFN3cVNzMkNjV0Ir?= =?utf-8?B?YUxFZjhIeVl4SUJiQjhVL1F3VTRMVWZzV3JFOWRod2dVeGM5TmhNL202a1cr?= =?utf-8?B?Z0ZjYTBxck1IVFhSTFQvVENTREIrWGZqdlQyMUNVNzhDUzB6Qmx0WW9JLy9w?= =?utf-8?B?Q2FPTXJnVkxLQk5Na1lad1ptdkZKNmgwa1g0SllhOU0wdG80OHpDbE9GdTYx?= =?utf-8?B?UndKZm1CdDkrekdGc1NFbmcvVTdYOXdqcjdZYkI1SW52bGNqenI0R0ZJVnZx?= =?utf-8?B?S3dZcEU2dU8rSk5XWUFBZkJ0dlBDRWpIeFdqM05ONFlNcEpNY0FyaWhWNVht?= =?utf-8?B?ZFYvMVp5ZzBjWnRab0hRbityVzdFL09UVmRwTnV3Njg3MnhIditIZFdhKzla?= =?utf-8?B?L2FnZ0JqT0E0ZTZYSzlRSGJxNlg2WmVTMEJLRjJXZGVOMENGRERBazNLbGp2?= =?utf-8?B?eTZyM3ozNVRQRTRGOHZMWWVOK3EvYnZzVS9ZSXJ6RXIySHFVSE5jTUhOL0dL?= =?utf-8?B?MGpzYzF1VGpiUkRqd1MyZjQ1bTdLMW5NU01GNWVhcjN1aG44alhvQnkvQmlH?= =?utf-8?B?dVlIVHdrR1ZiMlAybHNzSk5WTW01NWZwQllUU1ZBYjZBWnBoRVI5KzZCQ1E3?= =?utf-8?B?d1ZmRFcvQ3NJYzhud0RDL3VGc2FLcS81TmMyb0NIbGp1dUtjQWhzbUJwTTVN?= =?utf-8?B?SURjZVV4SzNPZUZuK2VzSkEvc1c0YkIwWUQyTlQ4bEcwc1JsSkRMSnNUaks0?= =?utf-8?B?cU5MNC94V0prWlNKN2prZHRRUHpDaFJDVzRJY3NBd0FFSCthb3pQbnpJNGs3?= =?utf-8?B?K1h4ZzdwSnhKeVVXcWt5UHF0dVJ0WUJtN2c5UEMrUmpPdGh6UDhZUEUrblZ2?= =?utf-8?B?Z253bDJVUk80V2k4dDVEV3RlNHMxZ2xVSFZJeXptS2d6SzYxRFZiMmtIUUF2?= =?utf-8?B?eGtjMFNMb05yWUNYOGtQdDBXdkNrazhjOW02SmJGbVhoangyczJyL0Q1Q2ov?= =?utf-8?B?WUptMUlwck1zdnMvSDBKdW01S3o3U3BJZXpyMVdTdFhRMURaOTBVMkhXV0ta?= =?utf-8?B?dWZ5NWNhQTI0YThzMTFwY3F0QWlMZ1RYcGd5djY5UkdUVkpMTXJDTXNIM3BY?= =?utf-8?B?Z3ZQQXZ2Yk41UWdXQTFBVjZoZm1xTk1kTGJxZ0lRUkZ5ejlIZnlLVWFiWlJU?= =?utf-8?B?TVJWUWs1MHVaQjVCdW1JN0JHdGUxQUdsOThZelZKc09MN2hFbG5ndHppOFpW?= =?utf-8?B?cDgwOWRsWnRPWlNiblY0RGw5c3ZyQkxlb3NGby9zODZGMmF5Q0ZiYklmZFV4?= =?utf-8?B?SmFTaXYyL055WFloZFdBZURaWUF3eURoMCtzSWZhamx1S3dxMWFvekRueGpu?= =?utf-8?B?ejhkL0xURHlMK1owalBqaysrSVkzSUh0eDNuWXVBM2gxTkl3bTlrZjlBQlpE?= =?utf-8?B?WWRzWEVEelBtVmdMRkY5M2hvTVkzSklTWVFjaXE1c2dibnhUa2Zyc3dvZ0VK?= =?utf-8?B?aXUyYjdmL0NCeHVkSVJkWGEwaWR4dVVVQ0xkemFTWnljMTR0QW0wZW82emdF?= =?utf-8?B?Ui85M3JLQ1Y3OCt1YzJYTlNsb1NtZzlTbzhBVDN5SzlKenJpeGl4MGRaOGNF?= =?utf-8?B?Z1dMZmUydUx0T1I0UWRMaU9TUFdrbG9JMEZPY0VTVHBraHp2OTNBV1VjcUta?= =?utf-8?B?SFdhdGpXazhyUkNaQ3F2cGxWVkwxM0YreHcxLzV4RGdxUTBFcHh1dWV0czFN?= =?utf-8?B?K1VTTEh1d2pKNjJ1YzlIYndFYlJoNy9HdS9uMlAxOE1MZk1ZL1ZnRmpuVysx?= =?utf-8?B?UmhNSk8wTjVkT2hTRnJMdW9RaERJeXpNMmtMQzFUdWR2TkFNeTVkT0FPVHZ0?= =?utf-8?B?Yk5NOFlkUnhkK3ZJRWxobzdTMjhOR0dudlJWbW81Y3MwSWo1Q2h3aGdWUnVj?= =?utf-8?B?d292MEx2d2ZGc09UTkwxLy9Fbzc2S1RUVHI2SUJ2N2FsbEVrczI4RkYrbnQ3?= =?utf-8?Q?IVmVJRFLlvtmfO7pqUOg+b8fY?= Content-Type: multipart/alternative; boundary="_000_CO6PR18MB4484C1008DA16EC9C3E05D5DD88B2CO6PR18MB4484namp_" MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bcd5866-f311-42eb-ad22-08dcc5a61be5 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2024 08:07:20.2522 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uu7S6KjPlv9B3SON6gIn34u6kCOhjd+nsN4OBudjzJTbIUK6t++7sAqyPhyb3Tn4l3MiNWeDNnko0ZPt/UYmlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3620 X-Proofpoint-GUID: ouuIAAJqQyzMlRTwx-oTMKNJ2J_yDtMX X-Proofpoint-ORIG-GUID: ouuIAAJqQyzMlRTwx-oTMKNJ2J_yDtMX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-26_05,2024-08-23_01,2024-05-17_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_CO6PR18MB4484C1008DA16EC9C3E05D5DD88B2CO6PR18MB4484namp_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Kevin, This patch was reverted on main branch. So better not backport. Regards, Akhil From: Kevin Traynor Sent: Friday, August 23, 2024 9:48 PM To: Shihong Wang Cc: Chaoyong He ; Akhil Goyal ; dpdk stable Subject: [EXTERNAL] patch 'examples/ipsec-secgw: fix SA salt endianness' ha= s been queued to stable release 21.11.8 Hi, FYI, your patch has been queued to stable release 21.=E2=80=8A11.=E2=80= =8A8 Note it hasn't been pushed to https:=E2=80=8A//urldefense.=E2=80=8Apro= ofpoint.=E2=80=8Acom/v2/url?u=3Dhttp-3A__dpdk.=E2=80=8Aorg_browse_dpdk-2Dst= able&d=3DDwIDaQ&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2wl_PRwpZ9TWey3eu68gBz= n7DkPwuqhd6WNyo&m=3DjxMUmPULUFoI7N1IfPQX3iPunuqaFfvUiMvebss7a8oZ3g5cSkmT3ow= uWcRrmop6&s=3DGl4YJ1gzyH5_C1fAntP5oV3-o7HB3pTE70HU-jtKq10&e=3D Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to https://urldefense.proofpoint.com/v2/url?u=3D= http-3A__dpdk.org_browse_dpdk-2Dstable&d=3DDwIDaQ&c=3DnKjWec2b6R0mOyPaz7xtf= Q&r=3DDnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DjxMUmPULUFoI7N1IfPQX3= iPunuqaFfvUiMvebss7a8oZ3g5cSkmT3owuWcRrmop6&s=3DGl4YJ1gzyH5_C1fAntP5oV3-o7H= B3pTE70HU-jtKq10&e=3D yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__github.com_kevintray= nor_dpdk-2Dstable&d=3DDwIDaQ&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2wl_PRwpZ= 9TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DjxMUmPULUFoI7N1IfPQX3iPunuqaFfvUiMvebss7a8= oZ3g5cSkmT3owuWcRrmop6&s=3DORkIdcswiYk9iiTtV7ZmbP_zV54GLLsyvnBU72T8PbY&e=3D This queued commit can be viewed at: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__github.com_kevintray= nor_dpdk-2Dstable_commit_db8d7d17a9e8b79c8b6bae2044a6fcb819b33700&d=3DDwIDa= Q&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNy= o&m=3DjxMUmPULUFoI7N1IfPQX3iPunuqaFfvUiMvebss7a8oZ3g5cSkmT3owuWcRrmop6&s=3D= OxADViB5_6ttYifYrSuk4n9QR-FrrZjMHn69AGIDLwg&e=3D Thanks. Kevin --- >From db8d7d17a9e8b79c8b6bae2044a6fcb819b33700 Mon Sep 17 00:00:00 2001 From: Shihong Wang > Date: Thu, 14 Mar 2024 10:00:52 +0800 Subject: [PATCH] examples/ipsec-secgw: fix SA salt endianness MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit [ upstream commit e6bfd9676109f904b4f263402e77105fdca8e67c ] The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it=E2=80= =99s value is stored in an array of encryption or authentication keys according to big-endian. So it maybe need to convert the endianness order to ensure that the value assigned to the SA salt is CPU-endian. Fixes: 50d75cae2a2c ("examples/ipsec-secgw: initialize SA salt") Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional algorithms") Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters") Signed-off-by: Shihong Wang > Reviewed-by: Chaoyong He > Acked-by: Akhil Goyal > --- examples/ipsec-secgw/sa.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index 49d16f055b..af3a92f53e 100644 --- a/examples/ipsec-secgw/sa.c +++ b/examples/ipsec-secgw/sa.c @@ -366,4 +366,5 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, uint32_t *ri /*rule index*/; struct ipsec_sa_cnt *sa_cnt; + rte_be32_t salt; /*big-endian salt*/ uint32_t cipher_algo_p =3D 0; uint32_t auth_algo_p =3D 0; @@ -500,6 +501,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, key_len -=3D 4; rule->cipher_key= _len =3D key_len; - memcpy(&rule->sa= lt, - = &rule->cipher_key[key_len], 4); + memcpy(&salt, &ru= le->cipher_key[key_len], 4); + rule->salt =3D rt= e_be_to_cpu_32(salt); } @@ -565,6 +566,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, rule->auth_key_l= en =3D key_len; rule->iv_len =3D= algo->iv_len; - memcpy(&rule->sa= lt, - = &rule->auth_key[key_len], 4); + memcpy(&salt, &ru= le->auth_key[key_len], 4); + rule->salt =3D rt= e_be_to_cpu_32(salt); } @@ -624,6 +625,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, key_len -=3D 4; rule->cipher_key_len =3D key_le= n; - memcpy(&rule->salt, - &rule->cipher_ke= y[key_len], 4); + memcpy(&salt, &rule->cipher_key[= key_len], 4); + rule->salt =3D rte_be_to_cpu_32(= salt); aead_algo_p =3D 1; -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- - 2024-08-23 17:18:11.871795930 +0100 +++ 0069-examples-ipsec-secgw-fix-SA-salt-endianness.patch 2024-08-23 1= 7:18:09.746430196 +0100 @@ -1 +1 @@ -From e6bfd9676109f904b4f263402e77105fdca8e67c Mon Sep 17 00:00:00 2001 +From db8d7d17a9e8b79c8b6bae2044a6fcb819b33700 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit e6bfd9676109f904b4f263402e77105fdca8e67c ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index c4bac17cd7..8aa9aca739 100644 +index 49d16f055b..af3a92f53e 100644 @@ -30 +31 @@ -@@ -375,4 +375,5 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, +@@ -366,4 +366,5 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, @@ -36 +37 @@ -@@ -509,6 +510,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, +@@ -500,6 +501,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, @@ -45 +46 @@ -@@ -574,6 +575,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, +@@ -565,6 +566,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, @@ -54 +55 @@ -@@ -633,6 +634,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, +@@ -624,6 +625,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, --_000_CO6PR18MB4484C1008DA16EC9C3E05D5DD88B2CO6PR18MB4484namp_ Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Hi Kevin,

This patch was reve= rted on main branch. So better not backport.

 

Regards,=

Akhil

 

From:= Kevin Traynor <ktraynor@redhat.com>
Sent: Friday, August 23, 2024 9:48 PM
To: Shihong Wang <shihong.wang@corigine.com>
Cc: Chaoyong He <chaoyong.he@corigine.com>; Akhil Goyal <ga= khil@marvell.com>; dpdk stable <stable@dpdk.org>
Subject: [EXTERNAL] patch 'examples/ipsec-secgw: fix SA salt endiann= ess' has been queued to stable release 21.11.8

 

Hi, FYI, your patch has been queued to stable r= elease 21.=E2=80=8A11.=E2=80=8A8 Note it hasn't been pushed to https:=E2=80= =8A//urldefense.=E2=80=8Aproofpoint.=E2=80=8Acom/v2/url?u=3Dhttp-3A__dpdk.= =E2=80=8Aorg_browse_dpdk-2Dstable&d=3DDwIDaQ&c=3DnKjWec2b6R0mOyPaz7= xtfQ&r=3DDnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DjxMUmPULUF= oI7N1IfPQX3iPunuqaFfvUiMvebss7a8oZ3g5cSkmT3owuWcRrmop6&s=3DGl4YJ1gzyH5_= C1fAntP5oV3-o7HB3pTE70HU-jtKq10&e=3D

Hi,
 
FYI, your patch has been queued to stable release 21.11.8
 
Note it hasn't been pushed to https://urld=
efense.proofpoint.com/v2/url?u=3Dhttp-3A__dpdk.org_browse_dpdk-2Dstable&=
;d=3DDwIDaQ&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2wl_PRwpZ9TWey3eu6=
8gBzn7DkPwuqhd6WNyo&m=3DjxMUmPULUFoI7N1IfPQX3iPunuqaFfvUiMvebss7a8oZ3g5=
cSkmT3owuWcRrmop6&s=3DGl4YJ1gzyH5_C1fAntP5oV3-o7HB3pTE70HU-jtKq10&e=
=3D yet.
It will be pushed if I get no objections before 08/28/24. So please
shout if anyone has objections.
 
Also note that after the patch there's a diff of the upstream commit vs=
 the
patch applied to the branch. This will indicate if there was any rebasi=
ng
needed to apply to the stable branch. If there were code changes for re=
basing
(ie: not only metadata diffs), please double check that the rebase was<=
o:p>
correctly done.
 
Queued patches are on a temporary branch at:
https://urldefense.proofpoint.com/=
v2/url?u=3Dhttps-3A__github.com_kevintraynor_dpdk-2Dstable&d=3DDwIDaQ&a=
mp;c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqh=
d6WNyo&m=3DjxMUmPULUFoI7N1IfPQX3iPunuqaFfvUiMvebss7a8oZ3g5cSkmT3owuWcRr=
mop6&s=3DORkIdcswiYk9iiTtV7ZmbP_zV54GLLsyvnBU72T8PbY&e=3D<=
/o:p>
 
This queued commit can be viewed at:
https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__github=
.com_kevintraynor_dpdk-2Dstable_commit_db8d7d17a9e8b79c8b6bae2044a6fcb819b3=
3700&d=3DDwIDaQ&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2wl_PRwpZ9=
TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DjxMUmPULUFoI7N1IfPQX3iPunuqaFfvUiMvebss=
7a8oZ3g5cSkmT3owuWcRrmop6&s=3DOxADViB5_6ttYifYrSuk4n9QR-FrrZjMHn69AGIDL=
wg&e=3D
 
Thanks.
 
Kevin
 
---
From db8d7d17a9e8b79c8b6bae2044a6fcb819b33700 Mon Sep 17 00:00:00 2001<=
o:p>
From: Shihong Wang <shi=
hong.wang@corigine.com>
Date: Thu, 14 Mar 2024 10:00:52 +0800
Subject: [PATCH] examples/ipsec-secgw: fix SA salt endianness
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit
 
[ upstream commit e6bfd9676109f904b4f263402e77105fdca8e67c ]=

 
The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it=E2=
=80=99s
value is stored in an array of encryption or authentication keys
according to big-endian. So it maybe need to convert the endianness
order to ensure that the value assigned to the SA salt is CPU-endian.
 
Fixes: 50d75cae2a2c ("examples/ipsec-secgw: initialize SA salt&quo=
t;)
Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional alg=
orithms")
Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters&qu=
ot;)
 
Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Acked-by: Akhil Goyal <gakhil@=
marvell.com>
---
 examples/ipsec-secgw/sa.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
 
diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c=

index 49d16f055b..af3a92f53e 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -366,4 +366,5 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,
            &nbs=
p; uint32_t *ri /*rule index*/;
            &nbs=
p; struct ipsec_sa_cnt *sa_cnt;
+           rte_be32_=
t salt; /*big-endian salt*/
            &nbs=
p; uint32_t cipher_algo_p =3D 0;
            &nbs=
p; uint32_t auth_algo_p =3D 0;
@@ -500,6 +501,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,
            &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;        key_len -=3D 4;<=
/span>
            &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;        rule->cipher_key_len =3D=
 key_len;
-           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;        memcpy(&rule->salt,<=
o:p>
-           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;           &nbs=
p;            &r=
ule->cipher_key[key_len], 4);
+           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;       memcpy(&salt, &rule->c=
ipher_key[key_len], 4);
+           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;       rule->salt =3D rte_be_to_cpu_3=
2(salt);
            &nbs=
p;            &=
nbsp;           &nbs=
p;      }
 
@@ -565,6 +566,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,
            &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;        rule->auth_key_len =3D k=
ey_len;
            &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;        rule->iv_len =3D algo-&g=
t;iv_len;
-           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;        memcpy(&rule->salt,<=
o:p>
-           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;           &nbs=
p;            &r=
ule->auth_key[key_len], 4);
+           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;       memcpy(&salt, &rule->a=
uth_key[key_len], 4);
+           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;       rule->salt =3D rte_be_to_cpu_3=
2(salt);
            &nbs=
p;            &=
nbsp;           &nbs=
p;      }
 
@@ -624,6 +625,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,
            &nbs=
p;            &=
nbsp;           &nbs=
p;      key_len -=3D 4;
            &nbs=
p;            &=
nbsp;           &nbs=
p;      rule->cipher_key_len =3D key_len;<=
/o:p>
-           &nbs=
p;            &=
nbsp;           &nbs=
p;      memcpy(&rule->salt,
-           &nbs=
p;            &=
nbsp;           &nbs=
p;            &=
nbsp;        &rule->cipher_key[ke=
y_len], 4);
+           &nbs=
p;            &=
nbsp;           &nbs=
p;     memcpy(&salt, &rule->cipher_key[key_l=
en], 4);
+           &nbs=
p;            &=
nbsp;           &nbs=
p;     rule->salt =3D rte_be_to_cpu_32(salt);
 
            =
;            &n=
bsp;            =
;       aead_algo_p =3D 1;<=
/pre>

-- 


2.46.0


 


---


  Diff of the applied patch vs upstream commit (please double-chec=
k if non-empty:


---


--- -        2024-08-23 17:18:11.871=
795930 +0100


+++ 0069-examples-ipsec-secgw-fix-SA-salt-endianness.patch  &=
nbsp;  2024-08-23 17:18:09.746430196 +0100


@@ -1 +1 @@


-From e6bfd9676109f904b4f263402e77105fdca8e67c Mon Sep 17 00:00:00 2001=



+From db8d7d17a9e8b79c8b6bae2044a6fcb819b33700 Mon Sep 17 00:00:00 2001=



@@ -8,0 +9,2 @@


+[ upstream commit e6bfd9676109f904b4f263402e77105fdca8e67c ]


+


@@ -17 +18,0 @@


-Cc: stable@dpdk.org<=
/span>


@@ -27 +28 @@


-index c4bac17cd7..8aa9aca739 100644


+index 49d16f055b..af3a92f53e 100644


@@ -30 +31 @@


-@@ -375,4 +375,5 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,<=
o:p>


+@@ -366,4 +366,5 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,<=
o:p>


@@ -36 +37 @@


-@@ -509,6 +510,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,<=
o:p>


+@@ -500,6 +501,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,<=
o:p>


@@ -45 +46 @@


-@@ -574,6 +575,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,<=
o:p>


+@@ -565,6 +566,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,<=
o:p>


@@ -54 +55 @@


-@@ -633,6 +634,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,<=
o:p>


+@@ -624,6 +625,6 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,<=
o:p>


 
--_000_CO6PR18MB4484C1008DA16EC9C3E05D5DD88B2CO6PR18MB4484namp_--