From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58864A09EF for ; Wed, 23 Dec 2020 07:06:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 056FDCA74; Wed, 23 Dec 2020 07:06:34 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3310FCA49; Wed, 23 Dec 2020 07:06:30 +0100 (CET) IronPort-SDR: kbWghZnciU96IqsWLIyZhAcmSgXL5FouPKmMt2tAtZ8BzkQk76OaXtObLyzqlTvTWqMHhJZcAo +fcthfbCD7pQ== X-IronPort-AV: E=McAfee;i="6000,8403,9843"; a="237527875" X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="237527875" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2020 22:06:27 -0800 IronPort-SDR: XShk+P9H7E4/ptI28Ti+yWft1GkGRrixeffdqjPy4KrYLt7hCMUAcFgu0+G4ax3WDHd1GlJUSy juGE+kgHZhOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="457864281" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 22 Dec 2020 22:06:27 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 22:06:27 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 22:06:26 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Dec 2020 22:06:26 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Dec 2020 22:06:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxA6SX8UDtnPxU+4ijJ6A3jN5LFDV0F4zU/pDZdWCCscQ4xyoaym+oOmodezNViivFqKxmk7SXL7tkgOtBa9QGVzSaEvybtUMDo10qc8hnLzPStkgl8b22xX1RtXPhi6qkEn9yRwyMr/xp5kYRdsNviYht4N45nb2gt+ONxthaJgBApLHxDksCn+SoY2LUGixPwPDDQJ13ViewJ3P3/sF6U81WpH8bAS3BtrxVjXxViDHV5DwXYnff0WacsfjTH39FsgqmL0V1aBRbo8aQd8BlylNGltIw0iGzb0f+QKbQLuSSsyhXe5FwNNI5FXjBwgFY7pEF+9ndHj5mNMo5Ootw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+CAneKPu/QJ81OxUbz6PjbRBcndOYbhACtaxmGHWyAk=; b=W6Z+TrFlIIYK619+kV57GvPP7cJerI5OgDftP0WW9IA3XhGUSvtW00qjnlNXehJnI481B8ykW2TiBvcl0e89sfL12Hs0GPtmpUTAQ+AcsSKtjY9ggpqD+mpCD0vu1TSHiSzOXFrebVv1i4wjYiP1uqyyDTHd/0Yh7HLPZCKowPy57SmNprJIIFaOCg68fmN1+Yf0ptc+OvqBygPKYrvaBTAoU2dQHcsCLly7ZWV0KLoHATT0u0XUVw/TY9qdqawGBpxN8yuCmkljYeTWkUmvvsdQOGE+gO9TEpycu5swsA+wJKRa8h3S6AvijC1szeNe+zXJUsjdKq3UzLZvpoQGBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+CAneKPu/QJ81OxUbz6PjbRBcndOYbhACtaxmGHWyAk=; b=hq+DrrUx0axRfIFwYlI77uQHsCVooT44Xfu3MHlNmdt1ji+xJsMvz7xzUjOjW1OiZH1LcpNbpy8Sp7d+2AzHZsKHEEzWZZRLFVoobzOf++VKmzjyQ6C+bhFOuOql8J41BXLIwu30NO+1Ufov6WQowe9luJXC9fyElEflz33MDx0= Received: from CY4PR1101MB2069.namprd11.prod.outlook.com (2603:10b6:910:17::7) by CY4PR11MB1671.namprd11.prod.outlook.com (2603:10b6:910:9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.31; Wed, 23 Dec 2020 06:06:25 +0000 Received: from CY4PR1101MB2069.namprd11.prod.outlook.com ([fe80::517e:53c:fca7:7668]) by CY4PR1101MB2069.namprd11.prod.outlook.com ([fe80::517e:53c:fca7:7668%9]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 06:06:25 +0000 From: "Xu, Ting" To: "Zhang, AlvinX" , "Xing, Beilei" CC: "dev@dpdk.org" , "Zhang, AlvinX" , "stable@dpdk.org" Thread-Topic: [PATCH] net/iavf: fix queue pairs configuration Thread-Index: AQHW2OykFMizAk5fp0qCwEL+Ck34TqoELlpw Date: Wed, 23 Dec 2020 06:06:25 +0000 Message-ID: References: <20201223052936.7200-1-alvinx.zhang@intel.com> In-Reply-To: <20201223052936.7200-1-alvinx.zhang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 581e3b4e-9fa0-429d-cdac-08d8a708e154 x-ms-traffictypediagnostic: CY4PR11MB1671: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YrSfoDqS7vF3muY9T29hisGfGAA+vRLpRfBsCLAH2wjBe39qlJXf/XNYfccyXMbpgzjl6poXffpjorxrFED0BpdVYWInU1QTqI2N06tyr4ATN1CPsNqqQKlM3Kl/E0lhUcDeQxxUN3Eh2Rv3Q5ITSG7+RmvuYnbmMX389DRm6j9ECtJa1pJokziZ6Xw8NN1alfQwPficPpqPIsVqJ4Jbvwcq85cyU2J6YxyoOBelMvLBFr+8vbRanB9yUAofJ/9ygM1sOHX5u3mmvsapTdd//z0j8XWpfUWqv1rO9AjzagB0WVk4vKDjXNJqSWMnOxTphaVKklXu7BfGLI2krOtgBF3tgS0PwDr8nrYmf5w2Id7o/Y8E4Vxm3PUzDBpUpxDU+HNWddUP8UbliiOeLgrCTA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2069.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(83380400001)(76116006)(6506007)(66446008)(66476007)(2906002)(52536014)(86362001)(7696005)(8936002)(6636002)(8676002)(5660300002)(71200400001)(26005)(64756008)(53546011)(186003)(54906003)(316002)(66946007)(478600001)(450100002)(66556008)(55016002)(33656002)(110136005)(4326008)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?WrxRrPjnWI2kRil7j08Nh0233ICiGk8dbkLfIYqQ8sYe83NzQnwWv0HhXxQM?= =?us-ascii?Q?8zpi8Bvs4IzjD1ozyAj/QdU97PnKcpnsXESpdYbJdXP+guQGRv18g32IZlEL?= =?us-ascii?Q?otQCpA+nk7a5tli/uSE+Z4AvdPrP+Qp+Sd4/f2I+l4MhcrzXhYVTVWwDv2Kt?= =?us-ascii?Q?+iAUzShHW95bJ9/ARp8FM1FJdGyrrNy1Bd8/N921Q0a0A4R3DiC5oqx6dIuB?= =?us-ascii?Q?B8Hl5l+44FU6oLfThWE+9PipvsJPfVRcCxm+cok2h+fyCzOGgwvZ8aJ2Jela?= =?us-ascii?Q?/Jjy03yimlk+qTOHyZ/hxT7ZmARS53BCwPzw4MOf/EOhIyMCPtmRQYaKTng6?= =?us-ascii?Q?N/Wvc17bLnVKvzzzlKgNY3ShXRPPNMfgDAniR6RuEvvUoBU3piPGQuWXFeKC?= =?us-ascii?Q?vd4rDdA6TJ2yTln6PYm9GLa/Th7RbkA+oryozNVdVVwI0pmgmu8SW3f/6Lde?= =?us-ascii?Q?3PtJYUEV/aK+vxivBK03mjznupkmWxrcnc1SzTJwZBPJ15M/prvQfmdMJmt3?= =?us-ascii?Q?sbrlf227WoU0zFLDiOeq1WwytDeN8wfFLbRf0kQTxk6ad/Klj2b9QUJwMBYF?= =?us-ascii?Q?6zpM9DuIApxftDr/MdQlmM6sCcWBGZzk/TiIXqBk2MFtgv2yZpypn0VdKsUY?= =?us-ascii?Q?fhnFz6WF7CtZCf+T5kfrlwWhLrbPDlUlFAN7zbQKjhFWq2VM0/zvDNndrxvy?= =?us-ascii?Q?nKFo4YQ4wJx2Pe20SoP96phb98vIJfx4+YH0//1DyTi1iCkAi160I3K0Q0RI?= =?us-ascii?Q?NJVgZE8BCa5/I5tBjQSwdPg7ofR7GPex2csErkX69LD47/iXEPGcS3dqBmOl?= =?us-ascii?Q?u/wvSjA0YWE69jWFRl7vevEUzvqP2iaCF7iVQe0h2JmwisVlmjsHK2M/5/CI?= =?us-ascii?Q?MRXGIn6uZyiI94VgXCD9h7uMzxnN4GeCBmxjWs/BMqZXDgSNmRuGABWUDt5f?= =?us-ascii?Q?IJ18zRRA4Jj6vWcLz33LQ4C2T1WXdk+mNn/ZoUZ1F4w=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2069.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 581e3b4e-9fa0-429d-cdac-08d8a708e154 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 06:06:25.4073 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nJqIgoVzs4qZAjHrwpjM2BpQLdrPEJcNiqM/+B1y+J29eFksFHYqeAHZjy6ZFKlWUzxPwv+2jRumNvgDGm2h4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1671 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Alvin, > -----Original Message----- > From: Zhang,Alvin > Sent: Wednesday, December 23, 2020 1:30 PM > To: Xing, Beilei ; Xu, Ting > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [PATCH] net/iavf: fix queue pairs configuration >=20 > From: Alvin Zhang >=20 > Check if there are enough queue pairs currently allocated, and if not, re= quest > PF to allocate them. >=20 > Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queue= s") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alvin Zhang > --- > drivers/net/iavf/iavf_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index 7e3c26a..f015121 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -372,8 +372,10 @@ struct rte_iavf_xstats_name_off { > } else { > /* Check if large VF is already enabled. If so, disable and > * release redundant queue resource. > + * Or check if enough queue pairs. If not, request them from > PF. > */ > - if (vf->lv_enabled) { > + if (vf->lv_enabled || > + num_queue_pairs > vf->vsi_res->num_queue_pairs) { > ret =3D iavf_queues_req_reset(dev, num_queue_pairs); > if (ret) > return ret; > -- > 1.8.3.1 Will it be better to change ret =3D iavf_queues_req_reset(dev, num_queue_pa= irs); to ret =3D iavf_queues_req_reset(dev, IAVF_MAX_NUM_QUEUES_DFLT); base= d on the original codes? Since PF provides default 16 queue pairs to VF. If large VF is no need to b= e enabled, it may be better to reset the queue pairs number to 16. So that = we don't need to compare the queue pairs number and request queues each tim= e when it is no more than 16. If more, it turns to large VF to handle. The original codes here are not good. Thanks.