patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)" <jgrajcia@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Tianyu Li <Tianyu.Li@arm.com>,
	"Damjan Marion (damarion)" <damarion@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
Date: Tue, 18 May 2021 16:57:24 +0000
Message-ID: <CY4PR1101MB2102E1D654948B5791622861DF2C9@CY4PR1101MB2102.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5bb1142c-16f1-9a1b-4408-83c2857da9f2@intel.com>

Hi,

Sorry for the inconvenience, the thread got filtered so I only found it in spam after Damjan notified me.

The patch looks good. Thanks for the fix!

Reviewd-By: Jakub Grajciar <jgrajcia@cisco.com>

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, May 18, 2021 2:09 PM
> To: Tianyu Li <Tianyu.Li@arm.com>; Jakub Grajciar -X (jgrajcia - PANTHEON
> TECH SRO at Cisco) <jgrajcia@cisco.com>; Damjan Marion (damarion)
> <damarion@cisco.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
> 
> On 4/27/2021 7:30 AM, Tianyu Li wrote:
> > Hi Jakub,
> >
> > Any comments about the patch?
> >
> 
> +Damjan.
> 
> Hi Damjan,
> 
> Is Jakub still maintaining the net/memif?
> 
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Sent: Wednesday, April 14, 2021 4:13 PM
> > To: Tianyu Li <Tianyu.Li@arm.com>; Jakub Grajciar <jgrajcia@cisco.com>
> > Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
> > Subject: Re: [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
> >
> > On 4/12/2021 9:22 AM, Tianyu Li wrote:
> >> Fix the missing Tx-bps counter for memif zero-copy mode Before
> >>    Rx-pps:      6891450          Rx-bps:   3528438928
> >>    Tx-pps:      6891482          Tx-bps:            0
> >> After
> >>    Throughput (since last show)
> >>    Rx-pps:     11157056          Rx-bps:   5712413016
> >>    Tx-pps:     11157056          Tx-bps:   5712413016
> >>
> >> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Tianyu Li <tianyu.li@arm.com>
> >> ---
> >>   drivers/net/memif/rte_eth_memif.c | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/net/memif/rte_eth_memif.c
> >> b/drivers/net/memif/rte_eth_memif.c
> >> index 77c95bcb7..dd2825968 100644
> >> --- a/drivers/net/memif/rte_eth_memif.c
> >> +++ b/drivers/net/memif/rte_eth_memif.c
> >> @@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private
> *proc_private, struct memif_queue *mq
> >>   	/* populate descriptor */
> >>   	d0 = &ring->desc[slot & mask];
> >>   	d0->length = rte_pktmbuf_data_len(mbuf);
> >> +	mq->n_bytes += rte_pktmbuf_data_len(mbuf);
> >>   	/* FIXME: get region index */
> >>   	d0->region = 1;
> >>   	d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) -
> >>
> >
> > Looks good to me, but let's wait Jakub's review for it.
> >


  reply	other threads:[~2021-05-18 16:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12  8:22 Tianyu Li
2021-04-14  8:13 ` Ferruh Yigit
2021-04-27  6:30   ` Tianyu Li
2021-05-18 12:08     ` Ferruh Yigit
2021-05-18 16:57       ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) [this message]
2021-05-19  7:57 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1101MB2102E1D654948B5791622861DF2C9@CY4PR1101MB2102.namprd11.prod.outlook.com \
    --to=jgrajcia@cisco.com \
    --cc=Tianyu.Li@arm.com \
    --cc=damarion@cisco.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git