From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EEEEA04BA for ; Wed, 7 Oct 2020 12:15:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED97FA3; Wed, 7 Oct 2020 12:15:46 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 87320A3; Wed, 7 Oct 2020 12:15:44 +0200 (CEST) IronPort-SDR: sXwvWBcHhpw7s6/VOIE24deLuS4jTUWA8dGTnLgbYTCpoJ31xK0t+noE6cr0HcWVvdPHVgUqQz BqJBd2qM+gPw== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="152653786" X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="152653786" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 03:15:43 -0700 IronPort-SDR: Aj0/KQmCUoj0gcIgHCoUB3KAzOr3xnFv+5CdAlBKpRw55j9/fitvXWx3RJrv2EsQRjLcb+rhgp MhTdqB++X5IQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="342796969" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 07 Oct 2020 03:15:43 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 03:15:42 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 03:15:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 7 Oct 2020 03:15:41 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.52) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 7 Oct 2020 03:15:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXd1C/+5aPxoBvKstHbULIiA1DXQhl7sTyxQYfYzdlSnMTkbZvo2OimEnLu7Q7wCqKowaxnMajdMotFjnXHg6Dqy7c4Lp2k8NksOz6Bih8H4SZHLeoAetFaxaRA6DMLy9iwtf1z9LeSr9LIF8ZqvP/CfT84vgFaociZY5A33omJhgIX+jiIzK9kBJ9h2+WP2iT9lrF6/iR+kLJ9PAL3vyompvHEboidVqPz6C3uAagj03qxvbN1nAE+7dYtMlfyQin9SKXsFhMRuXjAH9et4ftZsKT529X9QitXxKvUBqJ+CjN2KXRvM7GZt6G1dpkaX9bCxit1feteg+sjKIyKtIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wo0frZ5RfiLxrnIBWRVyBEuQrqS1+7MNMWP6gq7Df4s=; b=PAbgA2oFMxjeXghcQYqGdM3pT4gHsYvRnMI1Org4MsJsgGfSZyNwyt6+a0QVWcMqmvnmnoQSg9I+2XrotLSWnMRtvVRyg4Hx7IUgM0cQEsg31JsxA5HpWRxsRotJ5AgYluE0jax8vzMyyZH6WAflil5/YYIrLR1cFHp0r2lXQAk4DXFWSHcNQgrccnl22r9Mp7SejpT/tQl5CHe59HHdX53hvxqwnd3CfQRtbmoACq4stLybwvueeRtcFyw9mHRFxPQKuPBsxFzbW6dwRXuKCTufDjsx3iSu1Q0piIJw4TD9NzpU0ARysNnI7+MVsUKMJXvmj4lw+Gex/QoKjuBvRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wo0frZ5RfiLxrnIBWRVyBEuQrqS1+7MNMWP6gq7Df4s=; b=VBUrhxZS8z1WmXLRXnWI4MdoAxOqNgb8qyoR2qdqGnhlZURSYYrwvS0RAN/uyjo2eN9Jl7wtXvlxw67joq+S1J1pkVJ8N16Wr9eXUC32pCQlAuIvLVuIesBeDh7ajkXdKgoig29W1n7gYyCOUFRuNRX+9Nz/rw+F3d4t8jYae8E= Received: from CY4PR1101MB2296.namprd11.prod.outlook.com (2603:10b6:910:1a::15) by CY4PR11MB0071.namprd11.prod.outlook.com (2603:10b6:910:7a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.43; Wed, 7 Oct 2020 10:15:17 +0000 Received: from CY4PR1101MB2296.namprd11.prod.outlook.com ([fe80::80c9:e4f1:ec68:6e64]) by CY4PR1101MB2296.namprd11.prod.outlook.com ([fe80::80c9:e4f1:ec68:6e64%5]) with mapi id 15.20.3455.023; Wed, 7 Oct 2020 10:15:16 +0000 From: "Rao, Nikhil" To: "Jayatheerthan, Jay" , "jerinj@marvell.com" , "thomas@monjalon.net" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Jayatheerthan, Jay" Thread-Topic: [PATCH 2/2] app/test: add net null dev creation in Rx adapter autotest Thread-Index: AQHWmWVP9saJgmbmy0KHBhYsftq+q6mL8mXg Date: Wed, 7 Oct 2020 10:15:16 +0000 Message-ID: References: <20201003090541.32449-1-jay.jayatheerthan@intel.com> <20201003090541.32449-2-jay.jayatheerthan@intel.com> In-Reply-To: <20201003090541.32449-2-jay.jayatheerthan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [106.201.40.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ce3c4da-d22f-49a2-4cbd-08d86aa9e35f x-ms-traffictypediagnostic: CY4PR11MB0071: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BHpDTL9cMpgm7qvcPhCHBXc8q3stZbOqteL1SwCkOdkdCus6mapTYydUa5M7qb/SosaCVewqsHOUOezzdULdoIEygrJADwSg68jQS7tQfFrjMCpJThft+Vktg20R+f8yNBrj5JzIWU5z759tVu+ZfmtdAXx8/f9ZFXs3sD27W6yvCl32u0gjNm5V0FWxil0oMEwighrTb0uwcp2hWIK807Phclw/PO+8U/chu/NmtvYT35ArMLuC7ScjnkJbx3S0dphKZeNmLn0rJ6xwjWAwJaTPLPGdwHquulU2IuZ8rGlgb7q+S+W4IVs4L2HvYPgCmsJgCnL8MNw6tD8HCjqd7w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2296.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(366004)(136003)(39860400002)(346002)(7696005)(71200400001)(55236004)(53546011)(33656002)(54906003)(83380400001)(6506007)(66946007)(76116006)(110136005)(66446008)(66476007)(55016002)(66556008)(64756008)(186003)(8936002)(9686003)(4326008)(52536014)(316002)(2906002)(86362001)(5660300002)(8676002)(478600001)(107886003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 8WwzloxcsgcdhACdq+550Qcj82IM0fhBOTohG4z0CynSkSbvuoLcHSOB39eno/HLax5nGn4IKwcLQpZGquAH/5+J+YM6ejnPCTjHdNwqcEYcZzV1Ze1h/JbnA67YZ9zo7ubTUYF5Qa+ojrjZ4PH1cezq1N3rFnN4/l5E+iENHb5EWL73ngfna3y9WVnoOdI51s6fi1Cmab2EPNcG+/6fEwD60J3ToJwy/i1HFyZ3h2YZ1+xCllE5MZ8jCOP4FgBwpgdCWvpgQhgKITaH0kk2WHarcntYx3S3ni0J4xT+nveazwVO7A9QSehIFy2N9tdzMaES9wwfkX3cP0Np83pgwTYPodXsZrEo83TYnqQSt5CFwL/DA6m9a5q4f9vbcTK8Nn6Ur3EjLrwmDXmiRACEV213o6vYoUsj1P0Va75ei/yTYc33+TvsElZoivnOTu7xGBz63Hv4c32ddQkpFHTX84zvvPRMcjEWbNCApG7BBkNabhVNP/1USZW5w03692iAL8KDDpKCZMxazQ5y9bMZ4CNpnqkZFYN/v5SKbssO3dLVJbPyO5ZLjR10KbWHjW+/IMed3SiFa/XGE0LS+uq6xqLj//tmjPYEj6azWjGbw8lALWLk7sEuqhNKcp9OlIqCV/hScbra6Zo4Ai94G2LjJA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2296.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce3c4da-d22f-49a2-4cbd-08d86aa9e35f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 10:15:16.7457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pCSWNxS4q6zcCDCm1DRaNj862Gbs1nTHV9uZrFCk66MNqTWE28huDiJBS0JTdxeFO4vT9hCn3BFiXVT6tasGaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB0071 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH 2/2] app/test: add net null dev creation in Rx adapter autotest X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Jayatheerthan, Jay > Sent: Saturday, October 3, 2020 2:36 PM > To: jerinj@marvell.com; thomas@monjalon.net; Rao, Nikhil > > Cc: dev@dpdk.org; stable@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH 2/2] app/test: add net null dev creation in Rx adapter > autotest >=20 > From: "Jay Jayatheerthan" >=20 > Allows creation of net_null if vdev EAL option is not specified and unini= t vdev > created in the test. The change also adds error checks for vdev init and = uninit. >=20 > Signed-off-by: Jay Jayatheerthan > --- > app/test/test_event_eth_rx_adapter.c | 61 +++++++++++++++++++++++++++- > 1 file changed, 59 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_event_eth_rx_adapter.c > b/app/test/test_event_eth_rx_adapter.c > index 71c946164..dbf85be35 100644 > --- a/app/test/test_event_eth_rx_adapter.c > +++ b/app/test/test_event_eth_rx_adapter.c > @@ -30,6 +30,8 @@ struct event_eth_rx_adapter_test_params { }; >=20 > static struct event_eth_rx_adapter_test_params default_params; > +static bool event_dev_created; > +static bool eth_dev_created; >=20 > static inline int > port_init_common(uint16_t port, const struct rte_eth_conf *port_conf, @@= - > 202,7 +204,10 @@ testsuite_setup(void) > if (!count) { > printf("Failed to find a valid event device," > " testing with event_skeleton device\n"); > - rte_vdev_init("event_skeleton", NULL); > + err =3D rte_vdev_init("event_skeleton", NULL); > + TEST_ASSERT(err =3D=3D 0, "Failed to create event_skeleton. > err=3D%d", > + err); > + event_dev_created =3D true; > } >=20 > struct rte_event_dev_config config =3D { @@ -222,6 +227,15 @@ > testsuite_setup(void) > TEST_ASSERT(err =3D=3D 0, "Event device initialization failed err %d\n"= , > err); >=20 > + count =3D rte_eth_dev_count_total(); > + if (!count) { > + printf("Testing with net_null device\n"); > + err =3D rte_vdev_init("net_null", NULL); > + TEST_ASSERT(err =3D=3D 0, "Failed to create net_null. err=3D%d", > + err); > + eth_dev_created =3D true; > + } > + > /* > * eth devices like octeontx use event device to receive packets > * so rte_eth_dev_start invokes rte_event_dev_start internally, so > @@ -249,7 +263,10 @@ testsuite_setup_rx_intr(void) > if (!count) { > printf("Failed to find a valid event device," > " testing with event_skeleton device\n"); > - rte_vdev_init("event_skeleton", NULL); > + err =3D rte_vdev_init("event_skeleton", NULL); > + TEST_ASSERT(err =3D=3D 0, "Failed to create event_skeleton. > err=3D%d", > + err); > + event_dev_created =3D true; > } >=20 > struct rte_event_dev_config config =3D { @@ -270,6 +287,15 @@ > testsuite_setup_rx_intr(void) > TEST_ASSERT(err =3D=3D 0, "Event device initialization failed err %d\n"= , > err); >=20 > + count =3D rte_eth_dev_count_total(); > + if (!count) { > + printf("Testing with net_null device\n"); > + err =3D rte_vdev_init("net_null", NULL); > + TEST_ASSERT(err =3D=3D 0, "Failed to create net_null. err=3D%d", > + err); > + eth_dev_created =3D true; > + } > + > /* > * eth devices like octeontx use event device to receive packets > * so rte_eth_dev_start invokes rte_event_dev_start internally, so > @@ -292,21 +318,52 @@ testsuite_setup_rx_intr(void) static void > testsuite_teardown(void) > { > + int err; > uint32_t i; > RTE_ETH_FOREACH_DEV(i) > rte_eth_dev_stop(i); >=20 > + if (eth_dev_created) { > + err =3D rte_vdev_uninit("net_null"); > + if (err) > + printf("Failed to delete net_null. err=3D%d", err); > + eth_dev_created =3D false; > + } > + > rte_mempool_free(default_params.mp); > + if (event_dev_created) { > + err =3D rte_vdev_uninit("event_skeleton"); > + if (err) > + printf("Failed to delete event_skeleton. err=3D%d", err); > + event_dev_created =3D false; > + } > + > + memset(&default_params, 0, sizeof(default_params)); > } >=20 > static void > testsuite_teardown_rx_intr(void) > { > + int err; > if (!default_params.rx_intr_port_inited) > return; >=20 > rte_eth_dev_stop(default_params.rx_intr_port); > + if (eth_dev_created) { > + err =3D rte_vdev_uninit("net_null"); > + if (err) > + printf("Failed to delete net_null. err=3D%d", err); > + eth_dev_created =3D false; > + } > rte_mempool_free(default_params.mp); > + if (event_dev_created) { > + err =3D rte_vdev_uninit("event_skeleton"); > + if (err) > + printf("Failed to delete event_skeleton. err=3D%d", err); > + event_dev_created =3D false; > + } > + > + memset(&default_params, 0, sizeof(default_params)); > } >=20 > static int > -- > 2.17.1 Reviewed-by: Nikhil Rao