From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09056A04A6 for ; Thu, 6 Aug 2020 17:40:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B62BA1C033; Thu, 6 Aug 2020 17:40:23 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 905972B87; Thu, 6 Aug 2020 17:40:19 +0200 (CEST) IronPort-SDR: xPC3kZVXm9098JcRNH4KviItf/cmWrSgCfU117ODFYJpTi2dxNHLq9+I9svZ/4KNEVTO0DuoQd IoMHbi4JT6Xw== X-IronPort-AV: E=McAfee;i="6000,8403,9704"; a="237692847" X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="237692847" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2020 08:40:18 -0700 IronPort-SDR: I9g+NAyUC0o/VGpt6CiLPnHCVeTTFBbxQbNV+gtbeo27hoqEfyUyy9j0PJSH2IKYN0GIFrSPO/ g0a4wu8rG6EA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="289307925" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 06 Aug 2020 08:40:18 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 6 Aug 2020 08:40:17 -0700 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 6 Aug 2020 08:40:17 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX112.amr.corp.intel.com (10.22.240.13) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Aug 2020 08:40:16 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Aug 2020 08:40:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oqrg9yabP+8oc8paKB7U5DP1jp2l/8KnMR/KZ8DXOi9kLSpkMuyOUN43SACvTYQ16CSoqrkl3TcZn7U6Nwajv6uVsTbalh7UYqhc1g9URdO23y00DpgjNCpwaixQqJhNfRNyYEQvBQV99nfHPb9IMDS31gpXajwEYwlL5KeheejYtb2y2yAMcGExKyLNUTFogn2hiZQcgeK7MS9TqmXVJCU+jM7lwR45oZDBhPYmLePDCQ45n2IsdtTtgudpX9CVTXpdfoUuH2+ADN0/UJdkUGue51AVSOAr225/9Aaxt4HNG83a7iYCqZA9laBxd/78rlm5/afIq8Fk/lR/IOfE2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xt8w0HPfmeKm/ZKfEzX9ZZiZI/HgViwN+LhFS180l2g=; b=mrorNZRm1UldkjNJDAPOhdptLqFPIH+mzqeqHvzl+WuoPhcItjJqzp25gBwtxqXhsl2yM02H+qzpA9+JHR4vS20Rn1vL7785jQO7FlshL8ozlcxUXMftC9hDCssUE+n1XK+RqVwgWQJMuLtEF9NNYz/4n+YHxksk7D+d/JaVjOmYwGvlSzBqKzVUEDJuLiRrKcUTEWwszS2YnorRvKBMZlHPKmviP0o0FwezZ66PHkygMojEeDe8x4dePOdPP01/1mbUC2tdccmPERissDecsa5QsinDxwb86vH4bC3wd2CsTAvBu2Gc1lLasnhF0ZlrkKqg7aTJRywJXgcH/tztFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xt8w0HPfmeKm/ZKfEzX9ZZiZI/HgViwN+LhFS180l2g=; b=vPaQRssVd/3CIsuFGxDmYdva1Xv2dKnsy315DkhVSVAUKU/vG/yFuGB9iGSvgNJEyrJNXYoDEomoQPd8Bh4DDWEPrwhOf6Ade4vz3wZ/DWDxck3LLzspiSqDy+4p54sZJBxp71XdORdgY7l6paq5AFSex8J551/RHhfKRwzHu6o= Received: from CY4PR1101MB2296.namprd11.prod.outlook.com (2603:10b6:910:1a::15) by CY4PR11MB1463.namprd11.prod.outlook.com (2603:10b6:910:3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Thu, 6 Aug 2020 15:40:14 +0000 Received: from CY4PR1101MB2296.namprd11.prod.outlook.com ([fe80::dc33:1e4c:a792:b1ed]) by CY4PR1101MB2296.namprd11.prod.outlook.com ([fe80::dc33:1e4c:a792:b1ed%6]) with mapi id 15.20.3261.019; Thu, 6 Aug 2020 15:40:14 +0000 From: "Rao, Nikhil" To: wangyunjian , "dev@dpdk.org" CC: "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked Thread-Index: AQHWZB7KOPARt544/0+7/v1xoQEb1akrRxfw Date: Thu, 6 Aug 2020 15:40:14 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [106.51.27.115] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be9d88a2-93ad-4015-0b1f-08d83a1f0366 x-ms-traffictypediagnostic: CY4PR11MB1463: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s+G8GDTZJ4y4fQe/IawvkkC5tSvAE4kw6YIrSmd6FJsOm73YVyw53X8Emk/U8c992BwkIntgZ7yHZvfrGTvsD4iRqmwXEugUvDvhGmfibBMfuP37k0skSY9lAQCUXrXwW7r/f7CKNn0ecl3MgGf4a3/o/FQPJ62XgnNhkpePZj3Gr/6bwvjnp6lq3SjmnnyghSaZQGjTf7G8hJpQN0foa5ok7ICge4qUlyjWOHkSvtl+u0JTpPGJMXxUj3+QMGe2ADuQNcI/9TPIA21wXPGGC/+ftEXLUbILp18cGXXKMn/YozEoNNFz6osKwUzqrCUP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2296.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(39860400002)(136003)(346002)(396003)(83380400001)(86362001)(26005)(8936002)(186003)(54906003)(110136005)(478600001)(8676002)(5660300002)(53546011)(66446008)(7696005)(64756008)(9686003)(66556008)(52536014)(6506007)(55016002)(66476007)(71200400001)(4326008)(76116006)(316002)(33656002)(2906002)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: EfZ8f+ECSmNpcS95WpY2t2hlTqQEnWOJyDq6mvgF3RHj5Rc+TXhLyfZdvUXBvxRG3gRkY8fheL7wZZIjeiB9bEVt4pIHuxjzsvg+Fyyc6PMl54CxGLXRP9N8fb20uCOzKk3nvnSqlYgnA81rknIbd+Q9iDtvZ9lZGU3o0aJ3JtNWgr+hJmaz/N03fZOTkqDpdw2A9d6wJ9SOftTTvSJteprwEdmENiAoAyq7B24m/BOjMMDghgjemb+SNtS8vz+33AUy9KDer11oDlzd49KcgNEbm7elMzBu7Q9u4kQlff3Bi0l6hShWwyZ1z7M5tmHvhcI47i2rjmIZmi7O5VXr3qv1jMzXSGbfBgR10l3hgokj5atr+NWXcfGhzocWVMfk11+wemQX6Eko+srhllexqcK2Ju34s584gQAzKzC+l+JSvnCJNs5InCg96oLpsFOpDyU/WcYjhHlLQK0gqj2QEDvzVFlFCXrSlg5kheq+ny1EecztGU+hNacZRJFFTAmTFtXzWGAxU6gC4m6/23PGThmAmCiP3NnClaYtrLCiWshudQS9L28KgCj+O3ol+jF9ZIew2ai5c8AiN4PNLC68wtXv6OMRDP2NYTtaHMQ8zHbbzEwZu5iLikw/OLPIV7Fp82DFNBMi99h1GWLbrdj82g== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2296.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be9d88a2-93ad-4015-0b1f-08d83a1f0366 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2020 15:40:14.7351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O58hhcVd0LV2yEgXbfD6+An/jZrNJfc+bKMr4p1QLu/Y6Pcj/9eU+ydyPfzmnnR/hf2vh87zCCrwV4i2e4hDYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1463 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eventdev: fix return value of null not checked X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: wangyunjian > Sent: Monday, July 27, 2020 7:33 PM > To: dev@dpdk.org; Rao, Nikhil > Cc: jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] eventdev: fix return value of null not checke= d >=20 > From: Yunjian Wang >=20 > The function rte_zmalloc() could return NULL, the return value need to be > checked. >=20 > Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c > b/lib/librte_eventdev/rte_event_eth_tx_adapter.c > index bb21dc407..86287b4e6 100644 > --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c > @@ -734,6 +734,8 @@ txa_service_queue_add(uint8_t id, >=20 > qdone =3D rte_zmalloc(txa->mem_name, > nb_queues * sizeof(*qdone), 0); > + if (qdone =3D=3D NULL) > + return -ENOMEM; Reviewed-by: Nikhil Rao > j =3D 0; > for (i =3D 0; i < nb_queues; i++) { > if (txa_service_is_queue_added(txa, eth_dev, i)) > -- > 2.23.0 >=20