From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D8CAA0550 for ; Wed, 10 Feb 2021 01:28:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 148501606BA; Wed, 10 Feb 2021 01:28:43 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id B184140147; Wed, 10 Feb 2021 01:28:40 +0100 (CET) IronPort-SDR: dcDLGVtC8TRT7eqvKJqTu5tvDTXAZC46UtamH3hMOO4DEDtnagAlHyBPFNNnIrlwVzc0OArTmI k4pSjG4L4Y4Q== X-IronPort-AV: E=McAfee;i="6000,8403,9890"; a="179429229" X-IronPort-AV: E=Sophos;i="5.81,166,1610438400"; d="scan'208";a="179429229" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 16:28:39 -0800 IronPort-SDR: tdIzfjHDkz/3Laec0mqIviUEAwl0OKNzcNtspgVnHMxwSjDP+MzVylMhaW2FZiAO5qt+t00ClF Py6cqMVWiZ1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,166,1610438400"; d="scan'208";a="586953398" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 09 Feb 2021 16:28:39 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 9 Feb 2021 16:28:39 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 9 Feb 2021 16:28:38 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 9 Feb 2021 16:28:38 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 9 Feb 2021 16:28:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HyteXWy/ggi5VGbCQCo+2DtRYQpHBvt0orVbhnhXzkJHUSd0ytPcyxa9K8ahmKUKkOiNuQZz+9BKqnqLRzziyUiQCQZEtOESrQi2ACUEQA6Dv707jxxQHCVpIRiYu2WxhGdbnzXx37nI1j+QWixU8jCNFHXRpInJ9TTXBoyriVYSpFrIVWtkhVAnZGQ5k4G0iMGaQei0RndoOvVzzwhdB73Ohkvy6AaopSdpAanV6i3vMUp7aaiQFXnMljN/XRRI+G3FH0f1hJzYTqw28TWGzLt9II0qgPT8ok4Mmq/jTbiDIR3OWZWsbDQhBhbTQeZ2bUp+i/pM0gD9LRcfmVI+qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XHzSG9XZgxvumprMexPsbA+1Ht56tXQhabIB78SPUDQ=; b=Id9HjQxLhYvs4GAI0kmLQaA5K7ujc8D85tHWsBhQ9gjheat2jz+i1wVMiVWcOrwtbqzWCDXvp+6qJCeEQS2KFggmd8g9hB9pqJzSvB6x6Ly6RtvsXsRZe/lsmE/6H5JKI0d1RYrsJCIj7ow3A3MP/zYBjFnX9UM/C+wqcYuM16xhtKKJyoOASoJ4J+VoTlxc+S14Zxvrye6OcrvHS10B3t/PD6w1e2bYuLmBosW2bcJRbNadm+2+kO58FHGeXMpDfjFCB6AZez/89gBwXL7GzVQT6TR7ENC9wySntjlT/qXC1vfvWKCdna55AOHee0HvQ0OFeyLMO+8bwwS2W717BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XHzSG9XZgxvumprMexPsbA+1Ht56tXQhabIB78SPUDQ=; b=QeVBZKnLhQooSyOytdcAzAEd1JzUOWHxTbfxk3Tp4gFjhq+BQoVyBrKeLafkMXe7MO9YiPB4mL02LM+6saxGbhepQ/LsBpLdVnmr14C6giejk7DihWFix2+XFnz+PNIS6mEmjJ/uZo9VErBFRDoTeYV+a66O9clWt7b+CkyMEUU= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR1101MB2357.namprd11.prod.outlook.com (2603:10b6:903:bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Wed, 10 Feb 2021 00:28:33 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae%12]) with mapi id 15.20.3825.031; Wed, 10 Feb 2021 00:28:33 +0000 From: "Li, Xiaoyun" To: "Yigit, Ferruh" , "Singh, Jasvinder" , "Wu, Jingjing" , "Adrien Mazarguil" , "Dumitrescu, Cristian" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] app/testpmd: fix meter commands help strings Thread-Index: AQHW/u4F6mMNyFMp/kqRpWTHN9tIeKpQiUpA Date: Wed, 10 Feb 2021 00:28:33 +0000 Message-ID: References: <20210205133926.779938-1-ferruh.yigit@intel.com> <20210209141506.1506473-1-ferruh.yigit@intel.com> In-Reply-To: <20210209141506.1506473-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee79d60e-95cd-42e9-5039-08d8cd5acc8b x-ms-traffictypediagnostic: CY4PR1101MB2357: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0eMWDy+2yi/XqDn8nc7PaE5DgBKCPwCyq9DKqtOPNgdF+FBTmEuL3oIjOeZX46MeO2hrTWRaCSA5CfLK2SoyleKtY8IX4H0gsqB89j6RO8fLpY6yoBLU5uA4jf3+/zLmJVXO56uFegCM3avxhm9P+WCAwJtK9eN7+DeNbdyUo33T9F2IbZGzsqaiiCFLqHtXtY0a7aQ75eM26GQTIlhmZ44neGoWvVpxyVRCbdcKOvzmtYVzBDfOgVpa+tY0xU+5oOKh9sQnZ7ISq4JYBLksmKuGNSxqkJ/ZQAk3j3NAb5x+bMm+CXyaOMX1EsGEhyBAjjmTBd7JK9850ud8Cme6bBe2V0P+OBAnfiKmVlqVxcadCB4lu5XqS8dUu08rLM//2sjpTlO3vDyQacxS5tL42WFrahY4T1AkuXMQVWmeVJ4Lg8d8dohM3Rx+Qv8S2nF3x6ROs4BMCxkxZx0zk8+oJwn3gBaWq3QMz6JhT6qZXRZf0lVM9bh7R/uZL5xAsK5lPXAfOqQ1+8qHkJ1jeilJJQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(366004)(39860400002)(376002)(346002)(396003)(66446008)(66946007)(76116006)(64756008)(55016002)(66476007)(66556008)(8936002)(9686003)(54906003)(316002)(110136005)(33656002)(6636002)(4326008)(186003)(53546011)(52536014)(86362001)(6506007)(83380400001)(5660300002)(2906002)(478600001)(8676002)(7696005)(71200400001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?JD/GsJVE+sovk74Q6JLCeTHVxN5jOWZ3khFrRJ8POCTpPshkgQkyXSd/Xp9w?= =?us-ascii?Q?TwNm4iQl2sMGjyPYEwgzlZdy+npsjLKUispMPU2wMN616cJiZigppguqX4uj?= =?us-ascii?Q?2dGgMI+T4kGk4/fdKgxxZqrFL92DrLDggk4dacHRU3uQGiYA7XRHPgZHcn53?= =?us-ascii?Q?NDGW0gQ7wTSjnbL2ohOsqVO0KHWvDcqeBlkFreQrR1OA0tTpyKFPLunnY2Ui?= =?us-ascii?Q?w859DBKizNCNg9X7P2BVdxRfagv1byyYnq+H/G7XDRfF/n2EcdZdjyDeOwsm?= =?us-ascii?Q?ZooQH8POphtwDJNclFPEtFUkQHLK/8QBTXdbTiSkRWH9YYBluePD+wJ15L9B?= =?us-ascii?Q?l6t1LqxtJqG2HgWbGZ+yTmlgZewsL3fSBgjTefN3llVlhVqBC7mF9bt+NJAm?= =?us-ascii?Q?qVnkUVbz0Bwvy+UTIam50vDGYIyNYRyKhpqy0MlZkFX6yu7seRvNA+bj7Hhy?= =?us-ascii?Q?QxTwk0EWL7TgmGudFNujwi0UnpODHCGctOoIFgkZXQyE1iDT0etP3biyc7Wn?= =?us-ascii?Q?8iX26qckwN7k5YsLKfu/zCIwJyHFztHx23bs+VGkw1nuNi4Rb+ISVKxYx1vL?= =?us-ascii?Q?uqAbYmlydyse0OGUSI1oC41cdCbX/wJEuFWbl8YOc8pmNNoAkPsNqwjqUmw6?= =?us-ascii?Q?uMVnS/olXSpdfTfv5RC/N+QnYycwXAVYEPuVKqfCPkHGyr9u15wDlLYV3I1o?= =?us-ascii?Q?ETexaLyyTMpSbwQpXKEjYrLOgGfe0xS9PHgtL/b91I41Vd+HBHq2cyYC31ie?= =?us-ascii?Q?dpqe2KzhjgrThndHrg+Aeo0WLsr7HuSw2F5tWKhzHgXtHXCl06B3DbxcxB73?= =?us-ascii?Q?QhyJC87raKKJ2uIeK7yNtS+4mrGIeoxTNjOu44UQOpfKnDIfgUpG5mnH8giX?= =?us-ascii?Q?ZmuQhjKdQ/DCFQRrfKYEF7mAu4tsacyEoA6osK+fgULqP8uwlI7c29Kf2+eh?= =?us-ascii?Q?EaeuRRnrweT6DmougKU0uIMguzm2rOXWm1S/vR7WcS2PdPniCERgdJpfFLLN?= =?us-ascii?Q?wqi5y1RyXVS6SDmbdZ16KzgjI9VKr0b+unnlusw19S9TU8HujwVE2MRCN4Rf?= =?us-ascii?Q?mhECQgT3dFgHFNMy4viWFykohWl3pifhTaQrfSqP1q1J10wvdkbHRD+e/K3n?= =?us-ascii?Q?apwgSIBUDG1sXPf25644f4y7wjFD3W8OYLeunBqly0l9iwht/tz+nYW7/eNU?= =?us-ascii?Q?hvdAsk/lVP+i+flSkC3dgM+tPeIT1iJHGUW2wSfM+hzVrNm3vk2xb99hbX+B?= =?us-ascii?Q?p29XMjooo4tlybn6AiKt0zURuEPp5CvdzFPLv7TacC/TXtQ+1QXnmcjMWNTM?= =?us-ascii?Q?Gjg3f7cscMEv72wOKF3qC4CM?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee79d60e-95cd-42e9-5039-08d8cd5acc8b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2021 00:28:33.4108 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HhetUXvSkk+aszojJp7B1OBZ510bDP19m7NNzOPpkgKKt+fM5bsjjdI2MWDyta91kmsl94pV5T9aaF1sCQeHBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2357 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v3] app/testpmd: fix meter commands help strings X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Acked-by: Xiaoyun Li -----Original Message----- From: Yigit, Ferruh =20 Sent: Tuesday, February 9, 2021 22:15 To: Li, Xiaoyun ; Singh, Jasvinder ; Wu, Jingjing ; Adrien Mazarguil ; Dumitrescu, Cristian Cc: Yigit, Ferruh ; dev@dpdk.org; stable@dpdk.org Subject: [PATCH v3] app/testpmd: fix meter commands help strings Helps strings syntax is "command : description", the 'command' part was mis= sing, updated command help strings. Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and polici= ng") Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Cc: jasvinder.singh@intel.com Cc: cristian.dumitrescu@intel.com - "set port meter dscp table" documented with 'port_id' & 'mtr_id', but command itself is not requiring it, can be better to double check the intention in the command. - In command "show port meter stats yes|no", it is not clear what 'yes|no' is, can be better to have a 'clear' keyword there: "show port meter stats clear yes|no" - 'meter' commands seems using many high level commands, that is harder to remember when you take all commands into account: "show port meter ..." "add port meter ..." "del port meter ..." "create port meter ..." "enable port meter ..." "disable port meter ..." "set port meter ..." And some high level commands created just for 'meter'. Instead I think it is better to group the commands, like: "port meter [add,del,create,enable,disable] ..." "show port meter ..." It is already too late but it worth to keep in mind for the possible future update. v2: * Fixed typo, actiono -> action0 * Added more info to help string, like "(possible values)" v3: * Fix the "set port meter dscp table" command according the original intention --- app/test-pmd/cmdline_mtr.c | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-)