From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B3EDA0575 for ; Thu, 11 Mar 2021 10:28:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 220B622A26E; Thu, 11 Mar 2021 10:28:58 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9B1D94003D; Thu, 11 Mar 2021 10:28:55 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12B9Q6hN021173; Thu, 11 Mar 2021 01:28:54 -0800 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by mx0b-0016f401.pphosted.com with ESMTP id 374drr6rc1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Mar 2021 01:28:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FPayQAjY9rjsPPAEgNamvj48T9L6/cDn9BBAypJ6B8gc2DXng98lFfuKk6uTnHKjQysK4UUz7w7KkmSRkUt1W99g+b582u9+G7pfrcqY/Wp/edKI83+06Hu0iQ5yZnr7+kRy8i8rMmFoQ3qaAmzVNv9oFJC4IX+Z4hoGHFBvxFWsct5a2yOfy+I9gOQGLUEWKnlGeby0FCwup0W8m4SsHuQJxzxgBzDEUO7edTvlyHJWTfIuy9g8+Ild8YuirLa0v4alsHRtPxxSsjsqtJKHEmpUlCx4q8aKorXCDP7Wb62lQ+Su7LarNerWq8yn0dWW3qQNNpXbn4t8g3UOx4/xgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fZH2MUdGRueM9nYgXTyrZ34Aob2WjH07/YZqn9Uj/Z8=; b=FfDkqLIXy4qJtk+3kpDsD9gg5EdcoHcwqMVNHuJDcRO5rMZUy99Yv92Fe2ueewgnEODRcbmNldowjbTzJt04wNYcYHVqot+h+WH1h/BHlmDqihetUhcm+9+XlCAmGQVXv3v/I/vNOK0bMoNU6Dg7FOhDcaTe8KHXGes0QBXzkMoUWgP8gKy9jK9CiSr0vi4QvDGwnjrBOTU1f8/f3UVAKmwm7zE05ucszMf865Ok8D1zqtBXBwtc6ULpdXDT4HBvesmZ6A84GmkXGst/+2GsaFlnCsP2ZMEAHRIXMx1rmcHaxy0HdJa2L9IMJBBri13Itx3RjWzuJrUU3GoaQOd30g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fZH2MUdGRueM9nYgXTyrZ34Aob2WjH07/YZqn9Uj/Z8=; b=rEOPiB9A4eoNlWNmbuDvuoGVjFgpUmD0Vfm7qgRI/2SPACrwgihLlDTC96YSmZHfSRHN2TcVE7x4rEURyRqB2aJyXRVCFcmEYmYwBBHu0Sd2wxK1QFMasC6tGKVTCjsok8c4lpbivHl3E2UB2g6n9+m58OfCC5JVz/JSSeU05IQ= Received: from CY4PR18MB1496.namprd18.prod.outlook.com (2603:10b6:903:149::8) by CY4PR18MB1656.namprd18.prod.outlook.com (2603:10b6:903:14d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Thu, 11 Mar 2021 09:28:52 +0000 Received: from CY4PR18MB1496.namprd18.prod.outlook.com ([fe80::202b:c505:9b86:b894]) by CY4PR18MB1496.namprd18.prod.outlook.com ([fe80::202b:c505:9b86:b894%12]) with mapi id 15.20.3912.030; Thu, 11 Mar 2021 09:28:52 +0000 From: Devendra Singh Rawat To: Igor Russkikh , "dev@dpdk.org" CC: Rasesh Mody , Igor Russkikh , "stable@dpdk.org" Thread-Topic: [PATCH 2/2] qede: make driver accept bigger rss tables Thread-Index: AQHXCEMLEsbOBDspT02hIZmJaqEYE6p+n2hg Date: Thu, 11 Mar 2021 09:28:52 +0000 Message-ID: References: <20210221111637.31193-1-irusskikh@marvell.com> <20210221111637.31193-3-irusskikh@marvell.com> In-Reply-To: <20210221111637.31193-3-irusskikh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.76.113.230] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94408250-c1bc-45f0-de0a-08d8e47015bc x-ms-traffictypediagnostic: CY4PR18MB1656: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ClZ7f+pvbEy34Pd6KlT7DsDhvU1lI8b38Gv/jfAogifjfkZe0Tu0xhGJRK89C+UNV8BXleKafDW3OKoKm/UuiqAFaVR51n2jdEvd4TI+YasIUNzHEdQm4vOB4Ap/NjltEsvVEIGrs0tMlZ3/4kuMC8vM3OEIr9F6kI25e2lawE5Bv1o+6oHO2tuXdjbd4IB5rqJ65gffPHbxOreG77ANPXqB8mdM5qNyAO0mkln71cKNFc6QqPkBXR3wZZVpRugN+wmp37Fzv5QLA/du63xl7vXS5A1ugW9/lnxe5MF2soxk0UDWPgM5/G7A786an75VOvUojLGyjdIoyAfJBUxpy+uKLLMjYsg8dSVvXNV19XwvU4bZJW6IgY1/7cQlzAJXi0x+msLVM6UcnUsNVbSRDZxV75vI+rZfG4z2I6nNaJBTXqkZlMoWZDIqq0jN1idgFPvIm4Tjc9dcbiZRTeWhYsR3y5Dt6jMQt/FMtyDcgqriQ9novfGqj2Ol4f8VLC9XJHLCSilsjev3y+IUmb6wvkIK0lYroouhcGzfu/Ep9gdLGUz118MJP6fRxOwwokrg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR18MB1496.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(366004)(39860400002)(136003)(54906003)(4326008)(26005)(316002)(110136005)(186003)(7696005)(52536014)(8936002)(478600001)(2906002)(450100002)(66446008)(71200400001)(83380400001)(8676002)(33656002)(66476007)(64756008)(5660300002)(66946007)(55016002)(53546011)(6506007)(9686003)(66556008)(76116006)(86362001)(135533001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?4e2oQetEjJ5WUCSEutGVxF+798uvJMfjVb/bHwyQK5himziXxF+h24RdDUBF?= =?us-ascii?Q?GXte/VlqNXHTVS9Fp6Azn3d4W+KkGMZ34PUNIC1zbRG38cVLpVn0DKzFwOst?= =?us-ascii?Q?jxtwN6YlMKuMfAS8VYaid15514pzM9OVqR+HBbwO11+Yo/qC/9XZO5DEvX/2?= =?us-ascii?Q?59a0wPmNrpun4VSerulBMcwnqmnqPzsDfOdsTKlGKbJ7ywajK7aX1xS/CnTm?= =?us-ascii?Q?FoaCL7OhnIm3zU339XBVkbktmJhcQoBbk/s7M6g2T+XtaCyHZ6Bq/dOpkwnp?= =?us-ascii?Q?Zf36a5ZrzZm9Kv1GrEUBsmAH4HI1j79N6QGK/3jb7P2K8H5FmrCgfflSfkKk?= =?us-ascii?Q?IF0cvrNH0it+RMWZu83/CtGNRdC6IK8HGlKIJsOMrHQCvJzgEx7m35azflwn?= =?us-ascii?Q?vQCFq2AmnIv8tgxzHcGbNwt/WncWiaSPYa6hGvnq9i0J5VPRf5wuoep/Ar/V?= =?us-ascii?Q?JOgXIRdA8b4TbkyQpzCYDbhkd1rFdbRFKiIZiJxVC/MNXeZ/iDMOGJoZ7w5o?= =?us-ascii?Q?iBo2hMOeHw6R4xJGguAq9KvzFcx8CzJ2Qww2/vDmiQQig7BlVtVj2T3gjHIr?= =?us-ascii?Q?+0gVnpXpyPo05rVI++yZ240GqSXBRew07hie4DMNSFwd9BoGdon4PpNkyMGD?= =?us-ascii?Q?p8WRtXfXgHTzYAKpasQD+zeXaIMCpFY9JHvBT+5O7zLCY23Mvx1CfZYKa1Ro?= =?us-ascii?Q?ELMcBjIUqmYaGQQQ4BhHqYFoP7BZmqVI9X0gWMJ0P7Imn/UH1zfgQV44gUgY?= =?us-ascii?Q?ScJ9mS6FkD7fqxxkEUjOlhfZu53W7R3p0KaHuOXXIR15uOAOdQRNpuL0FjE7?= =?us-ascii?Q?k1+R9VzpZvDnBkzcfvJmeW57SSrxvANe3xMahRuE5e5dk9gbGguGlSafL9e5?= =?us-ascii?Q?9cE+M/RaPG2KXBnQ3Vgq2bTUPA+O9777Cm7YAoMOMOPi1el9XsTzX0NtBY+E?= =?us-ascii?Q?7FmTjgN3djTvuOMbOOVpMPRbSeVOxU4zxVRtRdZrVHmexTxS2zVQgGArTQZC?= =?us-ascii?Q?ZwXMlywNtlC8whUBJXk+JgypZpLrbfrGpc0XbGU97U/H7fan2iiigMuXorZt?= =?us-ascii?Q?FOsHWI2LWFstvhG8pq9eecf/LsUQuAkB6m9dnULlOOeSufExtce9gEgg6Ele?= =?us-ascii?Q?T8777vtn3zwpgihzQ5GowgLsqzWExPNdpCAOh9NToOiaaG2/jpQTqLpzNt5K?= =?us-ascii?Q?SrTu4RFCCiOYao96G6ca8sSXx9cPeyMxLMclvStgp+Py7oVdqltnSy9SD/Yu?= =?us-ascii?Q?EX6PerlE9ktD02uksZRiuPohjWEGl39aG1EYX/noPKwJSTd/nZuOH3+UPNgH?= =?us-ascii?Q?h6etLxhImpL5Woz7QF/H6cWw?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR18MB1496.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94408250-c1bc-45f0-de0a-08d8e47015bc X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2021 09:28:52.4164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qbnpdhl/z3+8cXMP8XpAFgbVom1mp+9zyzMJobi9/AqPC/WD8O1iEkUPHeYa+hOVOHGLXzTw9z5B0cZZX5mgUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1656 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-11_04:2021-03-10, 2021-03-11 signatures=0 Subject: Re: [dpdk-stable] [PATCH 2/2] qede: make driver accept bigger rss tables X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Igor Russkikh > Sent: Sunday, February 21, 2021 4:47 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; Devendra Singh Rawat > ; Igor Russkikh ; > stable@dpdk.org > Subject: [PATCH 2/2] qede: make driver accept bigger rss tables >=20 > We found some dpdk applications blindly pass fixed side rss hash tables, = and > do not check driver/device capabilities. >=20 > Moreover, many other drivers do not do such a strong check as well. >=20 > So here we fix it, making qede accept any size rss_key. For larger key ta= bles we > just crop it with notice trace message. >=20 > CC: stable@dpdk.org > Signed-off-by: Igor Russkikh > --- > drivers/net/qede/qede_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethde= v.c > index ab5f5b106..7363d98f2 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -2139,8 +2139,8 @@ int qede_rss_hash_update(struct rte_eth_dev > *eth_dev, > /* RSS hash key */ > if (key) { > if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) { > - DP_ERR(edev, "RSS key length exceeds > limit\n"); > - return -EINVAL; > + len =3D ECORE_RSS_KEY_SIZE * sizeof(uint32_t); > + DP_NOTICE(edev, false, "RSS key length > exceeds limit\n"); IMO, it will be better if the log message also states that RSS key is trimm= ed to 'len' size. Thanks, Devendra