Hi Bruce,
I can work to get my backported version out to the community and upstreamed.
Thanks,
-Chrisb
From:
Richardson, Bruce <bruce.richardson@intel.com>
Date: Tuesday, March 26, 2024 at 11:10 AM
To: Luca Boccassi <luca.boccassi@gmail.com>
Cc: Chris Brezovec (cbrezove) <cbrezove@cisco.com>, dpdk stable <stable@dpdk.org>
Subject: RE: please help backporting some patches to stable release 20.11.10
Hi Chris,
You say in your original mail that you have already got backported versions of the patch in question. Would you be in a position to upstream those backports to the DPDK community, by emailing them to DPDK stable?
Thanks,
/Bruce
> -----Original Message-----
> From: Luca Boccassi <luca.boccassi@gmail.com>
> Sent: Monday, March 25, 2024 2:28 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: Chris Brezovec (cbrezove) <cbrezove@cisco.com>; dpdk stable
> <stable@dpdk.org>
> Subject: Re: please help backporting some patches to stable release 20.11.10
>
> At least for 22.11 it doesn't apply cleanly, context has changed quite
> a bit, so it would need to be backported by a pmd maintainer/developer
>
> On Mon, 25 Mar 2024 at 14:06, Richardson, Bruce
> <bruce.richardson@intel.com> wrote:
> >
> > Trying to remember now, but I believe I originally encountered the issue fixed
> by 12016895fc in the context of setting up runtime queue reconfiguration
> from commit [1]. In the absence of that new feature being backported, I
> assumed there was no need to backport the fix, since others had not
> previously reported it. Since it seems that was a mistake, we should indeed
> look to backport the patch in question.
> >
> >
> >
> > Stable-tree maintainers, can we re-add 12016895fc to the list of backports
> for next point releases?
> >
> >
> >
> > Regards,
> >
> > /Bruce
> >
> >
> >
> > [1]
> http://git.dpdk.org/dpdk/commit/?id=d492ea071056a8a0de2991c42daee9
> d9acca8e35
> >
> >
> >
> > PS: Link in your email is inaccessible to me, it’s perhaps a cisco-internal-only
> reference.
> >
> >
> >
> > From: Chris Brezovec (cbrezove) <cbrezove@cisco.com>
> > Sent: Monday, March 25, 2024 1:34 PM
> > To: Richardson, Bruce <bruce.richardson@intel.com>; dpdk stable
> <stable@dpdk.org>
> > Subject: Re: please help backporting some patches to stable release
> 20.11.10
> >
> >
> >
> > Hey Bruce,
> >
> >
> >
> > I was wondering why you thought it was ok to skip backporting 12016895fc
> to earlier releases?
> >
> >
> >
> > It looks like I ran into this issue on v21.11and v22.11. I patched this back
> locally and saw that we no longer were leaking mbufs in TX queue stop with
> IAVF. It did not patch cleanly because
https://polaris-git.cisco.com/iosxe-
> dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201
> was not backported either.
> >
> >
> >
> > It does seems like this issue exists in earlier releases though, so wondering
> the reasoning for not backporting.
> >
> >
> >
> > Thanks!
> >
> > -Chrisb
> >
> >
> >
> >
> >
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> > Date: Monday, October 23, 2023 at 5:39 AM
> > To: dpdk stable <stable@dpdk.org>
> > Subject: RE: please help backporting some patches to stable release
> 20.11.10
> >
> > Ok to skip 12016895fc, it should not be necessary for backport.
> >
> > > -----Original Message-----
> > > From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> > > Sent: Thursday, October 19, 2023 1:03 AM
> > > To: dpdk stable <stable@dpdk.org>
> > > Cc: Sinha, Abhijit <abhijit.sinha@intel.com>; Burakov, Anatoly
> > > <anatoly.burakov@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Bernard
> > > Iremonger <bernard.iremonger@intel.com>; Richardson, Bruce
> > > <bruce.richardson@intel.com>; Chandubabu Namburu
> <chandu@amd.com>; Power,
> > > Ciara <ciara.power@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>;
> > > Deepak Kumar Jain <deepak.k.jain@intel.com>; Dmitry Kozlyuk
> > > <dkozlyuk@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Ferruh Yigit
> > > <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Vargas,
> > > Hernan <hernan.vargas@intel.com>; Jie Hai <haijie1@huawei.com>; Wu,
> > > Jingjing <jingjing.wu@intel.com>; Griffin, John <john.griffin@intel.com>;
> > > Konstantin Ananyev <konstantin.ananyev@intel.com>; Leyi Rong
> > > <leyi.rong@intel.com>; Long Li <longli@microsoft.com>; Matan Azrad
> > > <matan@nvidia.com>; Maxime Coquelin <maxime.coquelin@redhat.com>;
> Chautru,
> > > Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > > Nicolau, Radu <radu.nicolau@intel.com>; Singhal, Saurabh
> > > <saurabhs@arista.com>; Selwin Sebastian <selwin.sebastian@amd.com>;
> > > Somalapuram Amaranath <asomalap@amd.com>; Thomas Monjalon
> > > <thomas@monjalon.net>; Wei Hu <weh@microsoft.com>; Lu, Wenzhuo
> > > <wenzhuo.lu@intel.com>
> > > Subject: please help backporting some patches to stable release 20.11.10
> > >
> > > Hi commit authors (and maintainers),
> > >
> > > Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> > > fixes.sh
> > > I didn't apply following commits from DPDK main to 20.11
> > > stable branch, as conflicts or build errors occur.
> > >
> > > Can authors check your patches in the following list and either:
> > > - Backport your patches to the 20.11 branch, or
> > > - Indicate that the patch should not be backported
> > >
> > > Please do either of the above by 2023/10/26.
> > >
> > > You can find the a temporary work-in-progress branch of the coming
> > > 20.11.10
> > > release at:
> > > https://github.com/bluca/dpdk-stable
> > > It is recommended to backport on top of that to minimize further conflicts
> > > or
> > > misunderstandings.
> > >
> > > Some notes on stable backports:
> > >
> > > A backport should contain a reference to the DPDK main branch commit
> > > in it's commit message in the following fashion:
> > > [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> > >
> > > For example:
> > > https://git.dpdk.org/dpdk-
> > >
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> > >
> > > When sending the backported patch, please indicate the target branch in
> > > the
> > > subject line, as we have multiple branches, for example:
> > > [PATCH 20.11] foo/bar: fix baz
> > >
> > > With git format-patch, this can be achieved by appending the parameter:
> > > --subject-prefix='PATCH 20.11'
> > >
> > > Send the backported patch to "stable@dpdk.org" but not
> "dev@dpdk.org".
> > >
> > > FYI, branch 20.11 is located at tree:
> > > https://git.dpdk.org/dpdk-stable
> > >
> > > Thanks.
> > >
> > > Luca Boccassi
> > >
> > > ---
> > > 12016895fc Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
> > > d7d52b37e8 Ciara Power crypto/qat: fix raw API null algorithm digest
> > > 7d04891664 Hernan Vargas baseband/acc: fix ACC100 HARQ input
> alignment
> > > 37b68fa144 Jie Hai app/testpmd: fix primary process not polling
> > > all queues
> > > e35a5737a7 Saurabh Singhal net/iavf: unregister interrupt handler before
> > > FD close
> > > a27ff9cac1 Selwin Sebastian net/axgbe: identify CPU with cpuid
> > > 26c6bdf3d1 Wei Hu net/mana: add 32-bit short doorbell
> > > 74decf3bf0 Wei Hu net/mana: enable 32-bit build