Hey Bruce, I was wondering why you thought it was ok to skip backporting 12016895fc to earlier releases? It looks like I ran into this issue on v21.11and v22.11. I patched this back locally and saw that we no longer were leaking mbufs in TX queue stop with IAVF. It did not patch cleanly because https://polaris-git.cisco.com/iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201 was not backported either. It does seems like this issue exists in earlier releases though, so wondering the reasoning for not backporting. Thanks! -Chrisb From: Richardson, Bruce Date: Monday, October 23, 2023 at 5:39 AM To: dpdk stable Subject: RE: please help backporting some patches to stable release 20.11.10 Ok to skip 12016895fc, it should not be necessary for backport. > -----Original Message----- > From: luca.boccassi@gmail.com > Sent: Thursday, October 19, 2023 1:03 AM > To: dpdk stable > Cc: Sinha, Abhijit ; Burakov, Anatoly > ; Xing, Beilei ; Bernard > Iremonger ; Richardson, Bruce > ; Chandubabu Namburu ; Power, > Ciara ; Doherty, Declan ; > Deepak Kumar Jain ; Dmitry Kozlyuk > ; Ferruh Yigit ; Ferruh Yigit > ; Trahe, Fiona ; Vargas, > Hernan ; Jie Hai ; Wu, > Jingjing ; Griffin, John ; > Konstantin Ananyev ; Leyi Rong > ; Long Li ; Matan Azrad > ; Maxime Coquelin ; Chautru, > Nicolas ; Zhang, Qi Z ; > Nicolau, Radu ; Singhal, Saurabh > ; Selwin Sebastian ; > Somalapuram Amaranath ; Thomas Monjalon > ; Wei Hu ; Lu, Wenzhuo > > Subject: please help backporting some patches to stable release 20.11.10 > > Hi commit authors (and maintainers), > > Despite being selected by the DPDK maintenance tool ./devtools/git-log- > fixes.sh > I didn't apply following commits from DPDK main to 20.11 > stable branch, as conflicts or build errors occur. > > Can authors check your patches in the following list and either: > - Backport your patches to the 20.11 branch, or > - Indicate that the patch should not be backported > > Please do either of the above by 2023/10/26. > > You can find the a temporary work-in-progress branch of the coming > 20.11.10 > release at: > https://github.com/bluca/dpdk-stable > It is recommended to backport on top of that to minimize further conflicts > or > misunderstandings. > > Some notes on stable backports: > > A backport should contain a reference to the DPDK main branch commit > in it's commit message in the following fashion: > [ upstream commit ] > > For example: > https://git.dpdk.org/dpdk- > stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > > When sending the backported patch, please indicate the target branch in > the > subject line, as we have multiple branches, for example: > [PATCH 20.11] foo/bar: fix baz > > With git format-patch, this can be achieved by appending the parameter: > --subject-prefix='PATCH 20.11' > > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org". > > FYI, branch 20.11 is located at tree: > https://git.dpdk.org/dpdk-stable > > Thanks. > > Luca Boccassi > > --- > 12016895fc Bruce Richardson net/iavf: fix buffer leak on Tx queue stop > d7d52b37e8 Ciara Power crypto/qat: fix raw API null algorithm digest > 7d04891664 Hernan Vargas baseband/acc: fix ACC100 HARQ input alignment > 37b68fa144 Jie Hai app/testpmd: fix primary process not polling > all queues > e35a5737a7 Saurabh Singhal net/iavf: unregister interrupt handler before > FD close > a27ff9cac1 Selwin Sebastian net/axgbe: identify CPU with cpuid > 26c6bdf3d1 Wei Hu net/mana: add 32-bit short doorbell > 74decf3bf0 Wei Hu net/mana: enable 32-bit build