From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F21EBA05D3 for ; Mon, 25 Mar 2019 19:05:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9919F10A3; Mon, 25 Mar 2019 19:05:37 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 31DD710A3; Mon, 25 Mar 2019 19:05:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2019 11:05:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,269,1549958400"; d="scan'208";a="137158604" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga003.jf.intel.com with ESMTP; 25 Mar 2019 11:05:33 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 25 Mar 2019 11:05:32 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.204]) by ORSMSX163.amr.corp.intel.com ([169.254.9.144]) with mapi id 14.03.0415.000; Mon, 25 Mar 2019 11:05:32 -0700 From: "Wang, Yipeng1" To: "Poornima, PallantlaX" , "dev@dpdk.org" , Thomas Monjalon CC: "Pattan, Reshma" , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "stephen@networkplumber.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] hash: fix sprintf with snprintf Thread-Index: AQHUxGUPuMrlep0Xn06OUa81VeEp8qYdHo6A///AwdA= Date: Mon, 25 Mar 2019 18:05:32 +0000 Message-ID: References: <1550149062-14300-1-git-send-email-pallantlax.poornima@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTNiY2E1MDUtMWJkOS00NzY1LThkNTgtOGFlNTVmZGIxMWRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiODhSMHRPS1didkpjU1wvQVhxSU1mM3JlUUpxUHdhNENSMHZGQVU5R0JaRGEzMDY2aENacGNqbTR0UGo3WHF3c3kifQ== x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v2] hash: fix sprintf with snprintf X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Sorry for the late reply, but I noticed the test folder is recently moved u= nder app so you may need a rebase. Please keep my ack after rebase: Acked-by: Yipeng Wang >-----Original Message----- >From: Poornima, PallantlaX >Sent: Monday, March 25, 2019 7:43 AM >To: dev@dpdk.org >Cc: Pattan, Reshma ; Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce ;= De Lara Guarch, Pablo >; stephen@networkplumber.org; stable@dpdk.= org >Subject: RE: [PATCH v2] hash: fix sprintf with snprintf > >Hi, > >>-----Original Message----- >>From: Poornima, PallantlaX >>Sent: Thursday, February 14, 2019 6:28 PM >>To: dev@dpdk.org >>Cc: Pattan, Reshma ; Wang, Yipeng1 >>; Gobriel, Sameh ; >>Richardson, Bruce ; De Lara Guarch, Pablo >>; stephen@networkplumber.org; >>Poornima, PallantlaX ; stable@dpdk.org >>Subject: [PATCH v2] hash: fix sprintf with snprintf >> >>sprintf function is not secure as it doesn't check the length of string. >>More secure function snprintf is used. >> >>Fixes: 473d1bebce ("hash: allow to store data in hash table") >>Cc: stable@dpdk.org >> >>Signed-off-by: Pallantla Poornima >>--- >>v2: Addressed review comment to correct the format specifier of >>hastest_key_lens. >>--- > > >Request for ACK please if there are no comments > >Regards, >Poornima