From: "Robin Jarry" <rjarry@redhat.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: <mb@smartsharesystems.com>, <thomas@monjalon.net>,
<david.marchand@redhat.com>, <stable@dpdk.org>
Subject: Re: [PATCH 2/5] build: remove version check on compiler links function
Date: Tue, 15 Oct 2024 10:16:58 +0200 [thread overview]
Message-ID: <D4W8C36KFP8J.1WTB7I57G6JK8@redhat.com> (raw)
In-Reply-To: <20240920125737.1197969-3-bruce.richardson@intel.com>
Bruce Richardson, Sep 20, 2024 at 14:57:
> The "compiler.links()" function meson documentation [1] is a little
> unclear, in a casual reading implies that the function was new in 0.60
> meson release. In fact, it is only enhanced as described in that
> release, but is present earlier.
> As such, we can remove the version checks preceeding the calls to links
> function in our code.
>
> [1] https://mesonbuild.com/Reference-manual_returned_compiler.html#compilerlinks
>
> Fixes: fd809737cf8c ("common/qat: fix build with incompatible IPsec library")
> Fixes: fb94d8243894 ("crypto/ipsec_mb: add dependency check for cross build")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Reviewed-by: Robin Jarry <rjarry@redhat.com>
prev parent reply other threads:[~2024-10-15 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240920125737.1197969-1-bruce.richardson@intel.com>
2024-09-20 12:57 ` Bruce Richardson
2024-10-15 8:16 ` Robin Jarry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4W8C36KFP8J.1WTB7I57G6JK8@redhat.com \
--to=rjarry@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).