patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/mlx5: fix item flag on GENEVE item validation
@ 2019-12-18 15:09 Dekel Peled
  2019-12-18 15:20 ` Matan Azrad
  2019-12-19 11:26 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Dekel Peled @ 2019-12-18 15:09 UTC (permalink / raw)
  To: matan, viacheslavo, shahafs; +Cc: orika, dev, stable

On validation of GENEVE item, the wrong flag is used.
This patch sets the correct bit in item_flags bitmap.

Fixes: e59a5dbcfd07 ("net/mlx5: add flow match on GENEVE item")
Cc: stable@dpdk.org

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 1a1b6ec..6f35fe1 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -4489,7 +4489,7 @@ struct field_modify_info modify_tcp[] = {
 							     error);
 			if (ret < 0)
 				return ret;
-			last_item = MLX5_FLOW_LAYER_VXLAN_GPE;
+			last_item = MLX5_FLOW_LAYER_GENEVE;
 			break;
 		case RTE_FLOW_ITEM_TYPE_MPLS:
 			ret = mlx5_flow_validate_item_mpls(dev, items,
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/mlx5: fix item flag on GENEVE item validation
  2019-12-18 15:09 [dpdk-stable] [PATCH] net/mlx5: fix item flag on GENEVE item validation Dekel Peled
@ 2019-12-18 15:20 ` Matan Azrad
  2019-12-19 11:26 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Matan Azrad @ 2019-12-18 15:20 UTC (permalink / raw)
  To: Dekel Peled, Slava Ovsiienko, Shahaf Shuler; +Cc: Ori Kam, dev, stable



From: Dekel Peled 
> On validation of GENEVE item, the wrong flag is used.
> This patch sets the correct bit in item_flags bitmap.
> 
> Fixes: e59a5dbcfd07 ("net/mlx5: add flow match on GENEVE item")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix item flag on GENEVE item validation
  2019-12-18 15:09 [dpdk-stable] [PATCH] net/mlx5: fix item flag on GENEVE item validation Dekel Peled
  2019-12-18 15:20 ` Matan Azrad
@ 2019-12-19 11:26 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2019-12-19 11:26 UTC (permalink / raw)
  To: Dekel Peled, Matan Azrad, Slava Ovsiienko, Shahaf Shuler
  Cc: Ori Kam, dev, stable

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Wednesday, December 18, 2019 5:10 PM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix item flag on GENEVE item
> validation
> 
> On validation of GENEVE item, the wrong flag is used.
> This patch sets the correct bit in item_flags bitmap.
> 
> Fixes: e59a5dbcfd07 ("net/mlx5: add flow match on GENEVE item")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 1a1b6ec..6f35fe1 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -4489,7 +4489,7 @@ struct field_modify_info modify_tcp[] = {
>  							     error);
>  			if (ret < 0)
>  				return ret;
> -			last_item = MLX5_FLOW_LAYER_VXLAN_GPE;
> +			last_item = MLX5_FLOW_LAYER_GENEVE;
>  			break;
>  		case RTE_FLOW_ITEM_TYPE_MPLS:
>  			ret = mlx5_flow_validate_item_mpls(dev, items,
> --
> 1.8.3.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-19 11:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 15:09 [dpdk-stable] [PATCH] net/mlx5: fix item flag on GENEVE item validation Dekel Peled
2019-12-18 15:20 ` Matan Azrad
2019-12-19 11:26 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).