From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9F9BA051A for ; Wed, 10 Jun 2020 05:56:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D01832B86; Wed, 10 Jun 2020 05:56:45 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by dpdk.org (Postfix) with ESMTP id D7B9A29CB; Wed, 10 Jun 2020 05:56:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eyUTJ5p9ZKohLOaM6r2peT5Wg/Baldi372g7AsBSu68=; b=zIBrww6n7Uh+wGExPdMGo/8alAe0mNWjuvBEURDPWDmQqk+CYS23vRRE1nG+aiSY0wd9UNyMPqAU1JYFMaY0Cdyudq8JdRVAFhc8GpEsDoL9vePSCrwxgGBzUqbBSxNJzfEPFQHuraQ8HMDCDeLk3I4YGyxCayENYBIdwBUlc0Q= Received: from DB7PR05CA0066.eurprd05.prod.outlook.com (2603:10a6:10:2e::43) by AM0PR08MB5524.eurprd08.prod.outlook.com (2603:10a6:208:181::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.20; Wed, 10 Jun 2020 03:56:42 +0000 Received: from DB5EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::ac) by DB7PR05CA0066.outlook.office365.com (2603:10a6:10:2e::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.19 via Frontend Transport; Wed, 10 Jun 2020 03:56:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT050.mail.protection.outlook.com (10.152.21.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18 via Frontend Transport; Wed, 10 Jun 2020 03:56:42 +0000 Received: ("Tessian outbound 39cdd740f5cb:v59"); Wed, 10 Jun 2020 03:56:42 +0000 X-CR-MTA-TID: 64aa7808 Received: from 866c79942d47.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CCEFBE04-9E94-4692-A441-463E9A7EF223.1; Wed, 10 Jun 2020 03:56:37 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 866c79942d47.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 10 Jun 2020 03:56:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=guh6OsEoeZ9lxZExZvUFs4Nr9s4D+7ftVkHO5I+1ZP+TvAXfXRmsJwguR6RmiEaMRQD6FoPGeIekNoczsNeZdYdyu4pgsaL4WgTMskNth055yxgf/OcKiQ63IzcCR3fE6a9XQ3LkGtAKLdEoP4YqR+DPfQdIEzowrQZABXV1mRIz6hqIdcwWCUaJH9bIntJwkopfZapE6zsIvcobOobZej038x0vKY1mxBXVRVudoJHVWwn3brFicHC0eTZ0xjxMJkLZt5PDyrbkLnEEw9YfUUjKUHlKNatnTFf8ELvH6joZGCY94TGUszNNMj6d0mvrpTpzCBIXCV6YKuIjZLUocQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eyUTJ5p9ZKohLOaM6r2peT5Wg/Baldi372g7AsBSu68=; b=H1yRi92GHuAyvAOJhO2MwMj2EwxE39j4yqs3+euG77zft6j/eSgQuCHWSdlGSh1zh+pf1jnwxSSKy6ABC8nGGol1jqIn+kDWRWmPeoCwDxQ7kdpXYzpEi0ybsQ8qFnQ8OqeNSEMsDmN/avV+L7iOlHDxl6zXX9esoOBpBUoBAj6R71Dwm1u2G66q+a1ijGoTVpTYAgWY1MOmrDb5PjYgdmDKOr1BhJO7HD3zAGatN/2hfVAh0ATfptv36BkD9/jdGIbr0Em1R73o9lFUSEq1HUgdCDGMi0rGSsUIx99Wy7qDp/sFB7z4185lQDVZmPbfXyfFSjATXfPPUAmLxMx0RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eyUTJ5p9ZKohLOaM6r2peT5Wg/Baldi372g7AsBSu68=; b=zIBrww6n7Uh+wGExPdMGo/8alAe0mNWjuvBEURDPWDmQqk+CYS23vRRE1nG+aiSY0wd9UNyMPqAU1JYFMaY0Cdyudq8JdRVAFhc8GpEsDoL9vePSCrwxgGBzUqbBSxNJzfEPFQHuraQ8HMDCDeLk3I4YGyxCayENYBIdwBUlc0Q= Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9) by DB6PR0802MB2168.eurprd08.prod.outlook.com (2603:10a6:4:84::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Wed, 10 Jun 2020 03:56:35 +0000 Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::1128:b7e7:e832:310f]) by DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::1128:b7e7:e832:310f%9]) with mapi id 15.20.3066.023; Wed, 10 Jun 2020 03:56:35 +0000 From: Honnappa Nagarahalli To: Feifei Wang , Konstantin Ananyev CC: "dev@dpdk.org" , nd , Feifei Wang , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue Thread-Index: AQHWPtjPYmUJ9riRyEax92VlMgHOLKjROCWA Date: Wed, 10 Jun 2020 03:56:35 +0000 Message-ID: References: <20200610033918.45834-1-feifei.wang2@arm.com> In-Reply-To: <20200610033918.45834-1-feifei.wang2@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 022d6c82-236d-4aa4-b3b1-db7a6a96671b.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [107.77.222.116] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 69596557-648d-4abb-73f7-08d80cf2492b x-ms-traffictypediagnostic: DB6PR0802MB2168:|AM0PR08MB5524: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; x-forefront-prvs: 0430FA5CB7 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Om9z4XFgaE5RvAqSyO/mQrdOTlcBaDoPS5rBAZVkJ7LEhTIsO4cVtP5D/LA3SJV7xMUURhCeoI5hcM6aLuANtMDuRjK3Qt29TTr1lXyuNATYbxCUFng60959UhHyhRh/PuT+hBByG5i0KuNp5ihvBn8jXN4RlabW9Mcl07sVYpZ23+CmIk30lX5/Iy6aqUFq09c/I3dZiqg0LjMP9FLKwDAAuW4gG9PgQ+44p13u+fMXFy9yTf5A0dI7KGbQcX9kHppi9hc0hUP4eAqGeSupDxwk4q15yIM8gUsEA0mXol5sBasJqrPJUlgD2snrYLjD X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(136003)(376002)(39850400004)(366004)(64756008)(66556008)(55016002)(66446008)(66946007)(8936002)(76116006)(478600001)(71200400001)(110136005)(66476007)(52536014)(7696005)(53546011)(26005)(33656002)(186003)(4326008)(86362001)(6506007)(9686003)(83380400001)(8676002)(54906003)(5660300002)(2906002)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: aUgJh+vsjy5Ha/WpJSBUR0TYJgw/0kqXzqjJiMBLFFrXw+v9rpS5w5D9wKgD1XXNZgm9WGvvQXtJ2hguI8K0WD4mHDzNEPIVNeyTcof04t8lQLVBSzxDMFU7JUNvbCTcan5vAOdDn648+tQFQzx0hWxulZlgkCRYmotVO05qQvNmfJePF1xSkMVxwdkRgt78sM+fo2oWXJtte76//Rrj0+N0JJVAVwScn7RLXYTqLEqw3j55ZC+bD7S1/TjSgoNXYQ4m2+zwYsj0Rr1f+gpl802hKE3ZoVoebvWIrqphS3jqCgQYqx++fhDLDlYjzswDR/zhBjG4hOxKSToS0IPXSDjLmGgx3SCqq3ekXlfnlBuvhiGTJjVBm6lu7e8mCMnepEwfng6nMGAzyxt0IxnDoaAX+/sg0MSBLCsawrvolCb3D02DdzQ7nqECC/BJ2vsXwDb3h0Lz78chJByVIcaanprdw+1ac0mQGdR6ErP2c1HtsYrZ9+XBZueb7qptDjhD Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2168 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT050.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(39850400004)(136003)(396003)(46966005)(82740400003)(5660300002)(2906002)(52536014)(356005)(4326008)(54906003)(186003)(478600001)(81166007)(86362001)(450100002)(6506007)(8676002)(83380400001)(26005)(7696005)(110136005)(8936002)(9686003)(82310400002)(55016002)(70586007)(47076004)(53546011)(316002)(33656002)(336012)(70206006); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 1a686f16-73ea-46a0-82ee-08d80cf2451f X-Forefront-PRVS: 0430FA5CB7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b0hSc9JuO2Sjtxt0RY6XBWSt7eZbscj9RGcOqDDy+4MRKOO219/OoE/+GGINyKV8JR3UanhNWxoDr01jhEkQBqzE9WH52RIZ3cf13UC6d/4PCZuBQvdz4eal+I7uwmZSLSoTr+0iCx5mUFrSJ1LzTfuhH8iZxlu6dda1QZWCD4f7q/6g4C19a+UMW8OLVkKg4laSBQdaw4jT7WjLU7gkQOab6VAUAIuTC4MsX9fSD+s7jj6H05t2WT8Q44Kpi3Fj0AGSkFufJJzBUHTbOXBqUS5V+TTOrUTIjMk4Dn8cz75IjA4JX3YaiFKBaaTRPk7Orv4zDCE6Lcx/yAb0gVgvtINmqAwWAE52XhBJnMsOMc5nz5V8tuoYNbygkIDdNUW2tnQTwElmibZadypoHHHp6A== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2020 03:56:42.2038 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69596557-648d-4abb-73f7-08d80cf2492b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5524 Subject: Re: [dpdk-stable] [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Feifei, Thanks for the patch. Few nits inline. > -----Original Message----- > From: Feifei Wang > Sent: Tuesday, June 9, 2020 10:39 PM > To: Honnappa Nagarahalli ; Konstantin > Ananyev > Cc: dev@dpdk.org; nd ; Feifei Wang > ; stable@dpdk.org > Subject: [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue >=20 > Directly call "_rte_ring_do_enqueue_elem" function can result in the proc= ess > skips the "switch" order and cannot call the APIs of RTS and HTS mode in > "rte_ring_enqueue_bulk_elem" function. may be " lib/ring: fix bulk enqueue API to allow HTS/RTS modes"? >=20 > To fix it, remove the unnecessary function and make > "_rte_ring_do_enqueue_elem" consistent with > "_rte_ring_do_dequeue_elem". How about something like: Remove the unwanted call to "_rte_ring_do_enqueue_elem" to allow for correc= t handling of RTS/HTS modes. >=20 > Fixes: e6ba4731c0f3 ("ring: introduce RTS ring mode") > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/librte_ring/rte_ring_elem.h | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/lib/librte_ring/rte_ring_elem.h b/lib/librte_ring/rte_ring_e= lem.h > index a5a4c46f9..469aee7da 100644 > --- a/lib/librte_ring/rte_ring_elem.h > +++ b/lib/librte_ring/rte_ring_elem.h > @@ -578,9 +578,6 @@ static __rte_always_inline unsigned int > rte_ring_enqueue_bulk_elem(struct rte_ring *r, const void *obj_table, > unsigned int esize, unsigned int n, unsigned int *free_space) { > - return __rte_ring_do_enqueue_elem(r, obj_table, esize, n, > - RTE_RING_QUEUE_FIXED, r->prod.sync_type, > free_space); > - > switch (r->prod.sync_type) { > case RTE_RING_SYNC_MT: > return rte_ring_mp_enqueue_bulk_elem(r, obj_table, esize, n, Otherwise, Acked-by: Honnappa Nagarahalli > -- > 2.17.1