From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10082.outbound.protection.outlook.com [40.107.1.82]) by dpdk.org (Postfix) with ESMTP id A7CF21B44E; Wed, 20 Jun 2018 07:34:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YNfEFZ3Z3c9hTcwtnsBUtrcc+oPkBMftX4UHwVWDvQ8=; b=VVNk2scX4bHeHv6vZ6qauSuLOfviTwPk2i8/HrJ2U1Z99m/Q0run/aNTMO8/2ttw/CgpiWJhDbEskxX+H2CGrWEC4hfpm41lq7PwJZD7hcLcbp/7zTDWw//d+2cjftgnje62hiXaha8gKcT4GEDdBG8YD4e7dw9qwgAk5fEk/lY= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4460.eurprd05.prod.outlook.com (52.134.109.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Wed, 20 Jun 2018 05:34:23 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b%4]) with mapi id 15.20.0863.016; Wed, 20 Jun 2018 05:34:23 +0000 From: Shahaf Shuler To: Raslan Darawsheh , Yongseok Koh , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , Adrien Mazarguil CC: "dev@dpdk.org" , Matan Azrad , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix Rss level validation Thread-Index: AQHUB870zHC2kTzDb0mo4JwvCz0IJqRooE9g Date: Wed, 20 Jun 2018 05:34:23 +0000 Message-ID: References: <1529413738-28378-1-git-send-email-rasland@mellanox.com> In-Reply-To: <1529413738-28378-1-git-send-email-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4460; 7:iUFAXVHo8dUqVVQRxEeVvYEgQkbHrmuUL0JG8Abb0oAc63zR7Ts7ia1i7bLZPT59cbhXzcGTDuhcqiuejguRLzhxKoXGcjHd1B7Kej+2bGGsKGNx+7pQ8CE6lbHmDsFYm/OtbHOI4YeEP/oYwa6NIJb85tWeG75X17jlINDRrXhArUqaWpoEVtwjNATef23GGK4mMYwlL1gYhYXmvmZTNyKqfbP1DeWA1mH33hUw60R3MIJf5gmRo6DqTqnuGtzp x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 791307a5-5aff-425c-eb90-08d5d66f7b30 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4460; x-ms-traffictypediagnostic: DB7PR05MB4460: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4460; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4460; x-forefront-prvs: 070912876F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(39860400002)(376002)(39380400002)(199004)(189003)(102836004)(3280700002)(110136005)(6506007)(26005)(76176011)(7696005)(3660700001)(316002)(74316002)(305945005)(478600001)(5250100002)(2906002)(99286004)(14454004)(3846002)(86362001)(5660300001)(54906003)(33656002)(6116002)(2900100001)(7736002)(6436002)(97736004)(106356001)(229853002)(66066001)(55016002)(53936002)(105586002)(68736007)(25786009)(6246003)(4326008)(81156014)(8676002)(8936002)(11346002)(486006)(81166006)(446003)(476003)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4460; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: u0YD9zSpo+C9FcPREzW4J/+09+6fzAi5wThmk7A4gcYbsIbDrgrrVSZLifpoHVezxhZhPAFZDqTrMLoUq8yY5lJjraEMMMt7djpPmarsDrabm1c9AIqjXZE0GSJNK5jVkaacspyneRyyFt0kKHlCEWgyt9gt5v+bB4i93tISziaFOolKsgGD5D3R79R8eaH41rX1ZKo7LIFaiLiz9KTdGfq0ae4bFglhBco6tooJcwqidf3wEJ5Oga109/TuY9bG4qV4HZ0Gp2T5iHYxltcn3fcSfvIts5ITZkQtP0rrsDbnK09swfj+7TlSe5clqWym spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 791307a5-5aff-425c-eb90-08d5d66f7b30 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2018 05:34:23.8529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4460 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix Rss level validation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 05:34:26 -0000 Adding the maintainers,=20 Tuesday, June 19, 2018 4:09 PM, Raslan Darawsheh: >Subject: [PATCH] net/mlx5: fix Rss level validation Rss -> RSS > >When setting the level in rss action it's checking for the value stored in= the >parser which is set to 0 by default. > >this change the check to be for the requested action insted. this -> This instead -> instead > >Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") > >Cc: stable@dpdk.org >Signed-off-by: Raslan Darawsheh >--- > drivers/net/mlx5/mlx5_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c >index 994be05..40df633 100644 >--- a/drivers/net/mlx5/mlx5_flow.c >+++ b/drivers/net/mlx5/mlx5_flow.c >@@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > return -rte_errno; > } > #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT >- if (parser->rss_conf.level > 1) { >+ if (rss->level > 1) { > rte_flow_error_set(error, EINVAL, > >RTE_FLOW_ERROR_TYPE_ACTION, > actions, >@@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > return -rte_errno; > } > #endif >- if (parser->rss_conf.level > 2) { >+ if (rss->level > 2) { > rte_flow_error_set(error, EINVAL, > >RTE_FLOW_ERROR_TYPE_ACTION, > actions, >-- The above changes (if they are the only one) can be address by me when I ap= ply the patch. Will wait few days for the maintainers comments. Acked-by: Shahaf Shuler >2.7.4