From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60076.outbound.protection.outlook.com [40.107.6.76]) by dpdk.org (Postfix) with ESMTP id D6E9E160; Tue, 24 Jul 2018 15:48:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iehg1N9SZyhpwncAAOie6diOF42A3EjBBExAFlB4W+8=; b=BaH7Q0S1W0dzby0E1VtutoSwICmhCk9U+0B5EM+nK6Vq8/5fdCxmDWX9VBPSHjVRvwITgv6x2dNsnAwSmZCRWvcE5M64unAWBXPX7Cc/I4uQjdjiVWev+YxsR9Weqt+prcdxOzxC4V0798fMKDqnMH8BY51lx/hSqcFn7Ls4qRU= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5099.eurprd05.prod.outlook.com (20.176.237.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Tue, 24 Jul 2018 13:48:47 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%3]) with mapi id 15.20.0952.022; Tue, 24 Jul 2018 13:48:47 +0000 From: Shahaf Shuler To: Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix assert for Tx completion queue count Thread-Index: AQHUIq8UQuglvCb2MkeROze7vMMkJKSeZHRQ Date: Tue, 24 Jul 2018 13:48:47 +0000 Message-ID: References: <20180723180010.3575-1-yskoh@mellanox.com> In-Reply-To: <20180723180010.3575-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5099; 7:+YovIURTHNeY2JLq9LpeqamVYFjU5Wq+Ge94hmln91LlHJ+52ZJIxj6haeA7ZvgCSwpFKrty4UZKGBQ+5F71cBm548QJdiUU3kOTPVTPOZTQQvkBujC+K3tB2KlIL7CbUgx2l8XZizvuCaK5JMsHl/65boK7Sg4QfMU3+M0whOW3De2371ayzVqbp3QFMVGvH7gZmoyuseHEcu1bgaWJsqupnKodlXglllwPHjF/a29slpbtgu4it6Wnv1pRRDyQ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: fe4f6533-9b9d-4b90-4a00-08d5f16c2e11 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5099; x-ms-traffictypediagnostic: DB7PR05MB5099: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB5099; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5099; x-forefront-prvs: 0743E8D0A6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(366004)(346002)(376002)(396003)(189003)(199004)(97736004)(81166006)(74316002)(2900100001)(33656002)(305945005)(450100002)(6862004)(4326008)(14454004)(316002)(54906003)(478600001)(6116002)(3846002)(2906002)(5250100002)(256004)(25786009)(66066001)(106356001)(105586002)(6436002)(229853002)(53936002)(6246003)(9686003)(55016002)(486006)(446003)(11346002)(86362001)(8936002)(99286004)(5660300001)(476003)(7736002)(81156014)(7696005)(8676002)(102836004)(76176011)(6636002)(68736007)(6506007)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5099; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: OiaLNRk7eYvauQDnEhVZdH9bol8M6JsR4miS17HVBrVU59/GpzUq+Ez0mfEg3CnESxwI0GvUT+xsZFf4oH34NaV3M0PmC5AfIY/KAE6yWUATd/hCvSKF6StOslJU206kcSf3O4pYz7onVUHfkLw4CBYnodW6tjbSXagkCIPzjdscUW25FtFZEVJc6tV8xEsuCj/VQNhDdcjr2T27A4uwruih8MeeX8HPQvmCcnxW1duAqhoKv6IJLKVKPrCKMOJfc0bqmvQKWd+2SFCVUZe4j8wGa1LFTB6am0xQNH9uTud7OW1VVyqrSEfLQcOJQv+IvjyZQAORhPnCN6AsO0TFHog5f5SQdZ3yubmCzNl6Sv0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe4f6533-9b9d-4b90-4a00-08d5f16c2e11 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2018 13:48:47.3815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5099 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix assert for Tx completion queue count X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 13:48:49 -0000 Monday, July 23, 2018 9:00 PM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix assert for Tx completion queue count >=20 > There should be at least one Tx CQE remained if Tx WQ and txq->elts[] hav= e > available slots to send a packet because the size of Tx CQ is exactly cal= culated > from the size of other resources. As it is guaranteed, it is checked by a= n > assertion. >=20 > max_elts is checked after the assertion for Tx CQ. If no slot is availabl= e in txq- > >elts[], the assertion would be wrong. >=20 > Fixes: 2eefbec531c7 ("net/mlx5: add missing sanity checks for Tx completi= on > queue") > Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for > ConnectX-5") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh > Acked-by: Xueming Li Applied to next-net-mlx, thanks.=20