From: Kathleen Capella <Kathleen.Capella@arm.com>
To: Feifei Wang <Feifei.Wang2@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Jianbo Liu <jianbo.liu@linaro.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Feifei Wang <Feifei.Wang2@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector
Date: Wed, 10 Mar 2021 19:50:49 +0000 [thread overview]
Message-ID: <DBAPR08MB5752492E3845711CA28A80B087919@DBAPR08MB5752.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210310024029.20772-1-feifei.wang2@arm.com>
Tested-by: Kathleen Capella <kathleen.capella@arm.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Feifei Wang
> Sent: Tuesday, March 9, 2021 9:40 PM
> To: jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>; Beilei Xing
> <beilei.xing@intel.com>; Jeff Guo <jia.guo@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Jianbo Liu <jianbo.liu@linaro.org>
> Cc: dev@dpdk.org; nd <nd@arm.com>; Feifei Wang <Feifei.Wang2@arm.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector
>
> In i40e NEON vector rx path, the packet descs processing is incorrect.
> This caused wrong packet type been filled in mbuf.
>
> To fix this, when shifting the pktlen field to be 16-bit aligned, it only needs to
> process the high 16bit of the packet descs instead of the high 32bit.
>
> Test Results:
> Architecture: arm64
> NIC: XL710
> Driver: i40e
> Package: Ether()/IP()/
>
> Without this patch:
> desc_to_ptype_v: ptype = 7 (error)
>
> With this patch:
> desc_to_ptype_v: ptype = 23 (correct)
>
> Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM")
> Cc: stable@dpdk.org
>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> drivers/net/i40e/i40e_rxtx_vec_neon.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c
> b/drivers/net/i40e/i40e_rxtx_vec_neon.c
> index d81269624..ada82a14d 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c
> @@ -310,10 +310,16 @@ _recv_raw_pkts_vec(struct i40e_rx_queue
> *__rte_restrict rxq,
> /* pkt 3,4 shift the pktlen field to be 16-bit aligned*/
> uint32x4_t len3 = vshlq_u32(vreinterpretq_u32_u64(descs[3]),
> len_shl);
> - descs[3] = vreinterpretq_u64_u32(len3);
> + descs[3] = vreinterpretq_u64_u16(vsetq_lane_u16
> + (vgetq_lane_u16(vreinterpretq_u16_u32(len3),
> 7),
> + vreinterpretq_u16_u64(descs[3]),
> + 7));
> uint32x4_t len2 = vshlq_u32(vreinterpretq_u32_u64(descs[2]),
> len_shl);
> - descs[2] = vreinterpretq_u64_u32(len2);
> + descs[2] = vreinterpretq_u64_u16(vsetq_lane_u16
> + (vgetq_lane_u16(vreinterpretq_u16_u32(len2),
> 7),
> + vreinterpretq_u16_u64(descs[2]),
> + 7));
>
> /* D.1 pkt 3,4 convert format from desc to pktmbuf */
> pkt_mb4 = vqtbl1q_u8(vreinterpretq_u8_u64(descs[3]),
> shuf_msk); @@ -341,10 +347,16 @@ _recv_raw_pkts_vec(struct i40e_rx_queue
> *__rte_restrict rxq,
> /* pkt 1,2 shift the pktlen field to be 16-bit aligned*/
> uint32x4_t len1 = vshlq_u32(vreinterpretq_u32_u64(descs[1]),
> len_shl);
> - descs[1] = vreinterpretq_u64_u32(len1);
> + descs[1] = vreinterpretq_u64_u16(vsetq_lane_u16
> + (vgetq_lane_u16(vreinterpretq_u16_u32(len1),
> 7),
> + vreinterpretq_u16_u64(descs[1]),
> + 7));
> uint32x4_t len0 = vshlq_u32(vreinterpretq_u32_u64(descs[0]),
> len_shl);
> - descs[0] = vreinterpretq_u64_u32(len0);
> + descs[0] = vreinterpretq_u64_u16(vsetq_lane_u16
> + (vgetq_lane_u16(vreinterpretq_u16_u32(len0),
> 7),
> + vreinterpretq_u16_u64(descs[0]),
> + 7));
>
> /* D.1 pkt 1,2 convert format from desc to pktmbuf */
> pkt_mb2 = vqtbl1q_u8(vreinterpretq_u8_u64(descs[1]),
> shuf_msk);
> --
> 2.25.1
next prev parent reply other threads:[~2021-03-10 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 2:40 [dpdk-stable] " Feifei Wang
2021-03-10 19:50 ` Kathleen Capella [this message]
2021-03-25 1:59 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB5752492E3845711CA28A80B087919@DBAPR08MB5752.eurprd08.prod.outlook.com \
--to=kathleen.capella@arm.com \
--cc=Feifei.Wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jia.guo@intel.com \
--cc=jianbo.liu@linaro.org \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).